GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/common/block/acpi: Factor out common pch_glan.asl 

This patch moves pch_glan.asl into common block acpi directory to
avoid duplicating the same ASL code block across SoC directory.

TEST=Able to build and boot TGL, CNL and CML platform.
1) Dump and disassemble DSDT, verify GLAN device present inside
common pch_glan.asl is still there.
2) Verify no ACPI error seen while running 'dmesg` from console.

Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Change-Id: I479678c864eba39e5ab04f658600e8cba48198ef
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45975
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Subrata Banik 2020-10-03 19:45:35 +05:30
parent 34cf7ccebc
commit d2becae223
10 changed files with 14 additions and 60 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/intel/cannonlake/acpi/southbridge.asl
View File

@ -43,8 +43,8 @@
/* PCI _OSC */
#include <soc/intel/common/acpi/pci_osc.asl>
/* GBe 0:1f.6 */
#include "pch_glan.asl"
/* GbE 0:1f.6 */
#include <soc/intel/common/block/acpi/acpi/pch_glan.asl>
/* PMC Core */
#include <soc/intel/common/block/acpi/acpi/pmc.asl>

1
src/soc/intel/cannonlake/acpi/pch_glan.asl → src/soc/intel/common/block/acpi/acpi/pch_glan.asl
View File

@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0-only */
/* Intel Gigabit Ethernet Controller 0:1f.6 */
#include <soc/gpe.h>
Device (GLAN)
{

14
src/soc/intel/elkhartlake/acpi/pch_glan.asl
View File

@ -1,14 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-only */
/* Intel Gigabit Ethernet Controller 0:1f.6 */
Device (GLAN)
{
Name (_ADR, 0x001f0006)
Name (_S0W, 3)
Name (_PRW, Package() {GPE0_PME_B0, 4})
Method (_DSW, 3) {}
}

3
src/soc/intel/elkhartlake/acpi/southbridge.asl
View File

@ -43,3 +43,6 @@
/* EMMC/SD card */
#include "scs.asl"
/* GbE 0:1f.6 */
#include <soc/intel/common/block/acpi/acpi/pch_glan.asl>

14
src/soc/intel/icelake/acpi/pch_glan.asl
View File

@ -1,14 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-only */
/* Intel Gigabit Ethernet Controller 0:1f.6 */
Device (GLAN)
{
Name (_ADR, 0x001f0006)
Name (_S0W, 3)
Name (_PRW, Package() {GPE0_PME_B0, 4})
Method (_DSW, 3) {}
}

4
src/soc/intel/icelake/acpi/southbridge.asl
View File

@ -38,5 +38,5 @@
/* PCI _OSC */
#include <soc/intel/common/acpi/pci_osc.asl>
/* GBe 0:1f.6 */
#include "pch_glan.asl"
/* GbE 0:1f.6 */
#include <soc/intel/common/block/acpi/acpi/pch_glan.asl>

14
src/soc/intel/jasperlake/acpi/pch_glan.asl
View File

@ -1,14 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-only */
/* Intel Gigabit Ethernet Controller 0:1f.6 */
Device (GLAN)
{
Name (_ADR, 0x001f0006)
Name (_S0W, 3)
Name (_PRW, Package() {GPE0_PME_B0, 4})
Method (_DSW, 3) {}
}

3
src/soc/intel/jasperlake/acpi/southbridge.asl
View File

@ -49,3 +49,6 @@
/* EMMC/SD card */
#include "scs.asl"
/* GbE 0:1f.6 */
#include <soc/intel/common/block/acpi/acpi/pch_glan.asl>

14
src/soc/intel/tigerlake/acpi/pch_glan.asl
View File

@ -1,14 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-only */
/* Intel Gigabit Ethernet Controller 0:1f.6 */
Device (GLAN)
{
Name (_ADR, 0x001f0006)
Name (_S0W, 3)
Name (_PRW, Package() {GPE0_PME_B0, 4})
Method (_DSW, 3) {}
}

3
src/soc/intel/tigerlake/acpi/southbridge.asl
View File

@ -43,3 +43,6 @@
/* PMC Core*/
#include <soc/intel/common/block/acpi/acpi/pmc.asl>
/* GbE 0:1f.6 */
#include <soc/intel/common/block/acpi/acpi/pch_glan.asl>