From d2bed05e6adc7ea22188917c9551f4cb2d8c949d Mon Sep 17 00:00:00 2001 From: David Hendricks Date: Tue, 12 Mar 2013 21:28:07 -0700 Subject: [PATCH] exynos5250/snow: call PMIC's power_init() function Call the power_init() function. We appear to have forgotten about it when deprecating lowlevel_init_subsystems(), but it didn't seem to cause problems until we got to doing more interesting stuff recently. There are some clean-ups to do from the original code, such as not attempting to configure I2C from PMIC code, which we'll get around to in follow-up patches. (Credit to Gabe for spotting this) Change-Id: I6a59379e9323277d0b61469de9abe6d651ac5bfb Signed-off-by: Gabe Black Signed-off-by: David Hendricks Reviewed-on: http://review.coreboot.org/2699 Reviewed-by: Hung-Te Lin Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich --- src/cpu/samsung/exynos5250/Makefile.inc | 1 + src/mainboard/google/snow/romstage.c | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/src/cpu/samsung/exynos5250/Makefile.inc b/src/cpu/samsung/exynos5250/Makefile.inc index 33fcedcc40..2774b12c28 100644 --- a/src/cpu/samsung/exynos5250/Makefile.inc +++ b/src/cpu/samsung/exynos5250/Makefile.inc @@ -17,6 +17,7 @@ romstage-y += pinmux.c # required by s3c24x0_i2c (exynos5-common) and uart. romstage-y += exynos_cache.c romstage-y += dmc_common.c romstage-y += dmc_init_ddr3.c +romstage-y += power.c romstage-$(CONFIG_EARLY_CONSOLE) += soc.c romstage-$(CONFIG_EARLY_CONSOLE) += uart.c diff --git a/src/mainboard/google/snow/romstage.c b/src/mainboard/google/snow/romstage.c index 83d5105852..c2f5fc9f0a 100644 --- a/src/mainboard/google/snow/romstage.c +++ b/src/mainboard/google/snow/romstage.c @@ -30,6 +30,7 @@ #include #include #include +#include #include #include #include @@ -90,6 +91,12 @@ void main(void) console_init(); + /* + * FIXME: Do necessary I2C init so low-level PMIC code doesn't need to. + * Also, we should only call power_init() on cold boot. + */ + power_init(); + if (!mem) { printk(BIOS_CRIT, "Unable to auto-detect memory timings\n"); while(1);