From d328934c9b9d1454a83971182627565a5d116cb0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Niew=C3=B6hner?= Date: Tue, 24 Nov 2020 13:24:47 +0100 Subject: [PATCH] mb/supermicro/x11ssm-f: drop NMI overrides MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Drop the NMI overrides, since NMI now gets configured in gpio common code. Also remove the variant init mechanism, which is unused now. Signed-off-by: Michael Niewöhner Change-Id: I02e0c679f9aafe33108320a8dfc62dcb278202ef Reviewed-on: https://review.coreboot.org/c/coreboot/+/48092 Reviewed-by: Tim Wawrzynczak Tested-by: build bot (Jenkins) --- .../supermicro/x11-lga1151-series/Makefile.inc | 2 -- .../x11-lga1151-series/include/mainboard.h | 10 ---------- .../supermicro/x11-lga1151-series/mainboard.c | 9 --------- .../variants/x11ssm-f/Makefile.inc | 1 - .../variants/x11ssm-f/mainboard.c | 13 ------------- 5 files changed, 35 deletions(-) delete mode 100644 src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h delete mode 100644 src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc delete mode 100644 src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c diff --git a/src/mainboard/supermicro/x11-lga1151-series/Makefile.inc b/src/mainboard/supermicro/x11-lga1151-series/Makefile.inc index a4ebe461b0..40afacb41c 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/Makefile.inc +++ b/src/mainboard/supermicro/x11-lga1151-series/Makefile.inc @@ -8,5 +8,3 @@ bootblock-y += variants/$(VARIANT_DIR)/gpio_early.c ramstage-y += mainboard.c ramstage-y += variants/$(VARIANT_DIR)/gpio.c ramstage-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c - -subdirs-y += variants/$(VARIANT_DIR) diff --git a/src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h b/src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h deleted file mode 100644 index cad75f4baf..0000000000 --- a/src/mainboard/supermicro/x11-lga1151-series/include/mainboard.h +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#ifndef _BASEBOARD_X11_LGA1151_SERIES_H -#define _BASEBOARD_X11_LGA1151_SERIES_H - -#include - -void variant_mainboard_init(void *chip_info); - -#endif /* _BASEBOARD_X11_LGA1151_SERIES_H */ diff --git a/src/mainboard/supermicro/x11-lga1151-series/mainboard.c b/src/mainboard/supermicro/x11-lga1151-series/mainboard.c index 0f8dbed2ed..b7ea1f2b64 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/mainboard.c +++ b/src/mainboard/supermicro/x11-lga1151-series/mainboard.c @@ -1,20 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include #include #include -__weak void variant_mainboard_init(void *chip_info) -{ -} - static void mainboard_chip_init(void *chip_info) { - /* do common init */ mainboard_configure_gpios(); - - /* do variant init */ - variant_mainboard_init(chip_info); } struct chip_operations mainboard_ops = { diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc deleted file mode 100644 index f3c87b2318..0000000000 --- a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Makefile.inc +++ /dev/null @@ -1 +0,0 @@ -ramstage-y += mainboard.c diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c deleted file mode 100644 index 75351eb6de..0000000000 --- a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/mainboard.c +++ /dev/null @@ -1,13 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include -#include -#include - -void variant_mainboard_init(void *chip_info) -{ - // TODO: NMI; is this needed? vendor sets it - pcr_write32(0xae, 0x01e4, 0x00000004); - pcr_write32(0xae, 0x01e8, 0x00000040); -}