GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/drivers/intel/fsp1_1: Always report returned status of FspTempRamInit() 

Returned status code FspTempRamInit() is not displayed when error occurs.
Move the printk() call before the check for status.

BUG=NA
TEST=Portwell PQ7-M107

Change-Id: Id87e5c765d09f4ab199db9eba07a949b031a709a
Signed-off-by: Frans Hendriks <fhendriks@eltan.com>
Reviewed-on: https://review.coreboot.org/c/29695
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: Huang Jin <huang.jin@intel.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Frans Hendriks 2018-11-19 15:04:41 +01:00 committed by Patrick Georgi
parent 9c71596493
commit d3799d3326
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/drivers/intel/fsp1_1/bootblock.c
View File

@ -2,6 +2,7 @@
* This file is part of the coreboot project. * This file is part of the coreboot project.
* *
* Copyright (C) 2016 Intel Corporation. * Copyright (C) 2016 Intel Corporation.
* Copryight (C) 2018 Eltan B.V.
* *
* This program is free software; you can redistribute it and/or modify * This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by * it under the terms of the GNU General Public License as published by
@ -51,8 +52,8 @@ void bootblock_fsp_temp_ram_init(void)
fsp_temp_ram_init = (FSP_TEMP_RAM_INIT)(fih->ImageBase fsp_temp_ram_init = (FSP_TEMP_RAM_INIT)(fih->ImageBase
+ fih->TempRamInitEntryOffset); + fih->TempRamInitEntryOffset);
status = fsp_temp_ram_init(&temp_ram_init_params); status = fsp_temp_ram_init(&temp_ram_init_params);
printk(BIOS_DEBUG, "FspTempRamInit returned 0x%08x\n", status);
if (status != FSP_SUCCESS) if (status != FSP_SUCCESS)
die("FspTempRamInit failed. Giving up."); die("FspTempRamInit failed. Giving up.");
printk(BIOS_DEBUG, "FspTempRamInit returned 0x%08x\n", status);
} }