From d39175410848fcdd6e1b3ada3b8ce05ed2ec3a8f Mon Sep 17 00:00:00 2001 From: Seunghwan Kim Date: Thu, 19 Jul 2018 14:49:16 +0900 Subject: [PATCH] mb/google/poppy/variants/nautilus: Add internal pull-up for USB2_OC2# Nautilus-WiFi board doesn't have external pull-up on USB2_OC2# route,then abnormal over-current is asserted on USB type-A port. It causes USB type-A port to be blocked, so we need this internal pull-up. BUG=b:111578984 BRANCH=poppy TEST=Verified over-current not triggered abnormally on basic sku board Change-Id: I159f686cef9c8d254f390d7f1dff8011f43fc066 Signed-off-by: Seunghwan Kim Reviewed-on: https://review.coreboot.org/27542 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh --- src/mainboard/google/poppy/variants/nautilus/gpio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mainboard/google/poppy/variants/nautilus/gpio.c b/src/mainboard/google/poppy/variants/nautilus/gpio.c index b49665192e..8b129d1920 100644 --- a/src/mainboard/google/poppy/variants/nautilus/gpio.c +++ b/src/mainboard/google/poppy/variants/nautilus/gpio.c @@ -224,8 +224,6 @@ static const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), /* E10 : USB2_OC1# ==> USB3_C0_OC0_L */ PAD_CFG_NF(GPP_E10, NONE, DEEP, NF1), - /* E11 : USB2_OC2# ==> USB2_P2_FAULT# */ - PAD_CFG_NF(GPP_E11, NONE, DEEP, NF1), /* E12 : USB2_OC3# ==> NC */ PAD_CFG_NC(GPP_E12), /* E13 : DDPB_HPD0 ==> KBC3_USB_C0_DP_HPD */ @@ -385,6 +383,8 @@ static const struct pad_config nautilus_default_sku_gpio_table[] = { PAD_CFG_NC(GPP_D16), /* D21 : SPI1_IO2 ==> NC */ PAD_CFG_NC(GPP_D21), + /* E11 : USB2_OC2# ==> USB2_P2_FAULT# */ + PAD_CFG_NF(GPP_E11, 5K_PU, DEEP, NF1), }; static const struct pad_config lte_sku_gpio_table[] = { @@ -396,6 +396,8 @@ static const struct pad_config lte_sku_gpio_table[] = { PAD_CFG_GPO(GPP_D16, 1, DEEP), /* D21 : SPI1_IO2 ==> LTE3_BODY_SAR */ PAD_CFG_GPO(GPP_D21, 0, DEEP), + /* E11 : USB2_OC2# ==> USB2_P2_FAULT# */ + PAD_CFG_NF(GPP_E11, NONE, DEEP, NF1), }; const struct pad_config *variant_sku_gpio_table(size_t *num)