From d3b85223fdac1f9197c645f81d624d6a1f47b0bb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Niew=C3=B6hner?= Date: Sun, 13 Mar 2022 20:08:55 +0100 Subject: [PATCH] soc/intel/tgl: move DIMM_SPD_SIZE from mb to SoC Kconfig MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit All TGL mainboards are setting DIMM_SPD_SIZE to 512. Thus, default to 512 in the SoC Kconfig and drop it from the mainboard Kconfigs. Change-Id: I9fd947b61c984e10bd5fba20b73280b08623a008 Signed-off-by: Michael Niewöhner Reviewed-on: https://review.coreboot.org/c/coreboot/+/62766 Reviewed-by: Felix Singer Reviewed-by: Tim Crawford Reviewed-by: Tim Wawrzynczak Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- src/mainboard/google/deltaur/Kconfig | 3 --- src/mainboard/google/volteer/Kconfig | 3 --- src/mainboard/intel/tglrvp/Kconfig | 3 --- src/mainboard/starlabs/labtop/Kconfig | 3 --- src/mainboard/system76/darp7/Kconfig | 3 --- src/mainboard/system76/galp5/Kconfig | 3 --- src/mainboard/system76/gaze16/Kconfig | 3 --- src/mainboard/system76/lemp10/Kconfig | 3 --- src/mainboard/system76/oryp8/Kconfig | 3 --- src/soc/intel/tigerlake/Kconfig | 3 +++ 10 files changed, 3 insertions(+), 27 deletions(-) diff --git a/src/mainboard/google/deltaur/Kconfig b/src/mainboard/google/deltaur/Kconfig index 492bcbb698..eb2779632d 100644 --- a/src/mainboard/google/deltaur/Kconfig +++ b/src/mainboard/google/deltaur/Kconfig @@ -36,9 +36,6 @@ config CHROMEOS select GBB_FLAG_FORCE_DEV_BOOT_USB select GBB_FLAG_FORCE_DEV_SWITCH_ON -config DIMM_SPD_SIZE - default 512 - config DEVICETREE default "variants/baseboard/devicetree.cb" diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index eb8f17653a..4f83d1cd82 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -144,9 +144,6 @@ config CHROMEOS_WIFI_SAR select SAR_ENABLE select USE_SAR -config DIMM_SPD_SIZE - default 512 - config DEVICETREE default "variants/baseboard/devicetree.cb" diff --git a/src/mainboard/intel/tglrvp/Kconfig b/src/mainboard/intel/tglrvp/Kconfig index 9e63f2c09e..8a4c9adfcf 100644 --- a/src/mainboard/intel/tglrvp/Kconfig +++ b/src/mainboard/intel/tglrvp/Kconfig @@ -60,9 +60,6 @@ config MAINBOARD_FAMILY config DEVICETREE default "variants/\$(CONFIG_VARIANT_DIR)/devicetree.cb" -config DIMM_SPD_SIZE - default 512 - choice prompt "ON BOARD EC" default TGL_CHROME_EC diff --git a/src/mainboard/starlabs/labtop/Kconfig b/src/mainboard/starlabs/labtop/Kconfig index 0f7d108ac0..f8a5bc7de6 100644 --- a/src/mainboard/starlabs/labtop/Kconfig +++ b/src/mainboard/starlabs/labtop/Kconfig @@ -46,9 +46,6 @@ if BOARD_STARLABS_LABTOP_SERIES config DEVICETREE default "variants/\$(CONFIG_VARIANT_DIR)/devicetree.cb" -config DIMM_SPD_SIZE - default 512 - config DRIVER_TPM_SPI_CHIP default 2 diff --git a/src/mainboard/system76/darp7/Kconfig b/src/mainboard/system76/darp7/Kconfig index 75d8e1ddd6..960e5aebcc 100644 --- a/src/mainboard/system76/darp7/Kconfig +++ b/src/mainboard/system76/darp7/Kconfig @@ -44,9 +44,6 @@ config CBFS_SIZE config CONSOLE_POST default y -config DIMM_SPD_SIZE - default 512 - config POST_DEVICE default n diff --git a/src/mainboard/system76/galp5/Kconfig b/src/mainboard/system76/galp5/Kconfig index bb4b2eaaa2..98e32f7b5f 100644 --- a/src/mainboard/system76/galp5/Kconfig +++ b/src/mainboard/system76/galp5/Kconfig @@ -43,9 +43,6 @@ config CBFS_SIZE config CONSOLE_POST default y -config DIMM_SPD_SIZE - default 512 - config ONBOARD_VGA_IS_PRIMARY default y diff --git a/src/mainboard/system76/gaze16/Kconfig b/src/mainboard/system76/gaze16/Kconfig index daf3302a81..cc96d5fed7 100644 --- a/src/mainboard/system76/gaze16/Kconfig +++ b/src/mainboard/system76/gaze16/Kconfig @@ -55,9 +55,6 @@ config CBFS_SIZE config CONSOLE_POST default y -config DIMM_SPD_SIZE - default 512 - config ONBOARD_VGA_IS_PRIMARY default y diff --git a/src/mainboard/system76/lemp10/Kconfig b/src/mainboard/system76/lemp10/Kconfig index fc8abbac3b..a73242579a 100644 --- a/src/mainboard/system76/lemp10/Kconfig +++ b/src/mainboard/system76/lemp10/Kconfig @@ -44,9 +44,6 @@ config CBFS_SIZE config CONSOLE_POST default y -config DIMM_SPD_SIZE - default 512 - config POST_DEVICE default n diff --git a/src/mainboard/system76/oryp8/Kconfig b/src/mainboard/system76/oryp8/Kconfig index 958cda82ec..8e65b70ad0 100644 --- a/src/mainboard/system76/oryp8/Kconfig +++ b/src/mainboard/system76/oryp8/Kconfig @@ -49,9 +49,6 @@ config CONSOLE_POST config DIMM_MAX default 4 -config DIMM_SPD_SIZE - default 512 - config ONBOARD_VGA_IS_PRIMARY default y diff --git a/src/soc/intel/tigerlake/Kconfig b/src/soc/intel/tigerlake/Kconfig index 6d201127d6..2b673cab5c 100644 --- a/src/soc/intel/tigerlake/Kconfig +++ b/src/soc/intel/tigerlake/Kconfig @@ -94,6 +94,9 @@ config MAX_CPUS default 16 if SOC_INTEL_TIGERLAKE_PCH_H default 8 +config DIMM_SPD_SIZE + default 512 + config DCACHE_RAM_BASE default 0xfef00000