GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/lenovo/*: Remove useless smihandler code 

This code to handle the brightness from SMM is copied from the Lenovo
Thinkpad X60 code, but does not work on later generation. The PCI
device it tries to address does not even exist on those devices.

Change-Id: Ia959eb5b747846048396e66d4c926c96c27f3878
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33138
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Arthur Heymans 2019-05-28 09:47:38 +02:00 committed by Nico Huber
parent 60a0a3d629
commit d44d4f0f4e
5 changed files with 0 additions and 150 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/mainboard/lenovo/t420s/smihandler.c
View File

@ -27,23 +27,6 @@
#define GPE_EC_SCI 1 #define GPE_EC_SCI 1
#define GPE_EC_WAKE 13 #define GPE_EC_WAKE 13
static void mainboard_smi_brightness_up(void)
{
u8 value;
if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0)
pci_write_config8(PCI_DEV(0, 2, 1), 0xf4, (value + 0x10) | 0xf);
}
static void mainboard_smi_brightness_down(void)
{
u8 value;
if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10)
pci_write_config8(PCI_DEV(0, 2, 1), 0xf4,
(value - 0x10) & 0xf0);
}
static void mainboard_smi_handle_ec_sci(void) static void mainboard_smi_handle_ec_sci(void)
{ {
u8 status = inb(EC_SC); u8 status = inb(EC_SC);
@ -54,19 +37,6 @@ static void mainboard_smi_handle_ec_sci(void)
event = ec_query(); event = ec_query();
printk(BIOS_DEBUG, "EC event %02x\n", event); printk(BIOS_DEBUG, "EC event %02x\n", event);
switch (event) {
case 0x14:
/* brightness up */
mainboard_smi_brightness_up();
break;
case 0x15:
/* brightness down */
mainboard_smi_brightness_down();
break;
default:
break;
}
} }
void mainboard_smi_gpi(u32 gpi_sts) void mainboard_smi_gpi(u32 gpi_sts)

30
src/mainboard/lenovo/t430s/smihandler.c
View File

@ -27,23 +27,6 @@
#define GPE_EC_SCI 1 #define GPE_EC_SCI 1
#define GPE_EC_WAKE 13 #define GPE_EC_WAKE 13
static void mainboard_smi_brightness_up(void)
{
u8 value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4);
if (value < 0xf0)
pci_write_config8(PCI_DEV(0, 2, 1), 0xf4, (value + 0x10) | 0xf);
}
static void mainboard_smi_brightness_down(void)
{
u8 value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4);
if (value > 0x10)
pci_write_config8(PCI_DEV(0, 2, 1), 0xf4,
(value - 0x10) & 0xf0);
}
static void mainboard_smi_handle_ec_sci(void) static void mainboard_smi_handle_ec_sci(void)
{ {
u8 status = inb(EC_SC); u8 status = inb(EC_SC);
@ -54,19 +37,6 @@ static void mainboard_smi_handle_ec_sci(void)
event = ec_query(); event = ec_query();
printk(BIOS_DEBUG, "EC event %02x\n", event); printk(BIOS_DEBUG, "EC event %02x\n", event);
switch (event) {
case 0x14:
/* brightness up */
mainboard_smi_brightness_up();
break;
case 0x15:
/* brightness down */
mainboard_smi_brightness_down();
break;
default:
break;
}
} }
void mainboard_smi_gpi(u32 gpi_sts) void mainboard_smi_gpi(u32 gpi_sts)

30
src/mainboard/lenovo/t520/smihandler.c
View File

@ -27,23 +27,6 @@
#define GPE_EC_SCI 1 #define GPE_EC_SCI 1
#define GPE_EC_WAKE 13 #define GPE_EC_WAKE 13
static void mainboard_smi_brightness_up(void)
{
u8 value;
if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0)
pci_write_config8(PCI_DEV(0, 2, 1), 0xf4, (value + 0x10) | 0xf);
}
static void mainboard_smi_brightness_down(void)
{
u8 value;
if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10)
pci_write_config8(PCI_DEV(0, 2, 1), 0xf4,
(value - 0x10) & 0xf0);
}
static void mainboard_smi_handle_ec_sci(void) static void mainboard_smi_handle_ec_sci(void)
{ {
u8 status = inb(EC_SC); u8 status = inb(EC_SC);
@ -54,19 +37,6 @@ static void mainboard_smi_handle_ec_sci(void)
event = ec_query(); event = ec_query();
printk(BIOS_DEBUG, "EC event %02x\n", event); printk(BIOS_DEBUG, "EC event %02x\n", event);
switch (event) {
case 0x14:
/* brightness up */
mainboard_smi_brightness_up();
break;
case 0x15:
/* brightness down */
mainboard_smi_brightness_down();
break;
default:
break;
}
} }
void mainboard_smi_gpi(u32 gpi_sts) void mainboard_smi_gpi(u32 gpi_sts)

30
src/mainboard/lenovo/t530/smihandler.c
View File

@ -27,23 +27,6 @@
#define GPE_EC_SCI 1 #define GPE_EC_SCI 1
#define GPE_EC_WAKE 13 #define GPE_EC_WAKE 13
static void mainboard_smi_brightness_up(void)
{
u8 value;
if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0)
pci_write_config8(PCI_DEV(0, 2, 1), 0xf4, (value + 0x10) | 0xf);
}
static void mainboard_smi_brightness_down(void)
{
u8 value;
if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10)
pci_write_config8(PCI_DEV(0, 2, 1), 0xf4,
(value - 0x10) & 0xf0);
}
static void mainboard_smi_handle_ec_sci(void) static void mainboard_smi_handle_ec_sci(void)
{ {
u8 status = inb(EC_SC); u8 status = inb(EC_SC);
@ -54,19 +37,6 @@ static void mainboard_smi_handle_ec_sci(void)
event = ec_query(); event = ec_query();
printk(BIOS_DEBUG, "EC event %02x\n", event); printk(BIOS_DEBUG, "EC event %02x\n", event);
switch (event) {
case 0x14:
/* brightness up */
mainboard_smi_brightness_up();
break;
case 0x15:
/* brightness down */
mainboard_smi_brightness_down();
break;
default:
break;
}
} }
void mainboard_smi_gpi(u32 gpi_sts) void mainboard_smi_gpi(u32 gpi_sts)

30
src/mainboard/lenovo/x220/smihandler.c
View File

@ -27,23 +27,6 @@
#define GPE_EC_SCI 1 #define GPE_EC_SCI 1
#define GPE_EC_WAKE 13 #define GPE_EC_WAKE 13
static void mainboard_smi_brightness_up(void)
{
u8 value;
if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) < 0xf0)
pci_write_config8(PCI_DEV(0, 2, 1), 0xf4, (value + 0x10) | 0xf);
}
static void mainboard_smi_brightness_down(void)
{
u8 value;
if ((value = pci_read_config8(PCI_DEV(0, 2, 1), 0xf4)) > 0x10)
pci_write_config8(PCI_DEV(0, 2, 1), 0xf4,
(value - 0x10) & 0xf0);
}
static void mainboard_smi_handle_ec_sci(void) static void mainboard_smi_handle_ec_sci(void)
{ {
u8 status = inb(EC_SC); u8 status = inb(EC_SC);
@ -54,19 +37,6 @@ static void mainboard_smi_handle_ec_sci(void)
event = ec_query(); event = ec_query();
printk(BIOS_DEBUG, "EC event %02x\n", event); printk(BIOS_DEBUG, "EC event %02x\n", event);
switch (event) {
case 0x14:
/* brightness up */
mainboard_smi_brightness_up();
break;
case 0x15:
/* brightness down */
mainboard_smi_brightness_down();
break;
default:
break;
}
} }
void mainboard_smi_gpi(u32 gpi_sts) void mainboard_smi_gpi(u32 gpi_sts)