From d45011c9c63afb6f4b25b8ae92d7b74cc873b15c Mon Sep 17 00:00:00 2001 From: "John E. Kabat Jr" Date: Fri, 29 Sep 2017 11:23:35 -0600 Subject: [PATCH] drivers/elog: Fix debug build errors Add hexdump.c to Makefile.inc and change an elog_debug format to use %z for size_t arguments. This corrects build errors when ELOG_DEBUG is used. Change-Id: I3d5547eed8ada7c4bdcbbb8bb9d6965ade73beda Signed-off-by: John E. Kabat Jr Reviewed-on: https://review.coreboot.org/21769 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- src/drivers/elog/elog.c | 4 ++-- src/lib/Makefile.inc | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c index 1c175614c5..c8f221ac0b 100644 --- a/src/drivers/elog/elog.c +++ b/src/drivers/elog/elog.c @@ -324,8 +324,8 @@ static void elog_nv_write(size_t offset, size_t size) address = rdev_mmap(rdev, offset, size); - elog_debug("%s(address=0x%p offset=0x%08x size=%u)\n", __func__, - address, offset, size); + elog_debug("%s(address=0x%p offset=0x%08zx size=%zu)\n", __func__, + address, offset, size); if (address == NULL) return; diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc index 778bea8165..dfb23b625b 100644 --- a/src/lib/Makefile.inc +++ b/src/lib/Makefile.inc @@ -165,6 +165,7 @@ bootblock-y += hexdump.c ramstage-y += hexdump.c romstage-y += hexdump.c verstage-y += hexdump.c +smm-y += hexdump.c bootblock-$(CONFIG_REG_SCRIPT) += reg_script.c verstage-$(CONFIG_REG_SCRIPT) += reg_script.c