GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/intel/sandybridge: Refactor ODT stretch table code 

Leverage existing `ch_dimms` value and use constants for brevity.

Change-Id: I4e08166c8e9fbd15ff1dcd266abb0689e4b159f7
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/48613
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Angel Pons 2020-12-12 17:45:14 +01:00 committed by Felix Held
parent 323c0aeb64
commit d4d3ba0414
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/northbridge/intel/sandybridge/raminit.c
View File

@ -233,10 +233,11 @@ static void dram_find_spds_ddr3(spd_raw_data *spd, ramctr_timing *ctrl)
printk(BIOS_DEBUG, "channel[%d] rankmap = 0x%x\n", channel, printk(BIOS_DEBUG, "channel[%d] rankmap = 0x%x\n", channel,
ctrl->rankmap[channel]); ctrl->rankmap[channel]);
} }
if ((ctrl->rankmap[channel] & 0x03) && (ctrl->rankmap[channel] & 0x0c)
&& ctrl->info.dimm[channel][0].reference_card <= 5
&& ctrl->info.dimm[channel][1].reference_card <= 5) {
const u8 rc_0 = ctrl->info.dimm[channel][0].reference_card;
const u8 rc_1 = ctrl->info.dimm[channel][1].reference_card;
if (ch_dimms == NUM_SLOTS && rc_0 < 6 && rc_1 < 6) {
const int ref_card_offset_table[6][6] = { const int ref_card_offset_table[6][6] = {
{ 0, 0, 0, 0, 2, 2 }, { 0, 0, 0, 0, 2, 2 },
{ 0, 0, 0, 0, 2, 2 }, { 0, 0, 0, 0, 2, 2 },
@ -245,9 +246,7 @@ static void dram_find_spds_ddr3(spd_raw_data *spd, ramctr_timing *ctrl)
{ 2, 2, 2, 1, 0, 0 }, { 2, 2, 2, 1, 0, 0 },
{ 2, 2, 2, 1, 0, 0 }, { 2, 2, 2, 1, 0, 0 },
}; };
ctrl->ref_card_offset[channel] = ref_card_offset_table ctrl->ref_card_offset[channel] = ref_card_offset_table[rc_0][rc_1];
[ctrl->info.dimm[channel][0].reference_card]
[ctrl->info.dimm[channel][1].reference_card];
} else { } else {
ctrl->ref_card_offset[channel] = 0; ctrl->ref_card_offset[channel] = 0;
} }