Various PIRQ/MPTABLE/ACPI Kconfig fixes.

- Use HAVE_ACPI_TABLES, HAVE_MP_TABLE, and HAVE_PIRQ_TABLE (instead of
   GENERATE_*) in the board's Kconfig file, as all other boards do.

 - Add missing HAVE_ACPI_TABLES/HAVE_MP_TABLE/HAVE_PIRQ_TABLE to boards
   which have the respective files. The only exception: EPIA-M700 doesn't
   select ACPI, as it doesn't have dsdt.asl. Added a comment that the user
   is supposed to run the 'get_dsdt' script and edit Kconfig afterwards.

 - Fix minor warning/error in
   src/mainboard/msi/ms9652_fam10/acpi_tables.c,
   now that the file is actually used.

 - msi/ms9652_fam10: use #include instead of Include() as we usually do
   now.

Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
Acked-by: Patrick Georgi <patrick@georgi-clan.de>


git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6027 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Uwe Hermann 2010-11-05 16:17:46 +00:00 committed by Patrick Georgi
parent adc975098d
commit d51122df4e
19 changed files with 48 additions and 41 deletions

View File

@ -10,9 +10,9 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select SOUTHBRIDGE_AMD_SB600 select SOUTHBRIDGE_AMD_SB600
select SUPERIO_ITE_IT8712F select SUPERIO_ITE_IT8712F
select BOARD_HAS_FADT select BOARD_HAS_FADT
select GENERATE_ACPI_TABLES select HAVE_ACPI_TABLES
select GENERATE_MP_TABLE select HAVE_MP_TABLE
select GENERATE_PIRQ_TABLE select HAVE_PIRQ_TABLE
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select HAVE_MAINBOARD_RESOURCES select HAVE_MAINBOARD_RESOURCES
select HAVE_BUS_CONFIG select HAVE_BUS_CONFIG

View File

@ -11,9 +11,9 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select SOUTHBRIDGE_AMD_SB700 select SOUTHBRIDGE_AMD_SB700
select SUPERIO_ITE_IT8718F select SUPERIO_ITE_IT8718F
select BOARD_HAS_FADT select BOARD_HAS_FADT
select GENERATE_ACPI_TABLES select HAVE_ACPI_TABLES
select GENERATE_MP_TABLE select HAVE_MP_TABLE
select GENERATE_PIRQ_TABLE select HAVE_PIRQ_TABLE
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select HAVE_MAINBOARD_RESOURCES select HAVE_MAINBOARD_RESOURCES
select HAVE_BUS_CONFIG select HAVE_BUS_CONFIG

View File

@ -13,8 +13,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_HAS_FADT select BOARD_HAS_FADT
select HAVE_BUS_CONFIG select HAVE_BUS_CONFIG
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select GENERATE_PIRQ_TABLE select HAVE_PIRQ_TABLE
select GENERATE_MP_TABLE select HAVE_MP_TABLE
select HAVE_MAINBOARD_RESOURCES select HAVE_MAINBOARD_RESOURCES
select CACHE_AS_RAM select CACHE_AS_RAM
select HAVE_HARD_RESET select HAVE_HARD_RESET
@ -22,7 +22,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select LIFT_BSP_APIC_ID select LIFT_BSP_APIC_ID
select SERIAL_CPU_INIT select SERIAL_CPU_INIT
select AMDMCT select AMDMCT
select GENERATE_ACPI_TABLES select HAVE_ACPI_TABLES
select BOARD_ROMSIZE_KB_1024 select BOARD_ROMSIZE_KB_1024
select RAMINIT_SYSINFO select RAMINIT_SYSINFO
select ENABLE_APIC_EXT_ID select ENABLE_APIC_EXT_ID

View File

@ -13,8 +13,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_HAS_FADT select BOARD_HAS_FADT
select HAVE_BUS_CONFIG select HAVE_BUS_CONFIG
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select GENERATE_PIRQ_TABLE select HAVE_PIRQ_TABLE
select GENERATE_MP_TABLE select HAVE_MP_TABLE
select HAVE_MAINBOARD_RESOURCES select HAVE_MAINBOARD_RESOURCES
select CACHE_AS_RAM select CACHE_AS_RAM
select HAVE_HARD_RESET select HAVE_HARD_RESET
@ -22,7 +22,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select LIFT_BSP_APIC_ID select LIFT_BSP_APIC_ID
select SERIAL_CPU_INIT select SERIAL_CPU_INIT
select AMDMCT select AMDMCT
select GENERATE_ACPI_TABLES select HAVE_ACPI_TABLES
select BOARD_ROMSIZE_KB_1024 select BOARD_ROMSIZE_KB_1024
select RAMINIT_SYSINFO select RAMINIT_SYSINFO
select ENABLE_APIC_EXT_ID select ENABLE_APIC_EXT_ID

View File

@ -11,9 +11,9 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select SOUTHBRIDGE_AMD_SB700 select SOUTHBRIDGE_AMD_SB700
select SUPERIO_WINBOND_W83627DHG select SUPERIO_WINBOND_W83627DHG
select BOARD_HAS_FADT select BOARD_HAS_FADT
select GENERATE_ACPI_TABLES select HAVE_ACPI_TABLES
select GENERATE_MP_TABLE select HAVE_MP_TABLE
select GENERATE_PIRQ_TABLE select HAVE_PIRQ_TABLE
select HAVE_MAINBOARD_RESOURCES select HAVE_MAINBOARD_RESOURCES
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select HAVE_BUS_CONFIG select HAVE_BUS_CONFIG

View File

@ -13,15 +13,15 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_HAS_FADT select BOARD_HAS_FADT
select HAVE_BUS_CONFIG select HAVE_BUS_CONFIG
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select GENERATE_PIRQ_TABLE select HAVE_PIRQ_TABLE
select GENERATE_MP_TABLE select HAVE_MP_TABLE
select CACHE_AS_RAM select CACHE_AS_RAM
select HAVE_HARD_RESET select HAVE_HARD_RESET
select SB_HT_CHAIN_UNITID_OFFSET_ONLY select SB_HT_CHAIN_UNITID_OFFSET_ONLY
select LIFT_BSP_APIC_ID select LIFT_BSP_APIC_ID
select SERIAL_CPU_INIT select SERIAL_CPU_INIT
select AMDMCT select AMDMCT
select GENERATE_ACPI_TABLES select HAVE_ACPI_TABLES
select BOARD_ROMSIZE_KB_1024 select BOARD_ROMSIZE_KB_1024
select RAMINIT_SYSINFO select RAMINIT_SYSINFO
select ENABLE_APIC_EXT_ID select ENABLE_APIC_EXT_ID

View File

@ -29,9 +29,9 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select SUPERIO_SMSC_FDC37N972 select SUPERIO_SMSC_FDC37N972
select SUPERIO_SMSC_SIO10N268 select SUPERIO_SMSC_SIO10N268
select BOARD_HAS_FADT select BOARD_HAS_FADT
select GENERATE_ACPI_TABLES select HAVE_ACPI_TABLES
select GENERATE_PIRQ_TABLE select HAVE_PIRQ_TABLE
select GENERATE_MP_TABLE select HAVE_MP_TABLE
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select HAVE_ACPI_RESUME select HAVE_ACPI_RESUME
select HAVE_ACPI_SLIC select HAVE_ACPI_SLIC

View File

@ -12,6 +12,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select HAVE_BUS_CONFIG select HAVE_BUS_CONFIG
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select HAVE_PIRQ_TABLE select HAVE_PIRQ_TABLE
select HAVE_MP_TABLE
select CACHE_AS_RAM select CACHE_AS_RAM
select HAVE_HARD_RESET select HAVE_HARD_RESET
select LIFT_BSP_APIC_ID select LIFT_BSP_APIC_ID

View File

@ -13,8 +13,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_HAS_FADT select BOARD_HAS_FADT
select HAVE_BUS_CONFIG select HAVE_BUS_CONFIG
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select GENERATE_PIRQ_TABLE select HAVE_PIRQ_TABLE
select GENERATE_MP_TABLE select HAVE_MP_TABLE
select HAVE_MAINBOARD_RESOURCES select HAVE_MAINBOARD_RESOURCES
select CACHE_AS_RAM select CACHE_AS_RAM
select HAVE_HARD_RESET select HAVE_HARD_RESET
@ -22,7 +22,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select LIFT_BSP_APIC_ID select LIFT_BSP_APIC_ID
select SERIAL_CPU_INIT select SERIAL_CPU_INIT
select AMDMCT select AMDMCT
select GENERATE_ACPI_TABLES select HAVE_ACPI_TABLES
select BOARD_ROMSIZE_KB_1024 select BOARD_ROMSIZE_KB_1024
select ENABLE_APIC_EXT_ID select ENABLE_APIC_EXT_ID
select TINY_BOOTBLOCK select TINY_BOOTBLOCK

View File

@ -13,8 +13,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_HAS_FADT select BOARD_HAS_FADT
select HAVE_BUS_CONFIG select HAVE_BUS_CONFIG
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select GENERATE_PIRQ_TABLE select HAVE_PIRQ_TABLE
select GENERATE_MP_TABLE select HAVE_MP_TABLE
select HAVE_MAINBOARD_RESOURCES select HAVE_MAINBOARD_RESOURCES
select CACHE_AS_RAM select CACHE_AS_RAM
select HAVE_HARD_RESET select HAVE_HARD_RESET
@ -22,7 +22,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select LIFT_BSP_APIC_ID select LIFT_BSP_APIC_ID
select SERIAL_CPU_INIT select SERIAL_CPU_INIT
select AMDMCT select AMDMCT
select GENERATE_ACPI_TABLES select HAVE_ACPI_TABLES
select BOARD_ROMSIZE_KB_1024 select BOARD_ROMSIZE_KB_1024
select ENABLE_APIC_EXT_ID select ENABLE_APIC_EXT_ID
select TINY_BOOTBLOCK select TINY_BOOTBLOCK

View File

@ -9,9 +9,9 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select SOUTHBRIDGE_INTEL_I82801GX select SOUTHBRIDGE_INTEL_I82801GX
select SUPERIO_WINBOND_W83627EHG select SUPERIO_WINBOND_W83627EHG
select BOARD_HAS_FADT select BOARD_HAS_FADT
select GENERATE_ACPI_TABLES select HAVE_ACPI_TABLES
select GENERATE_PIRQ_TABLE select HAVE_PIRQ_TABLE
select GENERATE_MP_TABLE select HAVE_MP_TABLE
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select HAVE_ACPI_RESUME select HAVE_ACPI_RESUME
select MMCONF_SUPPORT select MMCONF_SUPPORT

View File

@ -27,6 +27,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select SUPERIO_WINBOND_W83977F select SUPERIO_WINBOND_W83977F
select ROMCC select ROMCC
select PIRQ_ROUTE select PIRQ_ROUTE
select HAVE_PIRQ_TABLE
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select BOARD_ROMSIZE_KB_256 select BOARD_ROMSIZE_KB_256

View File

@ -13,8 +13,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_HAS_FADT select BOARD_HAS_FADT
select HAVE_BUS_CONFIG select HAVE_BUS_CONFIG
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select GENERATE_PIRQ_TABLE select HAVE_PIRQ_TABLE
select GENERATE_MP_TABLE select HAVE_MP_TABLE
select HAVE_MAINBOARD_RESOURCES select HAVE_MAINBOARD_RESOURCES
select CACHE_AS_RAM select CACHE_AS_RAM
select HAVE_HARD_RESET select HAVE_HARD_RESET
@ -22,7 +22,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select LIFT_BSP_APIC_ID select LIFT_BSP_APIC_ID
select SERIAL_CPU_INIT select SERIAL_CPU_INIT
select AMDMCT select AMDMCT
select GENERATE_ACPI_TABLES select HAVE_ACPI_TABLES
select BOARD_ROMSIZE_KB_1024 select BOARD_ROMSIZE_KB_1024
select RAMINIT_SYSINFO select RAMINIT_SYSINFO
select ENABLE_APIC_EXT_ID select ENABLE_APIC_EXT_ID

View File

@ -13,8 +13,8 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select BOARD_HAS_FADT select BOARD_HAS_FADT
select HAVE_BUS_CONFIG select HAVE_BUS_CONFIG
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select GENERATE_PIRQ_TABLE select HAVE_PIRQ_TABLE
select GENERATE_MP_TABLE select HAVE_MP_TABLE
select HAVE_MAINBOARD_RESOURCES select HAVE_MAINBOARD_RESOURCES
select CACHE_AS_RAM select CACHE_AS_RAM
select HAVE_HARD_RESET select HAVE_HARD_RESET
@ -22,7 +22,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select LIFT_BSP_APIC_ID select LIFT_BSP_APIC_ID
select SERIAL_CPU_INIT select SERIAL_CPU_INIT
select AMDMCT select AMDMCT
select GENERATE_ACPI_TABLES select HAVE_ACPI_TABLES
select BOARD_ROMSIZE_KB_1024 select BOARD_ROMSIZE_KB_1024
select RAMINIT_SYSINFO select RAMINIT_SYSINFO
select ENABLE_APIC_EXT_ID select ENABLE_APIC_EXT_ID

View File

@ -9,9 +9,9 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select SOUTHBRIDGE_INTEL_I82801GX select SOUTHBRIDGE_INTEL_I82801GX
select SUPERIO_WINBOND_W83627THG select SUPERIO_WINBOND_W83627THG
select BOARD_HAS_FADT select BOARD_HAS_FADT
select GENERATE_ACPI_TABLES select HAVE_ACPI_TABLES
select GENERATE_PIRQ_TABLE select HAVE_PIRQ_TABLE
select GENERATE_MP_TABLE select HAVE_MP_TABLE
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select HAVE_ACPI_RESUME select HAVE_ACPI_RESUME
select MMCONF_SUPPORT select MMCONF_SUPPORT

View File

@ -14,6 +14,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select HAVE_BUS_CONFIG select HAVE_BUS_CONFIG
select HAVE_PIRQ_TABLE select HAVE_PIRQ_TABLE
select HAVE_MP_TABLE select HAVE_MP_TABLE
select HAVE_ACPI_TABLES
select CACHE_AS_RAM select CACHE_AS_RAM
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select HAVE_HARD_RESET select HAVE_HARD_RESET

View File

@ -151,7 +151,7 @@ unsigned long write_acpi_tables(unsigned long start)
current += dsdt->length; current += dsdt->length;
memcpy(dsdt, &AmlCode, dsdt->length); memcpy(dsdt, &AmlCode, dsdt->length);
dsdt->checksum = 0; /* Don't trust iasl to get this right. */ dsdt->checksum = 0; /* Don't trust iasl to get this right. */
dsdt->checksum = acpi_checksum(dsdt, dsdt->length); dsdt->checksum = acpi_checksum((u8 *)dsdt, dsdt->length);
printk(BIOS_DEBUG, "ACPI: * DSDT @ %p Length %x\n", dsdt, printk(BIOS_DEBUG, "ACPI: * DSDT @ %p Length %x\n", dsdt,
dsdt->length); dsdt->length);
printk(BIOS_DEBUG, "ACPI: * FADT\n"); printk(BIOS_DEBUG, "ACPI: * FADT\n");

View File

@ -23,7 +23,7 @@
DefinitionBlock ("DSDT.aml", "DSDT", 1, "LXBIOS", "LXB-DSDT", 1) DefinitionBlock ("DSDT.aml", "DSDT", 1, "LXBIOS", "LXB-DSDT", 1)
{ {
Include ("../../../../src/northbridge/amd/amdk8/amdk8_util.asl") #include "../../../../src/northbridge/amd/amdk8/amdk8_util.asl"
/* For now only define 2 power states: /* For now only define 2 power states:
* - S0 which is fully on * - S0 which is fully on

View File

@ -7,6 +7,10 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select NORTHBRIDGE_VIA_VX800 select NORTHBRIDGE_VIA_VX800
select SUPERIO_WINBOND_W83697HF select SUPERIO_WINBOND_W83697HF
select BOARD_HAS_FADT select BOARD_HAS_FADT
select HAVE_PIRQ_TABLE
# Note: For ACPI, you need to use the 'get_dsdt' script and uncomment
# the "select HAVE_ACPI_TABLES" line below.
# select HAVE_ACPI_TABLES
select HAVE_OPTION_TABLE select HAVE_OPTION_TABLE
select BOARD_ROMSIZE_KB_512 select BOARD_ROMSIZE_KB_512
select RAMINIT_SYSINFO select RAMINIT_SYSINFO