GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/skyrim: Move I2C config to devicetree 

The I2C config was unnecessarily placed in the overridetree.  As we
prepare for fanout, this is going to cause unnecessary noisy changes.
Move the I2C config to the devicetree to avoid this.

BUG=None
TEST=Build

Change-Id: I09ad5c911a0fd00274761cb71e9b659b47cd6da1
Signed-off-by: Jon Murphy <jpmurphy@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/66802
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Jon Murphy 2022-08-16 11:31:03 -06:00 committed by Felix Held
parent 5f7cfb388e
commit d540d7c19d
3 changed files with 26 additions and 53 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/mainboard/google/skyrim/variants/baseboard/devicetree.cb
View File

@ -47,6 +47,32 @@ chip soc/amd/mendocino
register "i2c_pad[2].rx_level" = "I2C_PAD_RX_1_8V" # Audio/SAR register "i2c_pad[2].rx_level" = "I2C_PAD_RX_1_8V" # Audio/SAR
register "i2c_pad[3].rx_level" = "I2C_PAD_RX_1_8V" # GSC register "i2c_pad[3].rx_level" = "I2C_PAD_RX_1_8V" # GSC
# I2C Config
#+-------------------+----------------------------+
#| Field | Value |
#+-------------------+----------------------------+
#| I2C0 | Trackpad |
#| I2C1 | Touchscreen |
#| I2C2 | Speaker, Codec, P-SAR, USB |
#| I2C3 | D2 TPM |
#+-------------------+----------------------------+
register "i2c[0]" = "{
.speed = I2C_SPEED_FAST,
}"
register "i2c[1]" = "{
.speed = I2C_SPEED_FAST,
}"
register "i2c[2]" = "{
.speed = I2C_SPEED_FAST,
}"
register "i2c[3]" = "{
.speed = I2C_SPEED_FAST,
.early_init = true,
}"
# general purpose PCIe clock output configuration # general purpose PCIe clock output configuration
register "gpp_clk_config[0]" = "GPP_CLK_REQ" register "gpp_clk_config[0]" = "GPP_CLK_REQ"
register "gpp_clk_config[1]" = "GPP_CLK_REQ" register "gpp_clk_config[1]" = "GPP_CLK_REQ"

26
src/mainboard/google/skyrim/variants/skyrim/overridetree.cb
View File

@ -91,32 +91,6 @@ chip soc/amd/mendocino
end # Internal GPP Bridge 0 to Bus A end # Internal GPP Bridge 0 to Bus A
end # domain end # domain
# I2C Config
#+-------------------+----------------------------+
#| Field | Value |
#+-------------------+----------------------------+
#| I2C0 | Trackpad |
#| I2C1 | Touchscreen |
#| I2C2 | Speaker, Codec, P-SAR, USB |
#| I2C3 | D2 TPM |
#+-------------------+----------------------------+
register "i2c[0]" = "{
.speed = I2C_SPEED_FAST,
}"
register "i2c[1]" = "{
.speed = I2C_SPEED_FAST,
}"
register "i2c[2]" = "{
.speed = I2C_SPEED_FAST,
}"
register "i2c[3]" = "{
.speed = I2C_SPEED_FAST,
.early_init = true,
}"
device ref i2c_0 on device ref i2c_0 on
chip drivers/i2c/generic chip drivers/i2c/generic
register "hid" = ""ELAN0000"" register "hid" = ""ELAN0000""

27
src/mainboard/google/skyrim/variants/winterhold/overridetree.cb
View File

@ -1,32 +1,5 @@
# SPDX-License-Identifier: GPL-2.0-or-later # SPDX-License-Identifier: GPL-2.0-or-later
chip soc/amd/mendocino chip soc/amd/mendocino
# I2C Config
#+-------------------+----------------------------+
#| Field | Value |
#+-------------------+----------------------------+
#| I2C0 | Trackpad |
#| I2C1 | Touchscreen |
#| I2C2 | Speaker, Codec, P-SAR, USB |
#| I2C3 | D2 TPM |
#+-------------------+----------------------------+
register "i2c[0]" = "{
.speed = I2C_SPEED_FAST,
}"
register "i2c[1]" = "{
.speed = I2C_SPEED_FAST,
}"
register "i2c[2]" = "{
.speed = I2C_SPEED_FAST,
}"
register "i2c[3]" = "{
.speed = I2C_SPEED_FAST,
.early_init = true,
}"
device domain 0 on end device domain 0 on end
end # chip soc/amd/mendocino end # chip soc/amd/mendocino