zero warnings days

Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
Acked-by: Stefan Reinauer <stepan@coresystems.de>



git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5492 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Stefan Reinauer 2010-04-25 13:54:30 +00:00 committed by Stefan Reinauer
parent 7d2a39631e
commit d55e26f1b1
18 changed files with 89 additions and 60 deletions

View File

@ -80,7 +80,8 @@ static void activate_spd_rom(const struct mem_controller *ctrl)
{ {
} }
static void soft_reset(void) #include <reset.h>
void soft_reset(void)
{ {
uint8_t tmp; uint8_t tmp;
@ -98,6 +99,9 @@ static void soft_reset(void)
} }
} }
// defines S3_NVRAM_EARLY:
#include "southbridge/via/k8t890/k8t890_early_car.c"
#define K8_4RANK_DIMM_SUPPORT 1 #define K8_4RANK_DIMM_SUPPORT 1
#include "northbridge/amd/amdk8/amdk8.h" #include "northbridge/amd/amdk8/amdk8.h"
@ -107,7 +111,6 @@ static void soft_reset(void)
#include "lib/generic_sdram.c" #include "lib/generic_sdram.c"
#include "cpu/amd/dualcore/dualcore.c" #include "cpu/amd/dualcore/dualcore.c"
#include "southbridge/via/k8t890/k8t890_early_car.c"
#include "cpu/amd/car/post_cache_as_ram.c" #include "cpu/amd/car/post_cache_as_ram.c"
#include "cpu/amd/model_fxx/init_cpus.c" #include "cpu/amd/model_fxx/init_cpus.c"

View File

@ -1,5 +1,6 @@
#include <arch/io.h> #include <arch/io.h>
#include <stdlib.h> #include <stdlib.h>
#include <superio/ite/it8716f/it8716f.h>
static void write_index(uint16_t port_base, uint8_t reg, uint8_t value) static void write_index(uint16_t port_base, uint8_t reg, uint8_t value)
{ {

View File

@ -98,16 +98,6 @@ static inline int spd_read_byte(unsigned device, unsigned address)
return smbus_read_byte(device, address); return smbus_read_byte(device, address);
} }
#include "northbridge/amd/amdk8/amdk8_f.h"
#include "northbridge/amd/amdk8/incoherent_ht.c"
#include "northbridge/amd/amdk8/coherent_ht.c"
#include "northbridge/amd/amdk8/raminit_f.c"
#include "lib/generic_sdram.c"
#include "resourcemap.c"
#include "cpu/amd/dualcore/dualcore.c"
#define MCP55_NUM 1 #define MCP55_NUM 1
#define MCP55_USE_NIC 1 #define MCP55_USE_NIC 1
#define MCP55_USE_AZA 1 #define MCP55_USE_AZA 1
@ -125,6 +115,18 @@ static inline int spd_read_byte(unsigned device, unsigned address)
#include "southbridge/nvidia/mcp55/mcp55_early_setup_ss.h" #include "southbridge/nvidia/mcp55/mcp55_early_setup_ss.h"
#include "southbridge/nvidia/mcp55/mcp55_early_setup_car.c" #include "southbridge/nvidia/mcp55/mcp55_early_setup_car.c"
#include "northbridge/amd/amdk8/amdk8_f.h"
#include "northbridge/amd/amdk8/incoherent_ht.c"
#include "northbridge/amd/amdk8/coherent_ht.c"
#include "northbridge/amd/amdk8/raminit_f.c"
#include "lib/generic_sdram.c"
#include "resourcemap.c"
#include "cpu/amd/dualcore/dualcore.c"
#include "cpu/amd/car/post_cache_as_ram.c" #include "cpu/amd/car/post_cache_as_ram.c"
#include "cpu/amd/model_fxx/init_cpus.c" #include "cpu/amd/model_fxx/init_cpus.c"

View File

@ -17,6 +17,8 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/ */
#include "raminit.h"
void exit_from_self(int controllers, const struct mem_controller *ctrl, void exit_from_self(int controllers, const struct mem_controller *ctrl,
struct sys_info *sysinfo) struct sys_info *sysinfo)
{ {

View File

@ -11,6 +11,9 @@ struct mem_controller {
uint16_t channel1[DIMM_SOCKETS]; uint16_t channel1[DIMM_SOCKETS];
}; };
struct sys_info;
void exit_from_self(int controllers, const struct mem_controller *ctrl, struct sys_info *sysinfo);
#if defined(__PRE_RAM__) && defined(RAMINIT_SYSINFO) && RAMINIT_SYSINFO == 1 #if defined(__PRE_RAM__) && defined(RAMINIT_SYSINFO) && RAMINIT_SYSINFO == 1
void sdram_initialize(int controllers, const struct mem_controller *ctrl, void *sysinfo); void sdram_initialize(int controllers, const struct mem_controller *ctrl, void *sysinfo);
#else #else

View File

@ -1829,12 +1829,12 @@ static void set_sysinfo_in_ram(unsigned val)
//int s3_save_nvram_early(u32 dword, int size, int nvram_pos); //int s3_save_nvram_early(u32 dword, int size, int nvram_pos);
//int s3_load_nvram_early(int size, u32 *old_dword, int nvram_pos); //int s3_load_nvram_early(int size, u32 *old_dword, int nvram_pos);
#else #else
static int s3_save_nvram_early(u32 dword, int size, int nvram_pos) static inline int s3_save_nvram_early(u32 dword, int size, int nvram_pos)
{ {
return nvram_pos; return nvram_pos;
} }
static int s3_load_nvram_early(int size, u32 *old_dword, int nvram_pos) static inline int s3_load_nvram_early(int size, u32 *old_dword, int nvram_pos)
{ {
die("No memory NVRAM loader for DQS data! Unable to restore memory state\n"); die("No memory NVRAM loader for DQS data! Unable to restore memory state\n");

View File

@ -80,12 +80,12 @@ static int via_cn400_int15_handler(struct eregs *regs)
static void vga_init(device_t dev) static void vga_init(device_t dev)
{ {
u8 reg8; u8 reg8;
u32 temp;
mainboard_interrupt_handlers(0x15, &via_cn400_int15_handler); mainboard_interrupt_handlers(0x15, &via_cn400_int15_handler);
#undef OLD_BOCHS_METHOD #undef OLD_BOCHS_METHOD
#ifdef OLD_BOCHS_METHOD #ifdef OLD_BOCHS_METHOD
u32 temp;
// XXX We might need more bios hooks in the f segment, but // XXX We might need more bios hooks in the f segment, but
// this way of copying the BOCHS BIOS does not work anymore. // this way of copying the BOCHS BIOS does not work anymore.
// As soon as someone verifies that CN400 can init VGA, the // As soon as someone verifies that CN400 can init VGA, the

View File

@ -81,7 +81,8 @@ static int via_cx700_int15_handler(struct eregs *regs)
return res; return res;
} }
void write_protect_vgabios(void) #ifdef UNUSED_CODE
static void write_protect_vgabios(void)
{ {
device_t dev; device_t dev;
@ -95,6 +96,7 @@ void write_protect_vgabios(void)
if (dev) if (dev)
pci_write_config8(dev, 0x61, 0xff); pci_write_config8(dev, 0x61, 0xff);
} }
#endif
static void vga_init(device_t dev) static void vga_init(device_t dev)
{ {

View File

@ -21,5 +21,6 @@
#define NORTHBRIDGE_VIA_CX700_H #define NORTHBRIDGE_VIA_CX700_H
extern unsigned int cx700_scan_root_bus(device_t root, unsigned int max); extern unsigned int cx700_scan_root_bus(device_t root, unsigned int max);
extern void (*vga_enable_console)(void) __attribute__((regparm(0)));
#endif /* NORTHBRIDGE_VIA_CX700_H */ #endif /* NORTHBRIDGE_VIA_CX700_H */

View File

@ -21,5 +21,6 @@
#define NORTHBRIDGE_VIA_VX800_H #define NORTHBRIDGE_VIA_VX800_H
extern unsigned int vx800_scan_root_bus(device_t root, unsigned int max); extern unsigned int vx800_scan_root_bus(device_t root, unsigned int max);
extern void (*vga_enable_console)(void) __attribute__((regparm(0)));
#endif /* NORTHBRIDGE_VIA_VX800_H */ #endif /* NORTHBRIDGE_VIA_VX800_H */

View File

@ -122,6 +122,7 @@ static void FreeMMIO(MMIORANGE* pMMIO)
#define MMIO_ATTRIB_BOTTOM_TO_TOP 1<<1 #define MMIO_ATTRIB_BOTTOM_TO_TOP 1<<1
#define MMIO_ATTRIB_SKIP_ZERO 1<<2 #define MMIO_ATTRIB_SKIP_ZERO 1<<2
#ifdef DONT_TRUST_RESOURCE_ALLOCATION
static u32 SetMMIO(u32 Base, u32 Limit, u8 Attribute, MMIORANGE *pMMIO) static u32 SetMMIO(u32 Base, u32 Limit, u8 Attribute, MMIORANGE *pMMIO)
{ {
int i; int i;
@ -180,7 +181,6 @@ static u8 FinalizeMMIO(MMIORANGE *pMMIO)
return n; return n;
} }
#ifdef DONT_TRUST_RESOURCE_ALLOCATION
static CIM_STATUS GetCreativeMMIO(MMIORANGE *pMMIO) static CIM_STATUS GetCreativeMMIO(MMIORANGE *pMMIO)
{ {
CIM_STATUS Status = CIM_UNSUPPORTED; CIM_STATUS Status = CIM_UNSUPPORTED;

View File

@ -19,6 +19,8 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/ */
#include <reset.h>
static unsigned get_sbdn(unsigned bus) static unsigned get_sbdn(unsigned bus)
{ {
device_t dev; device_t dev;
@ -33,7 +35,15 @@ static unsigned get_sbdn(unsigned bus)
} }
static void hard_reset(void) void soft_reset(void)
{
set_bios_reset();
/* link reset */
outb(0x02, 0x0cf9);
outb(0x06, 0x0cf9);
}
void hard_reset(void)
{ {
set_bios_reset(); set_bios_reset();
@ -41,20 +51,10 @@ static void hard_reset(void)
outb(0x0a, 0x0cf9); outb(0x0a, 0x0cf9);
outb(0x0e, 0x0cf9); outb(0x0e, 0x0cf9);
} }
static void enable_fid_change_on_sb(unsigned sbbusn, unsigned sbdn) static void enable_fid_change_on_sb(unsigned sbbusn, unsigned sbdn)
{ {
/* default value for mcp55 is good */ /* default value for mcp55 is good */
/* set VFSMAF ( VID/FID System Management Action Field) to 2 */ /* set VFSMAF ( VID/FID System Management Action Field) to 2 */
}
static void soft_reset(void)
{
set_bios_reset();
#if 1
/* link reset */
outb(0x02, 0x0cf9);
outb(0x06, 0x0cf9);
#endif
} }

View File

@ -21,6 +21,7 @@
static int set_ht_link_buffer_counts_chain(uint8_t ht_c_num, unsigned vendorid, unsigned val); static int set_ht_link_buffer_counts_chain(uint8_t ht_c_num, unsigned vendorid, unsigned val);
#ifdef UNUSED_CODE
static int set_ht_link_mcp55(uint8_t ht_c_num) static int set_ht_link_mcp55(uint8_t ht_c_num)
{ {
unsigned vendorid = 0x10de; unsigned vendorid = 0x10de;
@ -51,6 +52,7 @@ static void setup_ss_table(unsigned index, unsigned where, unsigned control, con
outl(val, control); outl(val, control);
} }
#endif
/* SIZE 0x100 */ /* SIZE 0x100 */
#define ANACTRL_IO_BASE 0x2800 #define ANACTRL_IO_BASE 0x2800
@ -130,14 +132,6 @@ static void mcp55_early_clear_port(unsigned mcp55_num, unsigned *busn, unsigned
} }
}
static void delayx(uint8_t value) {
#if 1
int i;
for(i=0;i<0x8000;i++) {
outb(value, 0x80);
}
#endif
} }
static void mcp55_early_pcie_setup(unsigned busnx, unsigned devnx, unsigned anactrl_io_base, unsigned pci_e_x) static void mcp55_early_pcie_setup(unsigned busnx, unsigned devnx, unsigned anactrl_io_base, unsigned pci_e_x)
@ -170,14 +164,14 @@ static void mcp55_early_pcie_setup(unsigned busnx, unsigned devnx, unsigned anac
outl(tgio_ctrl, anactrl_io_base + 0xcc); outl(tgio_ctrl, anactrl_io_base + 0xcc);
// wait 100us // wait 100us
delayx(1); udelay(100);
dword = pci_read_config32(dev, 0xe4); dword = pci_read_config32(dev, 0xe4);
dword &= ~(0x3f0); // enable dword &= ~(0x3f0); // enable
pci_write_config32(dev, 0xe4, dword); pci_write_config32(dev, 0xe4, dword);
// need to wait 100ms // need to wait 100ms
delayx(1000); mdelay(100);
} }
static void mcp55_early_setup(unsigned mcp55_num, unsigned *busn, unsigned *devn, unsigned *io_base, unsigned *pci_e_x) static void mcp55_early_setup(unsigned mcp55_num, unsigned *busn, unsigned *devn, unsigned *io_base, unsigned *pci_e_x)

View File

@ -31,13 +31,13 @@ static void enable_smbus(void)
{ {
device_t dev; device_t dev;
dev = pci_locate_device(PCI_ID(0x10de, 0x0368), 0); dev = pci_locate_device(PCI_ID(0x10de, 0x0368), 0);
#if 0
if (dev == PCI_DEV_INVALID) { if (dev == PCI_DEV_INVALID) {
die("SMBUS controller not found\n"); printk(BIOS_WARNING, "SMBUS controller not found\n");
} else {
printk(BIOS_DEBUG, "SMBus controller enabled\n");
} }
print_debug("SMBus controller enabled\n");
#endif
/* set smbus iobase */ /* set smbus iobase */
pci_write_config32(dev, 0x20, SMBUS0_IO_BASE | 1); pci_write_config32(dev, 0x20, SMBUS0_IO_BASE | 1);
pci_write_config32(dev, 0x24, SMBUS1_IO_BASE | 1); pci_write_config32(dev, 0x24, SMBUS1_IO_BASE | 1);
@ -48,36 +48,42 @@ static void enable_smbus(void)
outb(inb(SMBUS1_IO_BASE + SMBHSTSTAT), SMBUS1_IO_BASE + SMBHSTSTAT); outb(inb(SMBUS1_IO_BASE + SMBHSTSTAT), SMBUS1_IO_BASE + SMBHSTSTAT);
} }
static int smbus_recv_byte(unsigned device) static inline int smbus_recv_byte(unsigned device)
{ {
return do_smbus_recv_byte(SMBUS0_IO_BASE, device); return do_smbus_recv_byte(SMBUS0_IO_BASE, device);
} }
static int smbus_send_byte(unsigned device, unsigned char val)
static inline int smbus_send_byte(unsigned device, unsigned char val)
{ {
return do_smbus_send_byte(SMBUS0_IO_BASE, device, val); return do_smbus_send_byte(SMBUS0_IO_BASE, device, val);
} }
static int smbus_read_byte(unsigned device, unsigned address)
static inline int smbus_read_byte(unsigned device, unsigned address)
{ {
return do_smbus_read_byte(SMBUS0_IO_BASE, device, address); return do_smbus_read_byte(SMBUS0_IO_BASE, device, address);
} }
static int smbus_write_byte(unsigned device, unsigned address, unsigned char val)
static inline int smbus_write_byte(unsigned device, unsigned address, unsigned char val)
{ {
return do_smbus_write_byte(SMBUS0_IO_BASE, device, address, val); return do_smbus_write_byte(SMBUS0_IO_BASE, device, address, val);
} }
static int smbusx_recv_byte(unsigned smb_index, unsigned device) static inline int smbusx_recv_byte(unsigned smb_index, unsigned device)
{ {
return do_smbus_recv_byte(SMBUS0_IO_BASE + (smb_index<<8), device); return do_smbus_recv_byte(SMBUS0_IO_BASE + (smb_index<<8), device);
} }
static int smbusx_send_byte(unsigned smb_index, unsigned device, unsigned char val)
static inline int smbusx_send_byte(unsigned smb_index, unsigned device, unsigned char val)
{ {
return do_smbus_send_byte(SMBUS0_IO_BASE + (smb_index<<8), device, val); return do_smbus_send_byte(SMBUS0_IO_BASE + (smb_index<<8), device, val);
} }
static int smbusx_read_byte(unsigned smb_index, unsigned device, unsigned address)
static inline int smbusx_read_byte(unsigned smb_index, unsigned device, unsigned address)
{ {
return do_smbus_read_byte(SMBUS0_IO_BASE + (smb_index<<8), device, address); return do_smbus_read_byte(SMBUS0_IO_BASE + (smb_index<<8), device, address);
} }
static int smbusx_write_byte(unsigned smb_index, unsigned device, unsigned address, unsigned char val)
static inline int smbusx_write_byte(unsigned smb_index, unsigned device, unsigned address, unsigned char val)
{ {
return do_smbus_write_byte(SMBUS0_IO_BASE + (smb_index<<8), device, address, val); return do_smbus_write_byte(SMBUS0_IO_BASE + (smb_index<<8), device, address, val);
} }

View File

@ -21,6 +21,9 @@
/* Datasheet: http://www.ite.com.tw/product_info/PC/Brief-IT8716_2.asp */ /* Datasheet: http://www.ite.com.tw/product_info/PC/Brief-IT8716_2.asp */
/* Status: Untested on real hardware, but it compiles. */ /* Status: Untested on real hardware, but it compiles. */
#ifndef SUPERIO_ITE_IT8716F_IT8716F_H
#define SUPERIO_ITE_IT8716F_IT8716F_H
#define IT8716F_FDC 0x00 /* Floppy */ #define IT8716F_FDC 0x00 /* Floppy */
#define IT8716F_SP1 0x01 /* Com1 */ #define IT8716F_SP1 0x01 /* Com1 */
#define IT8716F_SP2 0x02 /* Com2 */ #define IT8716F_SP2 0x02 /* Com2 */
@ -32,3 +35,16 @@
#define IT8716F_MIDI 0x08 /* MIDI port */ #define IT8716F_MIDI 0x08 /* MIDI port */
#define IT8716F_GAME 0x09 /* GAME port */ #define IT8716F_GAME 0x09 /* GAME port */
#define IT8716F_IR 0x0a /* Consumer IR */ #define IT8716F_IR 0x0a /* Consumer IR */
#if defined(CONFIG_SUPERIO_ITE_IT8716F_OVERRIDE_FANCTL) && CONFIG_SUPERIO_ITE_IT8716F_OVERRIDE_FANCTL
/* provided by mainboard, called by it8716f superio.c */
void init_ec(uint16_t base);
#endif
#if defined(__PRE_RAM__) && !defined(__ROMCC__)
void it8716f_disable_dev(device_t dev);
void it8716f_enable_dev(device_t dev, unsigned iobase);
void it8716f_enable_serial(device_t dev, unsigned iobase);
#endif
#endif

View File

@ -22,13 +22,13 @@
#include <arch/romcc_io.h> #include <arch/romcc_io.h>
#include "it8716f.h" #include "it8716f.h"
static void it8716f_disable_dev(device_t dev) void it8716f_disable_dev(device_t dev)
{ {
pnp_set_logical_device(dev); pnp_set_logical_device(dev);
pnp_set_enable(dev, 0); pnp_set_enable(dev, 0);
} }
static void it8716f_enable_dev(device_t dev, unsigned iobase) void it8716f_enable_dev(device_t dev, unsigned iobase)
{ {
pnp_set_logical_device(dev); pnp_set_logical_device(dev);
pnp_set_enable(dev, 0); pnp_set_enable(dev, 0);

View File

@ -59,7 +59,7 @@ static void pnp_exit_ext_func_mode(device_t dev)
pnp_write_config(dev, 0x02, 0x02); pnp_write_config(dev, 0x02, 0x02);
} }
static void it8716f_enable_serial(device_t dev, unsigned iobase) void it8716f_enable_serial(device_t dev, unsigned iobase)
{ {
pnp_enter_ext_func_mode(dev); pnp_enter_ext_func_mode(dev);
pnp_set_logical_device(dev); pnp_set_logical_device(dev);

View File

@ -51,9 +51,7 @@ static void pnp_exit_ext_func_mode(device_t dev)
pnp_write_config(dev, 0x02, 0x02); pnp_write_config(dev, 0x02, 0x02);
} }
#if CONFIG_SUPERIO_ITE_IT8716F_OVERRIDE_FANCTL #if !defined(CONFIG_SUPERIO_ITE_IT8716F_OVERRIDE_FANCTL) || !CONFIG_SUPERIO_ITE_IT8716F_OVERRIDE_FANCTL
extern void init_ec(uint16_t base);
#else
static void pnp_write_index(uint16_t port_base, uint8_t reg, uint8_t value) static void pnp_write_index(uint16_t port_base, uint8_t reg, uint8_t value)
{ {
outb(reg, port_base); outb(reg, port_base);