From d59b3dd08540b7cf42dc98d68da42b2a4305f6ee Mon Sep 17 00:00:00 2001 From: Raul E Rangel Date: Fri, 4 Mar 2022 10:28:42 -0700 Subject: [PATCH] soc/amd/common/block: Add mainboard_handle_smi The current SMM framework only allows the mainboard code to handle GPEs. i.e., Events 0 - 23. This change allows the mainboard code to handle any SMI events not handled by the SoC code. This will allow the mainboard code to handle `SMITYPE_ESPI_SMI`. BUG=b:222694093 TEST=Build guybrush Signed-off-by: Raul E Rangel Change-Id: I81943e8cb31e998f29cc60b565d3ca0a8dfe9cb2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62598 Tested-by: build bot (Jenkins) Reviewed-by: Karthik Ramasubramanian Reviewed-by: Felix Held --- src/soc/amd/common/block/cpu/smm/smi_handler.c | 7 +++++++ src/soc/amd/common/block/include/amdblocks/smm.h | 2 ++ 2 files changed, 9 insertions(+) diff --git a/src/soc/amd/common/block/cpu/smm/smi_handler.c b/src/soc/amd/common/block/cpu/smm/smi_handler.c index e535cb0f14..ee8423a0f5 100644 --- a/src/soc/amd/common/block/cpu/smm/smi_handler.c +++ b/src/soc/amd/common/block/cpu/smm/smi_handler.c @@ -7,6 +7,11 @@ #include #include +__weak void mainboard_handle_smi(int event) +{ + printk(BIOS_WARNING, "SMI event %d is missing handler\n", event); +} + static void process_smi_sources(uint32_t reg) { const uint32_t status = smi_read32(reg); @@ -19,6 +24,8 @@ static void process_smi_sources(uint32_t reg) source_handler = get_smi_source_handler(i + bit_zero); if (source_handler) source_handler(); + else if (reg != SMI_REG_SMISTS0 || (status & GEVENT_MASK) == 0) + mainboard_handle_smi(i + bit_zero); } } diff --git a/src/soc/amd/common/block/include/amdblocks/smm.h b/src/soc/amd/common/block/include/amdblocks/smm.h index 187eddf691..46008fae2e 100644 --- a/src/soc/amd/common/block/include/amdblocks/smm.h +++ b/src/soc/amd/common/block/include/amdblocks/smm.h @@ -14,3 +14,5 @@ void *get_smi_source_handler(int source); void handle_smi_gsmi(void); void handle_smi_store(void); void clear_tvalid(void); +/* See SMITYPE_* for list possible of events. GEVENTS are handled with mainboard_smi_gpi. */ +void mainboard_handle_smi(int event);