GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/skl: replace conditional on dt option reading CPUID for CPPC 

Check ISST (Intel SpeedShift) availability via CPUID.06H:EAX[7], instead
of relying on the devicetree option `speed_shift_enable`, that is going
to be dropped.

Test: GCPC and _CPC entries still get generated on Supermicro X11SSM-F

Change-Id: I5f9bf09385627fb6a1d8e566a80370f7ddd8605e
Signed-off-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46461
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by:  Felix Singer <felixsinger@posteo.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Michael Niewöhner 2020-10-15 00:27:59 +02:00 committed by Patrick Georgi
parent 6267cc523b
commit d5a45470c8
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/soc/intel/skylake/acpi.c
View File

@ -35,6 +35,8 @@
#include "chip.h" #include "chip.h"
#define CPUID_6_EAX_ISST (1 << 7)
/* /*
* List of suported C-states in this processor. * List of suported C-states in this processor.
*/ */
@ -379,7 +381,7 @@ void generate_cpu_entries(const struct device *device)
printk(BIOS_DEBUG, "Found %d CPU(s) with %d core(s) each.\n", printk(BIOS_DEBUG, "Found %d CPU(s) with %d core(s) each.\n",
numcpus, cores_per_package); numcpus, cores_per_package);
if (config->speed_shift_enable) { if (cpuid_eax(6) & CPUID_6_EAX_ISST) {
struct cppc_config cppc_config; struct cppc_config cppc_config;
cpu_init_cppc_config(&cppc_config, 2 /* version 2 */); cpu_init_cppc_config(&cppc_config, 2 /* version 2 */);
acpigen_write_CPPC_package(&cppc_config); acpigen_write_CPPC_package(&cppc_config);
@ -405,7 +407,7 @@ void generate_cpu_entries(const struct device *device)
cores_per_package); cores_per_package);
} }
if (config->speed_shift_enable) if (cpuid_eax(6) & CPUID_6_EAX_ISST)
acpigen_write_CPPC_method(); acpigen_write_CPPC_method();
acpigen_pop_len(); acpigen_pop_len();