GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

amdblocks/biosram: Do small reformatting 

Remove two blank lines and reorder functions by read/write sizes.

Change-Id: I7bd6ed44546d49b65135a98e424a5669d90f2867
Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38146
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Marshall Dawson 2020-01-02 16:04:28 -07:00 committed by Michał Żygowski
parent c4a71467d1
commit d5f0b4a17b
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/soc/amd/common/block/acpimmio/biosram.c
View File

@ -38,12 +38,6 @@ static uint16_t biosram_read16(uint8_t reg) /* Must be 1 byte at a time */
return (biosram_read8(reg + sizeof(uint8_t)) << 8 | biosram_read8(reg)); return (biosram_read8(reg + sizeof(uint8_t)) << 8 | biosram_read8(reg));
} }
static uint32_t biosram_read32(uint8_t reg)
{
uint32_t value = biosram_read16(reg + sizeof(uint16_t)) << 16;
return value | biosram_read16(reg);
}
static void biosram_write16(uint8_t reg, uint16_t value) static void biosram_write16(uint8_t reg, uint16_t value)
{ {
biosram_write8(reg, value & 0xff); biosram_write8(reg, value & 0xff);
@ -51,6 +45,12 @@ static void biosram_write16(uint8_t reg, uint16_t value)
biosram_write8(reg + sizeof(uint8_t), value & 0xff); biosram_write8(reg + sizeof(uint8_t), value & 0xff);
} }
static uint32_t biosram_read32(uint8_t reg)
{
uint32_t value = biosram_read16(reg + sizeof(uint16_t)) << 16;
return value | biosram_read16(reg);
}
static void biosram_write32(uint8_t reg, uint32_t value) static void biosram_write32(uint8_t reg, uint32_t value)
{ {
biosram_write16(reg, value & 0xffff); biosram_write16(reg, value & 0xffff);
@ -58,7 +58,6 @@ static void biosram_write32(uint8_t reg, uint32_t value)
biosram_write16(reg + sizeof(uint16_t), value & 0xffff); biosram_write16(reg + sizeof(uint16_t), value & 0xffff);
} }
/* Access to BIOSRAM is only allowed through the abstractions below. */ /* Access to BIOSRAM is only allowed through the abstractions below. */
void *get_ap_entry_ptr(void) void *get_ap_entry_ptr(void)
@ -71,7 +70,6 @@ void set_ap_entry_ptr(void *entry)
biosram_write32(BIOSRAM_AP_ENTRY, (uintptr_t)entry); biosram_write32(BIOSRAM_AP_ENTRY, (uintptr_t)entry);
} }
void backup_top_of_low_cacheable(uintptr_t ramtop) void backup_top_of_low_cacheable(uintptr_t ramtop)
{ {
biosram_write32(BIOSRAM_CBMEM_TOP, ramtop); biosram_write32(BIOSRAM_CBMEM_TOP, ramtop);