GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/common/block/i2c: Ignore disabled I2C devices 

If I2C device is disabled:
1. BAR for the device will be 0
2. There is no need to generate ACPI tables for the device

TEST=Verified that if an i2c device is disabled statically in
devicetree or dynamically in mainboard, then coreboot does not die
looking for missing resources.

Change-Id: Id9a790e338a0e6f32c199f5f437203e1525df208
Signed-off-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-on: https://review.coreboot.org/20140
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com>
This commit is contained in:
Furquan Shaikh 2017-06-09 17:54:00 -07:00 committed by Furquan Shaikh
parent ab37e9a171
commit d629e433dd
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/soc/intel/common/block/i2c/i2c.c
View File

@ -41,7 +41,7 @@ uintptr_t lpss_i2c_base_address(unsigned int bus)
/* devfn -> dev */
dev = dev_find_slot(0, devfn);
if (!dev)
if (!dev || !dev->enabled)
return (uintptr_t)NULL;
/* dev -> bar0 */
@ -119,7 +119,12 @@ static void lpss_i2c_acpi_fill_ssdt(struct device *dev)
I2C_SPEED_FAST_PLUS,
I2C_SPEED_HIGH,
};
int i, bus = lpss_i2c_dev_to_bus(dev);
int i, bus;
if (!dev->enabled)
return;
bus = lpss_i2c_dev_to_bus(dev);
bcfg = i2c_get_soc_cfg(bus, dev);