mb/getac/p470: Use 'enum cb_err'

Change-Id: I9650fc672a94343472b44037f8a664d7d15aaf15
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68374
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-by: Patrick Georgi <patrick@coreboot.org>
This commit is contained in:
Elyes Haouas 2022-10-13 13:06:48 +02:00 committed by Patrick Georgi
parent 1733983d55
commit d6317e738e
2 changed files with 12 additions and 8 deletions

View File

@ -4,9 +4,11 @@
#include <arch/io.h> #include <arch/io.h>
#include <delay.h> #include <delay.h>
#include <ec/acpi/ec.h> #include <ec/acpi/ec.h>
#include <types.h>
#include "ec_oem.h" #include "ec_oem.h"
int send_ec_oem_command(u8 command) enum cb_err send_ec_oem_command(u8 command)
{ {
int timeout; int timeout;
@ -19,14 +21,14 @@ int send_ec_oem_command(u8 command)
if (!timeout) { if (!timeout) {
printk(BIOS_DEBUG, "Timeout while sending OEM command 0x%02x to EC!\n", printk(BIOS_DEBUG, "Timeout while sending OEM command 0x%02x to EC!\n",
command); command);
// return -1; // return CB_ERR;
} }
outb(command, EC_OEM_SC); outb(command, EC_OEM_SC);
return 0; return CB_SUCCESS;
} }
int send_ec_oem_data(u8 data) enum cb_err send_ec_oem_data(u8 data)
{ {
int timeout; int timeout;
@ -39,12 +41,12 @@ int send_ec_oem_data(u8 data)
if (!timeout) { if (!timeout) {
printk(BIOS_DEBUG, "Timeout while sending OEM data 0x%02x to EC!\n", printk(BIOS_DEBUG, "Timeout while sending OEM data 0x%02x to EC!\n",
data); data);
// return -1; // return CB_ERR;
} }
outb(data, EC_OEM_DATA); outb(data, EC_OEM_DATA);
return 0; return CB_SUCCESS;
} }
u8 recv_ec_oem_data(void) u8 recv_ec_oem_data(void)

View File

@ -3,6 +3,8 @@
#ifndef _MAINBOARD_EC_OEM_H #ifndef _MAINBOARD_EC_OEM_H
#define _MAINBOARD_EC_OEM_H #define _MAINBOARD_EC_OEM_H
#include <types.h>
#define EC_OEM_DATA 0x68 #define EC_OEM_DATA 0x68
#define EC_OEM_SC 0x6c #define EC_OEM_SC 0x6c
@ -21,8 +23,8 @@
#define BD_EC 0x83 // Burst Disable Embedded Controller #define BD_EC 0x83 // Burst Disable Embedded Controller
#define QR_EC 0x84 // Query Embedded Controller #define QR_EC 0x84 // Query Embedded Controller
int send_ec_oem_command(u8 command); enum cb_err send_ec_oem_command(u8 command);
int send_ec_oem_data(u8 data); enum cb_err send_ec_oem_data(u8 data);
u8 recv_ec_oem_data(void); u8 recv_ec_oem_data(void);
u8 ec_oem_read(u8 addr); u8 ec_oem_read(u8 addr);