GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/dedede: Remove unnecessary fixed IDs from galtic mem_parts_used.txt 

Currently, trying to regenerate the galtic Makefile.inc and
dram_id.generated.txt using part_id_gen fails due to duplicate fixed IDs
in the mem_parts_used.txt file.

Remove the fixed IDs since they aren't needed. The part IDs assigned are
the same either way.

Also delete the comments from mem_parts_used.txt, since lp4x/gen_part_id
currently doesn't support comments.

BUG=b:191776301
Regenerate the Makefile.inc and dram_id.generated.txt using gen_part_id,
and check that the part IDs don't changed. Command used:
util/spd_tools/lp4x/gen_part_id \
  src/soc/intel/jasperlake/spd \
  src/mainboard/google/dedede/variants/galtic/memory \
  src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt

Signed-off-by: Reka Norman <rekanorman@google.com>
Change-Id: Ida83814b2f19b4a56eb9fde5939fa6c7874803c4
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57733
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
This commit is contained in:
Reka Norman 2021-09-16 19:19:25 +10:00 committed by Patrick Georgi
parent 102a71c0d2
commit d642bb7f6a
2 changed files with 5 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mainboard/google/dedede/variants/galtic/memory/Makefile.inc
View File

@ -1,8 +1,7 @@
## SPDX-License-Identifier: GPL-2.0-or-later
## This is an auto-generated file. Do not edit!!
## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
SPD_SOURCES =
SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = H9HCNNNBKMMLXR-NEE , MT53E512M32D2NP-046 WT:E
SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = H9HCNNNBKMMLXR-NEE, MT53E512M32D2NP-046 WT:E
SPD_SOURCES += lp4x-spd-4.hex # ID = 1(0b0001) Parts = MT53E1G32D2NP-046 WT:A
SPD_SOURCES += lp4x-spd-3.hex # ID = 2(0b0010) Parts = H9HCNNNCPMMLXR-NEE

19
src/mainboard/google/dedede/variants/galtic/memory/mem_parts_used.txt
View File

@ -1,15 +1,4 @@
# This is a CSV file containing a list of memory parts used by this variant.
# One part per line with an optional fixed ID in column 2.
# Only include a fixed ID if it is required for legacy reasons!
# Generated IDs are dependent on the order of parts in this file,
# so new parts must always be added at the end of the file!
#
# Generate an updated Makefile.inc and dram_id.generated.txt by running the
# gen_part_id tool from util/spd_tools/{ddr4,lp4x}.
# See util/spd_tools/{ddr4,lp4x}/README.md for more details and instructions.
# Part Name
H9HCNNNBKMMLXR-NEE, 0
MT53E512M32D2NP-046 WT:E, 0
MT53E1G32D2NP-046 WT:A, 1
H9HCNNNCPMMLXR-NEE, 2
H9HCNNNBKMMLXR-NEE
MT53E512M32D2NP-046 WT:E
MT53E1G32D2NP-046 WT:A
H9HCNNNCPMMLXR-NEE