GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

AMD: Reduce stack size from 64 KB to the default of 4 KB 

Apply the following commit to all AMD boards.

    commit 935850e082
    Author: Stefan Reinauer <reinauer@chromium.org>
    Date:   Mon May 6 16:16:03 2013 -0700

        asrock/e350m1: reduce default stack size

        The stack used on the ASRock E350M1 is significantly less than
        what we currently set (64k per core). In fact, we use about half
        of the default stack size (4k) on core 0 and even less on non
        BSP cores [1]:

        $ grep stack coreboot_without_patch_but_monotonic_timer.log
        CPU1: stack_base 002a0000, stack_end 002afff8
        CPU1: stack: 002a0000 - 002b0000, lowest used address 002afda8, stack used: 600 bytes
        CPU0: stack: 002b0000 - 002c0000, lowest used address 002bf75c, stack used: 2212 bytes

        […]

        Reviewed-on: http://review.coreboot.org/3209

Please note that AGESA seems to define bigger stack sizes. But
these seem to be too much too.

    $ git grep STACK_SIZE src/vendorcode/amd
    […]
    src/vendorcode/amd/agesa/f14/Proc/CPU/Family/0x14/cpuF14CacheDefaults.c:#define BSP_STACK_SIZE            16384
    src/vendorcode/amd/agesa/f14/Proc/CPU/Family/0x14/cpuF14CacheDefaults.c:#define CORE0_STACK_SIZE          16384
    src/vendorcode/amd/agesa/f14/Proc/CPU/Family/0x14/cpuF14CacheDefaults.c:#define CORE1_STACK_SIZE          4096
    src/vendorcode/amd/agesa/f14/Proc/CPU/Family/0x14/cpuF14CacheDefaults.c:  BSP_STACK_SIZE,
    src/vendorcode/amd/agesa/f14/Proc/CPU/Family/0x14/cpuF14CacheDefaults.c:  CORE0_STACK_SIZE,
    src/vendorcode/amd/agesa/f14/Proc/CPU/Family/0x14/cpuF14CacheDefaults.c:  CORE1_STACK_SIZE,
    […]

The following command was used to create the patch.

    $ git grep -l STACK_SIZE src/mainboard/ | xargs sed -i '/STACK_SIZE/,+3d'

Change-Id: I36b95b7a6f190b64d0639fc036ce2fb0253f3fa1
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-on: http://review.coreboot.org/3217
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
Paul Menzel 2013-05-08 13:23:14 +02:00 committed by Stefan Reinauer
parent 3949e37834
commit d654f42e27
17 changed files with 0 additions and 68 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/amd/dinar/Kconfig
View File

@ -82,10 +82,6 @@ config HEAP_SIZE
hex
default 0xc0000
config STACK_SIZE
hex
default 0x10000
config RAMBASE
hex
default 0x200000

4
src/mainboard/amd/inagua/Kconfig
View File

@ -84,10 +84,6 @@ config HEAP_SIZE
hex
default 0xc0000
config STACK_SIZE
hex
default 0x10000
config RAMBASE
hex
default 0x200000

4
src/mainboard/amd/parmer/Kconfig
View File

@ -84,10 +84,6 @@ config HEAP_SIZE
hex
default 0xc0000
config STACK_SIZE
hex
default 0x10000
config RAMBASE
hex
default 0x200000

4
src/mainboard/amd/persimmon/Kconfig
View File

@ -84,10 +84,6 @@ config HEAP_SIZE
hex
default 0xc0000
config STACK_SIZE
hex
default 0x10000
config RAMBASE
hex
default 0x200000

4
src/mainboard/amd/south_station/Kconfig
View File

@ -84,10 +84,6 @@ config HEAP_SIZE
hex
default 0xc0000
config STACK_SIZE
hex
default 0x10000
config RAMBASE
hex
default 0x200000

4
src/mainboard/amd/thatcher/Kconfig
View File

@ -84,10 +84,6 @@ config HEAP_SIZE
hex
default 0xc0000
config STACK_SIZE
hex
default 0x10000
config RAMBASE
hex
default 0x200000

4
src/mainboard/amd/torpedo/Kconfig
View File

@ -98,10 +98,6 @@ config HEAP_SIZE
hex
default 0xc0000
config STACK_SIZE
hex
default 0x10000
config RAMBASE
hex
default 0x200000

4
src/mainboard/amd/union_station/Kconfig
View File

@ -83,10 +83,6 @@ config HEAP_SIZE
hex
default 0xc0000
config STACK_SIZE
hex
default 0x10000
config RAMBASE
hex
default 0x200000

4
src/mainboard/asus/f2a85-m/Kconfig
View File

@ -109,10 +109,6 @@ config HEAP_SIZE
hex
default 0xc0000
config STACK_SIZE
hex
default 0x10000
config RAMBASE
hex
default 0x200000

4
src/mainboard/lippert/frontrunner-af/Kconfig
View File

@ -88,10 +88,6 @@ config HEAP_SIZE
hex
default 0xc0000
config STACK_SIZE
hex
default 0x10000
config RAMBASE
hex
default 0x200000

4
src/mainboard/lippert/toucan-af/Kconfig
View File

@ -90,10 +90,6 @@ config HEAP_SIZE
hex
default 0xc0000
config STACK_SIZE
hex
default 0x10000
config RAMBASE
hex
default 0x200000

4
src/mainboard/msi/ms9652_fam10/Kconfig
View File

@ -61,10 +61,6 @@ config SMP
bool
default y
config STACK_SIZE
hex
default 0x20000
config HEAP_SIZE
hex
default 0x20000

4
src/mainboard/supermicro/h8qgi/Kconfig
View File

@ -80,10 +80,6 @@ config HEAP_SIZE
hex
default 0xc0000
config STACK_SIZE
hex
default 0x10000
config RAMBASE
hex
default 0x200000

4
src/mainboard/supermicro/h8qme_fam10/Kconfig
View File

@ -92,8 +92,4 @@ config SERIAL_CPU_INIT
bool
default y
config STACK_SIZE
hex
default 0x10000
endif # BOARD_SUPERMICRO_H8QME_FAM10

4
src/mainboard/supermicro/h8scm/Kconfig
View File

@ -83,10 +83,6 @@ config HEAP_SIZE
hex
default 0xc0000
config STACK_SIZE
hex
default 0x10000
config RAMBASE
hex
default 0x200000

4
src/mainboard/technexion/tim5690/Kconfig
View File

@ -56,10 +56,6 @@ config IRQ_SLOT_COUNT
int
default 11
config STACK_SIZE
hex
default 0x2000
config HEAP_SIZE
hex
default 0x4000

4
src/mainboard/tyan/s8226/Kconfig
View File

@ -76,10 +76,6 @@ config HEAP_SIZE
hex
default 0xc0000
config STACK_SIZE
hex
default 0x10000
config RAMBASE
hex
default 0x200000