GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "mb/google/dedede: Program VCCIO selection for EN_SPKR GPIO" 

This reverts commit ce79ceec86. This has
introduced a regression in mainboards using JSL SoC such that it
overrides the soft straps for all the GPIOs. This in turn has led to
some of the peripherals not working.

Change-Id: Ifea5d4d0f474873f8bf4818ec1986e534f455216
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56615
Reviewed-by: Evan Green <evgreen@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Karthikeyan Ramasubramanian 2021-07-26 16:23:14 -06:00 committed by Karthik Ramasubramanian
parent b8c2fcca73
commit d678f65564
2 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/mainboard/google/dedede/Makefile.inc
View File

@ -9,7 +9,6 @@ ramstage-$(CONFIG_CHROMEOS) += chromeos.c
ramstage-y += mainboard.c
ramstage-y += ec.c
ramstage-y += board_info.c
ramstage-$(CONFIG_FW_CONFIG) += fw_config.c
VARIANT_DIR:=$(call strip_quotes,$(CONFIG_VARIANT_DIR))

17
src/mainboard/google/dedede/fw_config.c
View File

@ -1,17 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <bootstate.h>
#include <fw_config.h>
#include <gpio.h>
static const struct pad_config spkr_pads[] = {
PAD_CFG_GPO_VCCIOSEL(GPP_D17, 0, PLTRST, 1V8),
};
static void fw_config_handle(void *unused)
{
if (fw_config_probe(FW_CONFIG(AUDIO_AMP, RT1015P_AUTO))) {
gpio_configure_pads(spkr_pads, ARRAY_SIZE(spkr_pads));
}
}
BOOT_STATE_INIT_ENTRY(BS_DEV_ENABLE, BS_ON_ENTRY, fw_config_handle, NULL);