GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/zork/smihandler: only print warning in mainboard_smi_gpi 

zork doesn't configure any GPIO as PAD_SMI. Since mainboard_smi_gpi will
only get called for a GEVENT that will cause a non-SCI SMI, this isn't
expected to be called. For the unexpected and very unlikely case that it
still does get called, put a printk into mainboard_smi_gpi to see what
is happening there.

TEST=none

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I14c67b21a83b334558cdd54ebf700924aa9d0808
Reviewed-on: https://review.coreboot.org/c/coreboot/+/52359
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Held 2021-04-15 00:07:38 +02:00 committed by Martin Roth
parent 6638b11e20
commit d6ace2457e
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/google/zork/smihandler.c
View File

@ -2,6 +2,7 @@
#include <acpi/acpi.h> #include <acpi/acpi.h>
#include <baseboard/variants.h> #include <baseboard/variants.h>
#include <console/console.h>
#include <cpu/x86/smm.h> #include <cpu/x86/smm.h>
#include <ec/google/chromeec/smm.h> #include <ec/google/chromeec/smm.h>
#include <gpio.h> #include <gpio.h>
@ -11,9 +12,10 @@
void mainboard_smi_gpi(u32 gpi_sts) void mainboard_smi_gpi(u32 gpi_sts)
{ {
if (CONFIG(EC_GOOGLE_CHROMEEC)) printk(BIOS_WARNING, "No GPIO is set up as PAD_SMI, so %s should never end up being "
chromeec_smi_process_events(); "called. gpi_status is %x.\n", __func__, gpi_sts);
} }
void mainboard_smi_sleep(u8 slp_typ) void mainboard_smi_sleep(u8 slp_typ)
{ {
size_t num_gpios; size_t num_gpios;