GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/skylake: Enable LPC IO Decoding on PCR 

According to the PCH BIOS Spec (Doc#549921/Rev-2.3.4),
section 2.5.1.6, it is a requirement to program the same
value programmed in LPC "PCI offset 82h" into "PCR[DMI]+2774h"
to fully enable the Lpc IO enable decoding which is missing in
current source.

Without above changes, Skylake Saddlebrook platform with a
SIO does not boot.

Change-Id: Ief26e2718325b9d74ea0f83d47d2f917e0972173
Signed-off-by: praveen <praveenx.hodagatta.pranesh@intel.com>
Reviewed-on: https://review.coreboot.org/22819
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
praveen hodagatta pranesh 2017-12-09 00:51:21 +08:00 committed by Martin Roth
parent ac9d6b8c73
commit d6dffdc1fa
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/soc/intel/skylake/lpc.c
View File

@ -31,6 +31,7 @@
#include <reg_script.h>
#include <soc/iomap.h>
#include <soc/pcr_ids.h>
#include <soc/intel/common/block/lpc/lpc_def.h>
/**
PCH preserved MMIO range, 24 MB, from 0xFD000000 to 0xFE7FFFFF
@ -81,11 +82,17 @@ void soc_get_gen_io_dec_range(const struct device *dev, uint32_t *gen_io_dec)
void soc_setup_dmi_pcr_io_dec(uint32_t *gen_io_dec)
{
uint16_t lpc_en;
/* Mirror these same settings in DMI PCR */
pcr_write32(PID_DMI, PCR_DMI_LPCLGIR1, gen_io_dec[0]);
pcr_write32(PID_DMI, PCR_DMI_LPCLGIR2, gen_io_dec[1]);
pcr_write32(PID_DMI, PCR_DMI_LPCLGIR3, gen_io_dec[2]);
pcr_write32(PID_DMI, PCR_DMI_LPCLGIR4, gen_io_dec[3]);
/* LPC IO Decode Enable */
lpc_en = pci_read_config16(PCH_DEV_LPC, LPC_IO_ENABLES);
pcr_write16(PID_DMI, PCR_DMI_LPCIOE, lpc_en);
}
static const struct reg_script pch_misc_init_script[] = {