src/cpu: Capitalize CPU, APIC and IOAPIC typo fix

Change-Id: I82e0736dc6b44cfcc57cdfdc786c85c4b6882260
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/16276
Tested-by: build bot (Jenkins)
Reviewed-by: Omar Pakker
This commit is contained in:
Elyes HAOUAS 2016-08-21 10:12:15 +02:00 committed by Martin Roth
parent 38424987c6
commit d6e96864c9
54 changed files with 73 additions and 73 deletions

View File

@ -212,7 +212,7 @@ struct a10_ccm {
u8 res3[0xc];
u32 pll_lock_dbg; /* 0x4c pll lock time debug */
u32 osc24m_cfg; /* 0x50 osc24m control */
u32 cpu_ahb_apb0_cfg; /* 0x54 cpu,ahb and apb0 divide ratio */
u32 cpu_ahb_apb0_cfg; /* 0x54 CPU, ahb and apb0 divide ratio */
u32 apb1_clk_div_cfg; /* 0x58 apb1 clock dividor */
u32 axi_gate; /* 0x5c axi module clock gating */
u32 ahb_gate0; /* 0x60 ahb module clock gating 0 */

View File

@ -57,7 +57,7 @@ static void model_10_init(device_t dev)
enable_cache();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
/* Set the processor name string */

View File

@ -62,7 +62,7 @@ static void model_12_init(device_t dev)
enable_cache();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
/* Set the processor name string */

View File

@ -82,7 +82,7 @@ static void model_14_init(device_t dev)
wrmsr(MCI_STATUS + (i * 4), msr);
}
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
#if IS_ENABLED(CONFIG_LOGICAL_CPUS)

View File

@ -67,7 +67,7 @@ static void model_15_init(device_t dev)
wrmsr(MCI_STATUS + (i * 4), msr);
}
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
#if IS_ENABLED(CONFIG_LOGICAL_CPUS)

View File

@ -81,7 +81,7 @@ static void model_15_init(device_t dev)
wrmsr(MCI_STATUS + (i * 4), msr);
}
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
#if IS_ENABLED(CONFIG_LOGICAL_CPUS)

View File

@ -80,7 +80,7 @@ static void model_15_init(device_t dev)
wrmsr(MCI_STATUS + (i * 4), msr);
}
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
#if IS_ENABLED(CONFIG_LOGICAL_CPUS)

View File

@ -79,7 +79,7 @@ static void model_16_init(device_t dev)
}
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
#if IS_ENABLED(CONFIG_LOGICAL_CPUS)

View File

@ -82,7 +82,7 @@ unsigned get_apicid_base(unsigned ioapic_num)
siblings = get_max_siblings(nodes);
if(bsp_apic_id > 0) { // io apic could start from 0
if (bsp_apic_id > 0) { // IOAPIC could start from 0
return 0;
} else if(pci_read_config32(dev, 0x68) & ( (1<<17) | (1<<18)) ) { // enabled ext id but bsp = 0
return 1;
@ -108,8 +108,8 @@ unsigned get_apicid_base(unsigned ioapic_num)
if((!disable_siblings) && (siblings>0) ) {
/* for 8 way dual core, we will used up apicid 16:16, actually 16 is not allowed by current kernel
and the kernel will try to get one that is small than 16 to make io apic work.
I don't know when the kernel can support 256 apic id. (APIC_EXT_ID is enabled) */
and the kernel will try to get one that is small than 16 to make IOAPIC work.
I don't know when the kernel can support 256 APIC id. (APIC_EXT_ID is enabled) */
//4:10 for two way 8:12 for four way 16:16 for eight way
//Use CONFIG_MAX_PHYSICAL_CPUS instead of nodes for better consistency?
@ -122,7 +122,7 @@ unsigned get_apicid_base(unsigned ioapic_num)
if((apicid_base+ioapic_num-1)>0xf) {
// We need to enable APIC EXT ID
printk(BIOS_INFO, "if the IO APIC device doesn't support 256 apic id, \n you need to set CONFIG_ENABLE_APIC_EXT_ID in romstage.c so you can spare 16 id for ioapic\n");
printk(BIOS_INFO, "if the IOAPIC device doesn't support 256 APIC id, \n you need to set CONFIG_ENABLE_APIC_EXT_ID in romstage.c so you can spare 16 id for IOAPIC\n");
enable_apic_ext_id(nodes);
}

View File

@ -419,7 +419,7 @@ static u32 init_cpus(u32 cpu_init_detectedx, struct sys_info *sysinfo)
if (initial_apicid != 0) // other than bsp
#endif
{
/* use initial apic id to lift it */
/* use initial APIC id to lift it */
u32 dword = lapic_read(LAPIC_ID);
dword &= ~(0xff << 24);
dword |=

View File

@ -133,7 +133,7 @@ static void model_10xxx_init(device_t dev)
enable_cache();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
/* Set the processor name string */

View File

@ -22,7 +22,7 @@ static void geode_gx2_init(device_t dev)
/* Turn on caching if we haven't already */
x86_enable_cache();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
//setup_lapic();
vsm_end_post_smi();

View File

@ -40,7 +40,7 @@ static void geode_lx_init(device_t dev)
/* Turn on caching if we haven't already */
x86_enable_cache();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
//setup_lapic();
// do VSA late init

View File

@ -54,7 +54,7 @@ static void for_each_ap(u32 bsp_apicid, u32 core_range, process_ap_t process_ap,
j = ((pci_read_config32(PCI_DEV(0, 0x18 + i, 3), 0xe8) >> 12) &
3);
if (nb_cfg_54) {
if (j == 0) { // if it is single core, we need to increase siblings for apic calculation
if (j == 0) { // if it is single core, we need to increase siblings for APIC calculation
#if !CONFIG_K8_REV_F_SUPPORT
e0_later_single_core = is_e0_later_in_bsp(i); // single core
#else
@ -266,7 +266,7 @@ static u32 init_cpus(u32 cpu_init_detectedx)
if (initial_apicid != 0) // other than bsp
#endif
{
/* use initial apic id to lift it */
/* use initial APIC id to lift it */
u32 dword = lapic_read(LAPIC_ID);
dword &= ~(0xff << 24);
dword |=
@ -300,7 +300,7 @@ static u32 init_cpus(u32 cpu_init_detectedx)
if (id.coreid == 0) {
distinguish_cpu_resets(id.nodeid);
// start_other_core(id.nodeid); // start second core in first cpu, only allowed for nb_cfg_54 is not set
// start_other_core(id.nodeid); // start second core in first CPU, only allowed for nb_cfg_54 is not set
}
//here don't need to wait
lapic_write(LAPIC_MSG_REG, (apicid << 24) | 0x33); // mark the CPU is started

View File

@ -508,7 +508,7 @@ static void model_fxx_init(device_t dev)
/* Set the processor name string */
init_processor_name();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
#if CONFIG_LOGICAL_CPUS

View File

@ -79,7 +79,7 @@ static void model_15_init(device_t dev)
}
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
#if CONFIG_LOGICAL_CPUS

View File

@ -94,7 +94,7 @@ static void model_15_init(device_t dev)
}
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
#if CONFIG_LOGICAL_CPUS

View File

@ -77,7 +77,7 @@ static void model_16_init(device_t dev)
}
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
#if CONFIG_LOGICAL_CPUS

View File

@ -82,7 +82,7 @@ u32 get_apicid_base(u32 ioapic_num)
siblings = get_max_siblings(sysconf.nodes);
if(sysconf.bsp_apicid > 0) { // io apic could start from 0
if(sysconf.bsp_apicid > 0) { // IOAPIC could start from 0
return 0;
} else if (sysconf.enabled_apic_ext_id) { // enabled ext id but bsp = 0
return 1;
@ -96,8 +96,8 @@ u32 get_apicid_base(u32 ioapic_num)
if((!disable_siblings) && (siblings>0) ) {
/* for 8 way dual core, we will used up apicid 16:16, actually
16 is not allowed by current kernel and the kernel will try
to get one that is small than 16 to make io apic work. I don't
know when the kernel can support 256 apic id.
to get one that is small than 16 to make IOAPIC work. I don't
know when the kernel can support 256 APIC id.
(APIC_EXT_ID is enabled) */
//4:10 for two way 8:12 for four way 16:16 for eight way
@ -110,7 +110,7 @@ u32 get_apicid_base(u32 ioapic_num)
if((apicid_base+ioapic_num-1)>0xf) {
// We need to enable APIC EXT ID
printk(BIOS_SPEW, "if the IO APIC device doesn't support 256 apic id, \n you need to set CONFIG_ENABLE_APIC_EXT_ID in MB Option.lb so you can spare 16 id for ioapic\n");
printk(BIOS_SPEW, "if the IOAPIC device doesn't support 256 APIC id, \n you need to set CONFIG_ENABLE_APIC_EXT_ID in MB Option.lb so you can spare 16 id for IOAPIC\n");
enable_apic_ext_id(sysconf.nodes);
}

View File

@ -87,7 +87,7 @@ addrsize_no_MSR:
movl $0x0f, %edx
/* Preload high word of address mask (in %edx) for Variable
* MTRRs 0 and 1 and enable local apic at default base.
* MTRRs 0 and 1 and enable local APIC at default base.
*/
addrsize_set_high:
xorl %eax, %eax

View File

@ -34,7 +34,7 @@ static void ep80579_init(struct device *dev)
/* Update the microcode */
intel_update_microcode_from_cbfs();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
};

View File

@ -386,7 +386,7 @@ static void model_206ax_init(struct device *cpu)
/* Setup Page Attribute Tables (PAT) */
// TODO set up PAT
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
enable_lapic_tpr();
setup_lapic();

View File

@ -182,7 +182,7 @@ static void model_406dx_init(struct device *cpu)
x86_mtrr_check();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
/* Enable virtualization */

View File

@ -720,7 +720,7 @@ static void haswell_init(struct device *cpu)
/* Clear out pending MCEs */
configure_mca();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
enable_lapic_tpr();
setup_lapic();

View File

@ -32,7 +32,7 @@
static void init_timer(void)
{
/* Set the apic timer to no interrupts and periodic mode */
/* Set the APIC timer to no interrupts and periodic mode */
lapic_write(LAPIC_LVTT, (1 << 17)|(1<< 16)|(0 << 12)|(0 << 0));
/* Set the divider to 1, no divider */
@ -322,7 +322,7 @@ static void model_1067x_init(struct device *cpu)
x86_setup_mtrrs();
x86_mtrr_check();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
/* Initialize the APIC timer */

View File

@ -124,7 +124,7 @@ static void model_106cx_init(struct device *cpu)
x86_setup_mtrrs();
x86_mtrr_check();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
/* Enable virtualization */

View File

@ -379,7 +379,7 @@ static void model_2065x_init(struct device *cpu)
/* Setup Page Attribute Tables (PAT) */
// TODO set up PAT
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
enable_lapic_tpr();
setup_lapic();

View File

@ -572,7 +572,7 @@ static void model_206ax_init(struct device *cpu)
/* Setup Page Attribute Tables (PAT) */
// TODO set up PAT
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
enable_lapic_tpr();
setup_lapic();

View File

@ -36,7 +36,7 @@ static void model_65x_init(struct device *dev)
x86_setup_mtrrs();
x86_mtrr_check();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
};

View File

@ -40,7 +40,7 @@ static void model_67x_init(struct device *cpu)
x86_setup_mtrrs();
x86_mtrr_check();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
}

View File

@ -44,7 +44,7 @@ static void model_68x_init(struct device *cpu)
x86_setup_mtrrs();
x86_mtrr_check();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
}

View File

@ -18,7 +18,7 @@ static void model_69x_init(struct device *dev)
/* Update the microcode */
intel_update_microcode_from_cbfs();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
};

View File

@ -44,7 +44,7 @@ static void model_6bx_init(struct device *cpu)
x86_setup_mtrrs();
x86_mtrr_check();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
}

View File

@ -31,7 +31,7 @@ static void model_6dx_init(struct device *dev)
/* Update the microcode */
intel_update_microcode_from_cbfs();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
};

View File

@ -154,7 +154,7 @@ static void model_6ex_init(struct device *cpu)
x86_setup_mtrrs();
x86_mtrr_check();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
/* Enable virtualization */

View File

@ -177,7 +177,7 @@ static void model_6fx_init(struct device *cpu)
/* Setup Page Attribute Tables (PAT) */
// TODO set up PAT
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
/* Enable virtualization */

View File

@ -31,7 +31,7 @@ static void model_6xx_init(struct device *dev)
/* Update the microcode */
intel_update_microcode_from_cbfs();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
};

View File

@ -31,7 +31,7 @@ static void model_f0x_init(struct device *dev)
/* Update the microcode */
intel_update_microcode_from_cbfs();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
};

View File

@ -31,7 +31,7 @@ static void model_f1x_init(struct device *dev)
/* Update the microcode */
intel_update_microcode_from_cbfs();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
};

View File

@ -36,7 +36,7 @@ static void model_f2x_init(struct device *cpu)
intel_update_microcode_from_cbfs();
}
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
/* Start up my CPU siblings */

View File

@ -36,7 +36,7 @@ static void model_f3x_init(struct device *cpu)
intel_update_microcode_from_cbfs();
}
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
/* Start up my CPU siblings */

View File

@ -36,7 +36,7 @@ static void model_f4x_init(struct device *cpu)
intel_update_microcode_from_cbfs();
}
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
/* Start up my CPU siblings */

View File

@ -110,7 +110,7 @@ static void speedstep_get_limits(sst_params_t *const params)
* @brief Generate full p-states table from processor parameters
*
* This is generic code and should work at least for Merom and Penryn
* processors. It is used to generate acpi tables and configure EMTTM.
* processors. It is used to generate ACPI tables and configure EMTTM.
*/
void speedstep_gen_pstates(sst_table_t *const table)
{

View File

@ -27,7 +27,7 @@ static void c3_init(struct device *dev)
x86_setup_mtrrs();
x86_mtrr_check();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
};

View File

@ -200,7 +200,7 @@ static void c7_init(struct device *dev)
x86_setup_mtrrs();
x86_mtrr_check();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
};

View File

@ -180,7 +180,7 @@ static void nano_init(struct device *dev)
/* Set up Memory Type Range Registers */
x86_setup_mtrrs();
x86_mtrr_check();
/* Enable the local CPU apics */
/* Enable the local CPU APICs */
setup_lapic();
}

View File

@ -79,7 +79,7 @@ _start16bit:
*
* The criteria for relocation have been relaxed to their
* utmost, so that we can use the same code for both
* our initial entry point and startup of the second cpu.
* our initial entry point and startup of the second CPU.
* The code assumes when executing at _start16bit that:
* (((cs & 0xfff) == 0) and (ip == _start16bit & 0xffff))
* or

View File

@ -25,7 +25,7 @@ config LAPIC_MONOTONIC_TIMER
depends on UDELAY_LAPIC
select HAVE_MONOTONIC_TIMER
help
Expose monotonic time using the local apic.
Expose monotonic time using the local APIC.
config UDELAY_LAPIC_FIXED_FSB
int

View File

@ -83,7 +83,7 @@ static inline u32 get_timer_fsb(void)
void init_timer(void)
{
/* Set the apic timer to no interrupts and periodic mode */
/* Set the APIC timer to no interrupts and periodic mode */
lapic_write(LAPIC_LVTT, (LAPIC_LVT_TIMER_PERIODIC | LAPIC_LVT_MASKED));
/* Set the divider to 1, no divider */

View File

@ -17,9 +17,9 @@ void setup_lapic(void)
/* Only Pentium Pro and later have those MSR stuff */
msr_t msr;
printk(BIOS_INFO, "Setting up local apic...");
printk(BIOS_INFO, "Setting up local APIC...");
/* Enable the local apic */
/* Enable the local APIC */
msr = rdmsr(LAPIC_BASE_MSR);
msr.lo |= LAPIC_BASE_MSR_ENABLE;
msr.lo &= ~LAPIC_BASE_MSR_ADDR_MASK;
@ -32,7 +32,7 @@ void setup_lapic(void)
lapic_write_around(LAPIC_TASKPRI,
lapic_read_around(LAPIC_TASKPRI) & ~LAPIC_TPRI_MASK);
/* Put the local apic in virtual wire mode */
/* Put the local APIC in virtual wire mode */
lapic_write_around(LAPIC_SPIV,
(lapic_read_around(LAPIC_SPIV) & ~(LAPIC_VECTOR_MASK))
| LAPIC_SPIV_ENABLE);
@ -61,7 +61,7 @@ void setup_lapic(void)
/* Only Pentium Pro and later have those MSR stuff */
msr_t msr;
printk(BIOS_INFO, "Disabling local apic...");
printk(BIOS_INFO, "Disabling local APIC...");
msr = rdmsr(LAPIC_BASE_MSR);
msr.lo &= ~LAPIC_BASE_MSR_ENABLE;

View File

@ -165,7 +165,7 @@ static int lapic_start_cpu(unsigned long apicid)
send_status = lapic_read(LAPIC_ICR) & LAPIC_ICR_BUSY;
} while (send_status && (timeout++ < 1000));
if (timeout >= 1000) {
printk(BIOS_ERR, "CPU %ld: Second apic write timed out. "
printk(BIOS_ERR, "CPU %ld: Second APIC write timed out. "
"Disabling\n", apicid);
// too bad.
return 0;
@ -546,7 +546,7 @@ void initialize_cpus(struct bus *cpu_bus)
info = cpu_info();
#if NEED_LAPIC == 1
/* Ensure the local apic is enabled */
/* Ensure the local APIC is enabled */
enable_lapic();
/* Get the device path of the boot CPU */

View File

@ -81,7 +81,7 @@ struct mp_params {
int num_cpus; /* Total cpus include BSP */
int parallel_microcode_load;
const void *microcode_pointer;
/* adjust_apic_id() is called for every potential apic id in the
/* adjust_apic_id() is called for every potential APIC id in the
* system up from 0 to CONFIG_MAX_CPUS. Return adjusted apic_id. */
int (*adjust_apic_id)(int index, int apic_id);
/* Flight plan for APs and BSP. */
@ -134,7 +134,7 @@ struct cpu_map {
int apic_id;
};
/* Keep track of apic and device structure for each cpu. */
/* Keep track of APIC and device structure for each CPU. */
static struct cpu_map cpus[CONFIG_MAX_CPUS];
static inline void barrier_wait(atomic_t *b)
@ -192,7 +192,7 @@ static void asmlinkage ap_init(unsigned int cpu)
struct cpu_info *info;
int apic_id;
/* Ensure the local apic is enabled */
/* Ensure the local APIC is enabled */
enable_lapic();
info = cpu_info();
@ -546,14 +546,14 @@ static void init_bsp(struct bus *cpu_bus)
fill_processor_name(processor_name);
printk(BIOS_INFO, "CPU: %s.\n", processor_name);
/* Ensure the local apic is enabled */
/* Ensure the local APIC is enabled */
enable_lapic();
/* Set the device path of the boot cpu. */
/* Set the device path of the boot CPU. */
cpu_path.type = DEVICE_PATH_APIC;
cpu_path.apic.apic_id = lapicid();
/* Find the device structure for the boot cpu. */
/* Find the device structure for the boot CPU. */
info = cpu_info();
info->cpu = alloc_find_dev(cpu_bus, &cpu_path);
@ -641,7 +641,7 @@ static void mp_initialize_cpu(void)
cpu_initialize(info->index);
}
/* Returns apic id for coreboot CPU number or < 0 on failure. */
/* Returns APIC id for coreboot CPU number or < 0 on failure. */
static int mp_get_apic_id(int cpu_slot)
{
if (cpu_slot >= CONFIG_MAX_CPUS || cpu_slot < 0)

View File

@ -41,7 +41,7 @@ struct smm_stub_params {
/*
* The stub is the entry point that sets up protected mode and stacks for each
* cpu. It then calls into the SMM handler module. It is encoded as an rmodule.
* CPU. It then calls into the SMM handler module. It is encoded as an rmodule.
*/
extern unsigned char _binary_smmstub_start[];

View File

@ -125,7 +125,7 @@ smm_relocate:
shr $24, %ecx
/* calculate offset by multiplying the
* apic ID by 1024 (0x400)
* APIC ID by 1024 (0x400)
*/
movl %ecx, %edx
shl $10, %edx