GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel/gma: Use bitwise or instead addition for valid bit 

Page table entries bit 0 is used as "valid". Its value should be set
by a bitwise OR and not by an addition.

Signed-off-by: Petr Cvek <petrcvekcz@gmail.com>
Change-Id: I14467081c8279af4611007a25aefab606c61a058
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65172
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Petr Cvek 2022-06-16 15:17:50 +02:00 committed by Felix Held
parent 3b0303dbe8
commit d6fb425ca6
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/northbridge/intel/i945/gma.c
View File

@ -343,7 +343,7 @@ static int intel_gma_init_lvds(struct northbridge_intel_i945_config *conf,
for (i = 0; i < (uma_size - 256) / 4; i++) {
outl((i << 2) | 1, piobase);
outl(pphysbase + (i << 12) + 1, piobase + 4);
outl((pphysbase + (i << 12)) | 1, piobase + 4);
}
temp = read32(mmiobase + PGETBL_CTL);
@ -521,7 +521,7 @@ static int intel_gma_init_vga(struct northbridge_intel_i945_config *conf,
for (i = 0; i < (uma_size - 256) / 4; i++) {
outl((i << 2) | 1, piobase);
outl(pphysbase + (i << 12) + 1, piobase + 4);
outl((pphysbase + (i << 12)) | 1, piobase + 4);
}
/* Clear interrupts. */

2
src/northbridge/intel/pineview/gma.c
View File

@ -196,7 +196,7 @@ static void intel_gma_init(const struct northbridge_intel_pineview_config *info,
for (i = 0; i < (8192 - 512) / 4; i++) {
outl((i << 2) | 1, piobase);
outl(physbase + (i << 12) + 1, piobase + 4);
outl((physbase + (i << 12)) | 1, piobase + 4);
}
temp = read32(mmio + PGETBL_CTL);