mb/emulation/qemu-i440fx|q35: Fix stack size

Current implementation works by luck as DCACHE area is actually RAM and
stack can grow and use that RAM outside of the area.

* Set DCACHE_BSP_STACK_SIZE to 0x4000.
* Add an assert to make sure it is set to a sane value on all platforms.

Change-Id: I71f9d74d89e4129cdc4a850acc4fc1ac90e5f628
Signed-off-by: Patrick Rudolph <siro@das-labor.org>
Reviewed-on: https://review.coreboot.org/29611
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Patrick Rudolph 2018-11-12 19:26:54 +01:00
parent c10fb3b9a2
commit d72d52a7e4
3 changed files with 11 additions and 0 deletions

View File

@ -113,3 +113,6 @@ _bogus = ASSERT((CONFIG_DCACHE_RAM_SIZE == 0) || (SIZEOF(.car.data) <= CONFIG_DC
#if IS_ENABLED(CONFIG_PAGING_IN_CACHE_AS_RAM)
_bogus2 = ASSERT(_pagetables == ALIGN(_pagetables, 4096), "_pagetables aren't 4KiB aligned");
#endif
#if IS_ENABLED(CONFIG_C_ENVIRONMENT_BOOTBLOCK)
_bogus3 = ASSERT(CONFIG_DCACHE_BSP_STACK_SIZE > 0x0, "BSP stack size not configured");
#endif

View File

@ -41,4 +41,8 @@ config C_ENV_BOOTBLOCK_SIZE
hex
default 0x4000
config DCACHE_BSP_STACK_SIZE
hex
default 0x4000
endif # BOARD_EMULATION_QEMU_X86_I440FX

View File

@ -49,4 +49,8 @@ config C_ENV_BOOTBLOCK_SIZE
hex
default 0x4000
config DCACHE_BSP_STACK_SIZE
hex
default 0x4000
endif # BOARD_EMULATION_QEMU_X86_Q35