GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

vendorcode/agesa: Fix check for valid PhyLane 

Found using GCC with flag -Wlogical-op

Change-Id: Ia04ac5b1d0a4434c0ab2ca583b9b03dbfd0ffd41
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33362
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Elyes HAOUAS 2019-06-10 13:47:56 +02:00 committed by Nico Huber
parent e94335e9fd
commit d844431af0
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/vendorcode/amd/agesa/f12/Proc/GNB/Modules/GnbPcieConfig/PcieConfigLib.c
View File

@ -202,7 +202,7 @@ PcieConfigGetNumberOfPhyLane (
IN PCIe_ENGINE_CONFIG *Engine
)
{
if (Engine->EngineData.StartLane >= UNUSED_LANE_ID || Engine->EngineData.StartLane >= UNUSED_LANE_ID) {
if (Engine->EngineData.StartLane >= UNUSED_LANE_ID || Engine->EngineData.EndLane >= UNUSED_LANE_ID) {
return 0;
}
if (Engine->EngineData.StartLane > Engine->EngineData.EndLane) {

2
src/vendorcode/amd/agesa/f14/Proc/GNB/Modules/GnbPcieConfig/PcieConfigLib.c
View File

@ -178,7 +178,7 @@ PcieConfigGetNumberOfPhyLane (
IN PCIe_ENGINE_CONFIG *Engine
)
{
if (Engine->EngineData.StartLane >= UNUSED_LANE_ID || Engine->EngineData.StartLane >= UNUSED_LANE_ID) {
if (Engine->EngineData.StartLane >= UNUSED_LANE_ID || Engine->EngineData.EndLane >= UNUSED_LANE_ID) {
return 0;
}
if (Engine->EngineData.StartLane > Engine->EngineData.EndLane) {

2
src/vendorcode/amd/agesa/f15tn/Proc/GNB/Modules/GnbPcieConfig/PcieConfigLib.c
View File

@ -205,7 +205,7 @@ PcieConfigGetNumberOfPhyLane (
IN PCIe_ENGINE_CONFIG *Engine
)
{
if (Engine->EngineData.StartLane >= UNUSED_LANE_ID || Engine->EngineData.StartLane >= UNUSED_LANE_ID) {
if (Engine->EngineData.StartLane >= UNUSED_LANE_ID || Engine->EngineData.EndLane >= UNUSED_LANE_ID) {
return 0;
}
if (Engine->EngineData.StartLane > Engine->EngineData.EndLane) {

2
src/vendorcode/amd/agesa/f16kb/Proc/GNB/Modules/GnbPcieConfig/PcieConfigLib.c
View File

@ -205,7 +205,7 @@ PcieConfigGetNumberOfPhyLane (
IN PCIe_ENGINE_CONFIG *Engine
)
{
if (Engine->EngineData.StartLane >= UNUSED_LANE_ID || Engine->EngineData.StartLane >= UNUSED_LANE_ID) {
if (Engine->EngineData.StartLane >= UNUSED_LANE_ID || Engine->EngineData.EndLane >= UNUSED_LANE_ID) {
return 0;
}
if (Engine->EngineData.StartLane > Engine->EngineData.EndLane) {