i82801gx: replace cafed00d/cafebabe by defines
We're using '0xcafed00d' all over the code as magic for ACPI S3 resume. Let's add a define for that. Also replace 0xcafebabe by a define. Change-Id: I5f5dc09561679d19f98771c4f81830a50202c69f Signed-off-by: Sven Schnelle <svens@stackframe.org> Reviewed-on: http://review.coreboot.org/33 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
This commit is contained in:
parent
5eef65bbbf
commit
d8c68a9d08
|
@ -378,7 +378,7 @@ void main(unsigned long bist)
|
||||||
memcpy(resume_backup_memory, (void *)CONFIG_RAMBASE, HIGH_MEMORY_SAVE);
|
memcpy(resume_backup_memory, (void *)CONFIG_RAMBASE, HIGH_MEMORY_SAVE);
|
||||||
|
|
||||||
/* Magic for S3 resume */
|
/* Magic for S3 resume */
|
||||||
pci_write_config32(PCI_DEV(0, 0x00, 0), SKPAD, 0xcafed00d);
|
pci_write_config32(PCI_DEV(0, 0x00, 0), SKPAD, SKPAD_ACPI_S3_MAGIC);
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
}
|
}
|
||||||
|
|
|
@ -332,7 +332,7 @@ void main(unsigned long bist)
|
||||||
memcpy(resume_backup_memory, (void *)CONFIG_RAMBASE, HIGH_MEMORY_SAVE);
|
memcpy(resume_backup_memory, (void *)CONFIG_RAMBASE, HIGH_MEMORY_SAVE);
|
||||||
|
|
||||||
/* Magic for S3 resume */
|
/* Magic for S3 resume */
|
||||||
pci_write_config32(PCI_DEV(0, 0x00, 0), SKPAD, 0xcafed00d);
|
pci_write_config32(PCI_DEV(0, 0x00, 0), SKPAD, SKPAD_ACPI_S3_MAGIC);
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
}
|
}
|
||||||
|
|
|
@ -290,7 +290,7 @@ void main(unsigned long bist)
|
||||||
memcpy(resume_backup_memory, (void *)CONFIG_RAMBASE, HIGH_MEMORY_SAVE);
|
memcpy(resume_backup_memory, (void *)CONFIG_RAMBASE, HIGH_MEMORY_SAVE);
|
||||||
|
|
||||||
/* Magic for S3 resume */
|
/* Magic for S3 resume */
|
||||||
pci_write_config32(PCI_DEV(0, 0x00, 0), SKPAD, 0xcafed00d);
|
pci_write_config32(PCI_DEV(0, 0x00, 0), SKPAD, SKPAD_ACPI_S3_MAGIC);
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
}
|
}
|
||||||
|
|
|
@ -431,7 +431,7 @@ void main(unsigned long bist)
|
||||||
memcpy(resume_backup_memory, (void *)CONFIG_RAMBASE, HIGH_MEMORY_SAVE);
|
memcpy(resume_backup_memory, (void *)CONFIG_RAMBASE, HIGH_MEMORY_SAVE);
|
||||||
|
|
||||||
/* Magic for S3 resume */
|
/* Magic for S3 resume */
|
||||||
pci_write_config32(PCI_DEV(0, 0x00, 0), SKPAD, 0xcafed00d);
|
pci_write_config32(PCI_DEV(0, 0x00, 0), SKPAD, SKPAD_ACPI_S3_MAGIC);
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
}
|
}
|
||||||
|
|
|
@ -46,7 +46,7 @@ static void mainboard_enable(device_t dev)
|
||||||
|
|
||||||
/* If we're resuming from suspend, blink suspend LED */
|
/* If we're resuming from suspend, blink suspend LED */
|
||||||
dev0 = dev_find_slot(0, PCI_DEVFN(0,0));
|
dev0 = dev_find_slot(0, PCI_DEVFN(0,0));
|
||||||
if (dev0 && pci_read_config32(dev0, SKPAD) == 0xcafed00d)
|
if (dev0 && pci_read_config32(dev0, SKPAD) == SKPAD_ACPI_S3_MAGIC)
|
||||||
ec_write(0x0c, 0xc7);
|
ec_write(0x0c, 0xc7);
|
||||||
|
|
||||||
idedev = dev_find_slot(0, PCI_DEVFN(0x1f,1));
|
idedev = dev_find_slot(0, PCI_DEVFN(0x1f,1));
|
||||||
|
|
|
@ -333,7 +333,7 @@ void main(unsigned long bist)
|
||||||
memcpy(resume_backup_memory, (void *)CONFIG_RAMBASE, HIGH_MEMORY_SAVE);
|
memcpy(resume_backup_memory, (void *)CONFIG_RAMBASE, HIGH_MEMORY_SAVE);
|
||||||
|
|
||||||
/* Magic for S3 resume */
|
/* Magic for S3 resume */
|
||||||
pci_write_config32(PCI_DEV(0, 0x00, 0), SKPAD, 0xcafed00d);
|
pci_write_config32(PCI_DEV(0, 0x00, 0), SKPAD, SKPAD_ACPI_S3_MAGIC);
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
/* Set legacy Brightness control to full brightness */
|
/* Set legacy Brightness control to full brightness */
|
||||||
|
|
|
@ -47,7 +47,7 @@ static void mainboard_enable(device_t dev)
|
||||||
|
|
||||||
/* If we're resuming from suspend, blink suspend LED */
|
/* If we're resuming from suspend, blink suspend LED */
|
||||||
dev0 = dev_find_slot(0, PCI_DEVFN(0,0));
|
dev0 = dev_find_slot(0, PCI_DEVFN(0,0));
|
||||||
if (dev0 && pci_read_config32(dev0, SKPAD) == 0xcafed00d)
|
if (dev0 && pci_read_config32(dev0, SKPAD) == SKPAD_ACPI_S3_MAGIC)
|
||||||
ec_write(0x0c, 0xc7);
|
ec_write(0x0c, 0xc7);
|
||||||
|
|
||||||
idedev = dev_find_slot(0, PCI_DEVFN(0x1f,1));
|
idedev = dev_find_slot(0, PCI_DEVFN(0x1f,1));
|
||||||
|
|
|
@ -335,7 +335,7 @@ void main(unsigned long bist)
|
||||||
memcpy(resume_backup_memory, (void *)CONFIG_RAMBASE, HIGH_MEMORY_SAVE);
|
memcpy(resume_backup_memory, (void *)CONFIG_RAMBASE, HIGH_MEMORY_SAVE);
|
||||||
|
|
||||||
/* Magic for S3 resume */
|
/* Magic for S3 resume */
|
||||||
pci_write_config32(PCI_DEV(0, 0x00, 0), SKPAD, 0xcafed00d);
|
pci_write_config32(PCI_DEV(0, 0x00, 0), SKPAD, SKPAD_ACPI_S3_MAGIC);
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
/* Set legacy Brightness control to full brightness */
|
/* Set legacy Brightness control to full brightness */
|
||||||
|
|
|
@ -367,7 +367,7 @@ void main(unsigned long bist)
|
||||||
memcpy(resume_backup_memory, (void *)CONFIG_RAMBASE, HIGH_MEMORY_SAVE);
|
memcpy(resume_backup_memory, (void *)CONFIG_RAMBASE, HIGH_MEMORY_SAVE);
|
||||||
|
|
||||||
/* Magic for S3 resume */
|
/* Magic for S3 resume */
|
||||||
pci_write_config32(PCI_DEV(0, 0x00, 0), SKPAD, 0xcafed00d);
|
pci_write_config32(PCI_DEV(0, 0x00, 0), SKPAD, SKPAD_ACPI_S3_MAGIC);
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
}
|
}
|
||||||
|
|
|
@ -186,7 +186,7 @@ static void i945_setup_bars(void)
|
||||||
pci_write_config8(PCI_DEV(0, 0x00, 0), PAM5, 0x33);
|
pci_write_config8(PCI_DEV(0, 0x00, 0), PAM5, 0x33);
|
||||||
pci_write_config8(PCI_DEV(0, 0x00, 0), PAM6, 0x33);
|
pci_write_config8(PCI_DEV(0, 0x00, 0), PAM6, 0x33);
|
||||||
|
|
||||||
pci_write_config32(PCI_DEV(0, 0x00, 0), SKPAD, 0xcafebabe);
|
pci_write_config32(PCI_DEV(0, 0x00, 0), SKPAD, SKPAD_NORMAL_BOOT_MAGIC);
|
||||||
printk(BIOS_DEBUG, " done.\n");
|
printk(BIOS_DEBUG, " done.\n");
|
||||||
|
|
||||||
/* Wait for MCH BAR to come up */
|
/* Wait for MCH BAR to come up */
|
||||||
|
|
|
@ -257,11 +257,11 @@ extern u8 acpi_slp_type;
|
||||||
static void northbridge_init(struct device *dev)
|
static void northbridge_init(struct device *dev)
|
||||||
{
|
{
|
||||||
switch (pci_read_config32(dev, SKPAD)) {
|
switch (pci_read_config32(dev, SKPAD)) {
|
||||||
case 0xcafebabe:
|
case SKPAD_NORMAL_BOOT_MAGIC:
|
||||||
printk(BIOS_DEBUG, "Normal boot.\n");
|
printk(BIOS_DEBUG, "Normal boot.\n");
|
||||||
acpi_slp_type=0;
|
acpi_slp_type=0;
|
||||||
break;
|
break;
|
||||||
case 0xcafed00d:
|
case SKPAD_ACPI_S3_MAGIC:
|
||||||
printk(BIOS_DEBUG, "S3 Resume.\n");
|
printk(BIOS_DEBUG, "S3 Resume.\n");
|
||||||
acpi_slp_type=3;
|
acpi_slp_type=3;
|
||||||
break;
|
break;
|
||||||
|
|
|
@ -365,5 +365,7 @@ void enable_usbdebug(unsigned int port);
|
||||||
#define SS_CNT 0x50
|
#define SS_CNT 0x50
|
||||||
#define C3_RES 0x54
|
#define C3_RES 0x54
|
||||||
|
|
||||||
|
#define SKPAD_ACPI_S3_MAGIC 0xcafed00d
|
||||||
|
#define SKPAD_NORMAL_BOOT_MAGIC 0xcafebabe
|
||||||
#endif /* __ACPI__ */
|
#endif /* __ACPI__ */
|
||||||
#endif /* SOUTHBRIDGE_INTEL_I82801GX_I82801GX_H */
|
#endif /* SOUTHBRIDGE_INTEL_I82801GX_I82801GX_H */
|
||||||
|
|
Loading…
Reference in New Issue