libpayload: make log2 and clz work on signed values internally
Needed to make libpayload build clean with -Wconversion. BUG=b:111443775 BRANCH=none TEST=make junit.xml shows fewer warnings with -Wconversion enabled Change-Id: Ie193e39854d2231b6d09a2b0deeeef2873e900ab Signed-off-by: Patrick Georgi <pgeorgi@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/32184 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Jacob Garber <jgarber1@ualberta.ca> Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit is contained in:
parent
bc674765a9
commit
d8cd2e9c37
|
@ -434,9 +434,12 @@ void hexdump(const void *memory, size_t length);
|
||||||
void fatal(const char *msg) __attribute__((noreturn));
|
void fatal(const char *msg) __attribute__((noreturn));
|
||||||
|
|
||||||
/* Count Leading Zeroes: clz(0) == 32, clz(0xf) == 28, clz(1 << 31) == 0 */
|
/* Count Leading Zeroes: clz(0) == 32, clz(0xf) == 28, clz(1 << 31) == 0 */
|
||||||
static inline int clz(u32 x) { return x ? __builtin_clz(x) : sizeof(x) * 8; }
|
static inline int clz(u32 x)
|
||||||
|
{
|
||||||
|
return x ? __builtin_clz(x) : (int)sizeof(x) * 8;
|
||||||
|
}
|
||||||
/* Integer binary logarithm (rounding down): log2(0) == -1, log2(5) == 2 */
|
/* Integer binary logarithm (rounding down): log2(0) == -1, log2(5) == 2 */
|
||||||
static inline int log2(u32 x) { return sizeof(x) * 8 - clz(x) - 1; }
|
static inline int log2(u32 x) { return (int)sizeof(x) * 8 - clz(x) - 1; }
|
||||||
/* Find First Set: __ffs(0xf) == 0, __ffs(0) == -1, __ffs(1 << 31) == 31 */
|
/* Find First Set: __ffs(0xf) == 0, __ffs(0) == -1, __ffs(1 << 31) == 31 */
|
||||||
static inline int __ffs(u32 x) { return log2(x & (u32)(-(s32)x)); }
|
static inline int __ffs(u32 x) { return log2(x & (u32)(-(s32)x)); }
|
||||||
/** @} */
|
/** @} */
|
||||||
|
|
Loading…
Reference in New Issue