GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

northbridge/amd/agesa: DEVICE_NOOP some stub functions 

Use 'DEVICE_NOOP' over stub functions to reduce loc and
improve formalism.

Change-Id: I9c8d608539647cce22fb1dfbe284a6043d3d23d9
Signed-off-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
Reviewed-on: http://review.coreboot.org/7534
Tested-by: build bot (Jenkins)
Reviewed-by: Bruce Griffith <Bruce.Griffith@se-eng.com>
This commit is contained in:
Edward O'Callaghan 2014-11-21 02:22:33 +11:00
parent 023ed1f999
commit d994ef1932
3 changed files with 3 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/northbridge/amd/agesa/family15/northbridge.c
View File

@ -472,10 +472,6 @@ static void nb_set_resources(device_t dev)
} }
} }
static void northbridge_init(struct device *dev)
{
}
static unsigned scan_chains(device_t dev, unsigned max) static unsigned scan_chains(device_t dev, unsigned max)
{ {
unsigned nodeid; unsigned nodeid;
@ -503,7 +499,7 @@ static struct device_operations northbridge_operations = {
.read_resources = nb_read_resources, .read_resources = nb_read_resources,
.set_resources = nb_set_resources, .set_resources = nb_set_resources,
.enable_resources = pci_dev_enable_resources, .enable_resources = pci_dev_enable_resources,
.init = northbridge_init, .init = DEVICE_NOOP,
.scan_bus = scan_chains, .scan_bus = scan_chains,
.enable = 0, .enable = 0,
.ops_pci = 0, .ops_pci = 0,

7
src/northbridge/amd/agesa/family15tn/northbridge.c
View File

@ -463,16 +463,11 @@ static void nb_set_resources(device_t dev)
} }
} }
static void northbridge_init(struct device *dev)
{
}
static struct device_operations northbridge_operations = { static struct device_operations northbridge_operations = {
.read_resources = nb_read_resources, .read_resources = nb_read_resources,
.set_resources = nb_set_resources, .set_resources = nb_set_resources,
.enable_resources = pci_dev_enable_resources, .enable_resources = pci_dev_enable_resources,
.init = northbridge_init, .init = DEVICE_NOOP,
.enable = 0, .enable = 0,
.ops_pci = 0, .ops_pci = 0,
}; };

5
src/northbridge/amd/agesa/family16kb/northbridge.c
View File

@ -444,9 +444,6 @@ static void set_resources(device_t dev)
} }
} }
static void northbridge_init(struct device *dev)
{
}
#if 0 /* TODO: Check if needed. */ #if 0 /* TODO: Check if needed. */
static unsigned scan_chains(device_t dev, unsigned max) static unsigned scan_chains(device_t dev, unsigned max)
{ {
@ -475,7 +472,7 @@ static struct device_operations northbridge_operations = {
.read_resources = read_resources, .read_resources = read_resources,
.set_resources = set_resources, .set_resources = set_resources,
.enable_resources = pci_dev_enable_resources, .enable_resources = pci_dev_enable_resources,
.init = northbridge_init, .init = DEVICE_NOOP,
//.scan_bus = scan_chains, /* TODO: */ //.scan_bus = scan_chains, /* TODO: */
.enable = 0, .enable = 0,
.ops_pci = 0, .ops_pci = 0,