From d9bac169ba0e3c0f9f7a4fa50c01e6791c1551fe Mon Sep 17 00:00:00 2001 From: Eric Lai Date: Mon, 23 Aug 2021 12:07:36 +0800 Subject: [PATCH] mb/google/brya/var/felwinter: Generate RAM ID and SPD file Add the support RAM parts for felwinter. Here is the ram part number list: DRAM Part Name ID to assign K4U6E3S4AA-MGCR 0 (0000) K4UBE3D4AA-MGCR 1 (0001) H9HCNNNBKMMLXR-NEE 0 (0000) MT53E1G32D2NP-046 WT:A 2 (0010) BUG=b:197308861 BRANCH=None TEST=emerge-brya coreboot Signed-off-by: Eric Lai Change-Id: I76febefc251b02a047819242e23c02dc50891c2f Reviewed-on: https://review.coreboot.org/c/coreboot/+/57086 Tested-by: build bot (Jenkins) Reviewed-by: Tim Wawrzynczak --- .../brya/variants/felwinter/memory/Makefile.inc | 6 ++++-- .../felwinter/memory/dram_id.generated.txt | 4 ++++ .../variants/felwinter/memory/mem_parts_used.txt | 15 ++++----------- 3 files changed, 12 insertions(+), 13 deletions(-) diff --git a/src/mainboard/google/brya/variants/felwinter/memory/Makefile.inc b/src/mainboard/google/brya/variants/felwinter/memory/Makefile.inc index b0ca2223a8..7ab11657fd 100644 --- a/src/mainboard/google/brya/variants/felwinter/memory/Makefile.inc +++ b/src/mainboard/google/brya/variants/felwinter/memory/Makefile.inc @@ -1,5 +1,7 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ## This is an auto-generated file. Do not edit!! -## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. -SPD_SOURCES = placeholder.spd.hex +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = K4U6E3S4AA-MGCR, H9HCNNNBKMMLXR-NEE +SPD_SOURCES += lp4x-spd-3.hex # ID = 1(0b0001) Parts = K4UBE3D4AA-MGCR +SPD_SOURCES += lp4x-spd-4.hex # ID = 2(0b0010) Parts = MT53E1G32D2NP-046 WT:A diff --git a/src/mainboard/google/brya/variants/felwinter/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/felwinter/memory/dram_id.generated.txt index fa247902ee..5d40ee6b50 100644 --- a/src/mainboard/google/brya/variants/felwinter/memory/dram_id.generated.txt +++ b/src/mainboard/google/brya/variants/felwinter/memory/dram_id.generated.txt @@ -1 +1,5 @@ DRAM Part Name ID to assign +K4U6E3S4AA-MGCR 0 (0000) +K4UBE3D4AA-MGCR 1 (0001) +H9HCNNNBKMMLXR-NEE 0 (0000) +MT53E1G32D2NP-046 WT:A 2 (0010) diff --git a/src/mainboard/google/brya/variants/felwinter/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/felwinter/memory/mem_parts_used.txt index 9cff262f6d..89792ed712 100644 --- a/src/mainboard/google/brya/variants/felwinter/memory/mem_parts_used.txt +++ b/src/mainboard/google/brya/variants/felwinter/memory/mem_parts_used.txt @@ -1,11 +1,4 @@ -# This is a CSV file containing a list of memory parts used by this variant. -# One part per line with an optional fixed ID in column 2. -# Only include a fixed ID if it is required for legacy reasons! -# Generated IDs are dependent on the order of parts in this file, -# so new parts must always be added at the end of the file! -# -# Generate an updated Makefile.inc and dram_id.generated.txt by running the -# gen_part_id tool from util/spd_tools/lp4x. -# See util/spd_tools/lp4x/README.md for more details and instructions. - -# Part Name +K4U6E3S4AA-MGCR +K4UBE3D4AA-MGCR +H9HCNNNBKMMLXR-NEE +MT53E1G32D2NP-046 WT:A