From da3ef13d27809bc004e01a21c9d8bbc7445ba499 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Mon, 6 Sep 2021 23:59:11 +0200 Subject: [PATCH] ec/acpi: Remove empty "chip" driver There was no code attached to this driver and hence one couldn't hook it up to any device. Even if mentioned in the `devicetree.cb` it was still dead code. Change-Id: I12415ea9e0120b1d00524f8f39f9b2d02f46ba05 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/coreboot/+/57431 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/ec/acpi/ec.c | 4 ---- src/mainboard/getac/p470/devicetree.cb | 2 -- src/mainboard/roda/rk886ex/devicetree.cb | 3 --- 3 files changed, 9 deletions(-) diff --git a/src/ec/acpi/ec.c b/src/ec/acpi/ec.c index a60de27ac5..5d6fb189fb 100644 --- a/src/ec/acpi/ec.c +++ b/src/ec/acpi/ec.c @@ -148,7 +148,3 @@ void ec_set_ports(u16 cmd_reg, u16 data_reg) ec_cmd_reg = cmd_reg; ec_data_reg = data_reg; } - -struct chip_operations ec_acpi_ops = { - CHIP_NAME("ACPI Embedded Controller") -}; diff --git a/src/mainboard/getac/p470/devicetree.cb b/src/mainboard/getac/p470/devicetree.cb index 94ffd1964f..9a91b81ee7 100644 --- a/src/mainboard/getac/p470/devicetree.cb +++ b/src/mainboard/getac/p470/devicetree.cb @@ -123,8 +123,6 @@ chip northbridge/intel/i945 end device pnp 4e.b off # HWM end - chip ec/acpi - end end end diff --git a/src/mainboard/roda/rk886ex/devicetree.cb b/src/mainboard/roda/rk886ex/devicetree.cb index b19b7af62e..6b9dbd9126 100644 --- a/src/mainboard/roda/rk886ex/devicetree.cb +++ b/src/mainboard/roda/rk886ex/devicetree.cb @@ -99,9 +99,6 @@ chip northbridge/intel/i945 device pnp ff.1 on # dummy address end end - chip ec/acpi - end - end device pci 1f.1 off end # IDE device pci 1f.2 on end # SATA