GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

console/Kconfig: Fix dependency of FIXED_UART_FOR_CONSOLE 

The Kconfig declaration for FIXED_UART_FOR_CONSOLE was accidentally
placed inside an `if CONSOLE_SERIAL` in a96e66a (soc/intel: Clean mess
around UART_DEBUG).

TEST=Start a clean config, select intel/leafhill and disable serial
console. Confirm that config can be saved without error.

Change-Id: Ie41687e91af11a13697cbe25938dada2c74b40fb
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/30829
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
This commit is contained in:
Nico Huber 2019-01-11 10:38:02 +01:00 committed by Patrick Georgi
parent 804adaa1f1
commit da8c12b54f
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/console/Kconfig
View File

@ -37,6 +37,13 @@ config CONSOLE_SERIAL
shown on the following menu line. Supporting multiple different types shown on the following menu line. Supporting multiple different types
of UARTs in one build is not supported. of UARTs in one build is not supported.
config FIXED_UART_FOR_CONSOLE
bool
help
Select to remove the prompt from UART_FOR_CONSOLE in case a
specific UART has to be used (e.g. when the platform code
performs dangerous configurations).
if CONSOLE_SERIAL if CONSOLE_SERIAL
comment "I/O mapped, 8250-compatible" comment "I/O mapped, 8250-compatible"
@ -48,13 +55,6 @@ if CONSOLE_SERIAL
comment "device-specific UART" comment "device-specific UART"
depends on HAVE_UART_SPECIAL depends on HAVE_UART_SPECIAL
config FIXED_UART_FOR_CONSOLE
bool
help
Select to remove the prompt from UART_FOR_CONSOLE in case a
specific UART has to be used (e.g. when the platform code
performs dangerous configurations).
config UART_FOR_CONSOLE config UART_FOR_CONSOLE
int int
prompt "Index for UART port to use for console" if !FIXED_UART_FOR_CONSOLE prompt "Index for UART port to use for console" if !FIXED_UART_FOR_CONSOLE