GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/volteer: Add SoundWire codecs to volteer variant 

Enable drivers for SoundWire codecs and define the topology in
the devicetree for the volteer variant with the SoundWire daughter
board connected.

+------------------+         +-------------------+
|                  |         | Headphone Codec   |
|  Intel Tigerlake |    +--->| Realtek ALC5682   |
|     SoundWire    |    |    |       ID 1        |
|     Controller   |    |    +-------------------+
|                  |    |
|           Link 0 +----+    +-------------------+
|                  |         | Left Speaker Amp  |
|           Link 1 +----+--->| Maxim MAX98373    |
|                  |    |    |       ID 3        |
|           Link 2 |    |    +-------------------+
|                  |    |
|           Link 3 |    |    +-------------------+
|                  |    |    | Right Speaker Amp |
+------------------+    +--->| Maxim MAX98373    |
                             |       ID 7        |
                             +-------------------+

This was tested by booting the firmware and dumping the SSDT table
to ensure that all SoundWire ACPI devices are created as expected with
the properties that are defined in coreboot under \_SB.PCI0:

HDAS           - Intel Tigerlake HDA PCI device
HDAS.SNDW      - Intel Tigerlake SoundWire Controller
HDAS.SNDW.SW01 - Realtek ALC5682 - Headphone Codec
HDAS.SNDW.SW13 - Maxim MAX98373  - Left Speaker Amp
HDAS.SNDW.SW17 - Maxim MAX98373  - Right Speaker Amp

BUG=b:146482091

Signed-off-by: Duncan Laurie <dlaurie@google.com>
Change-Id: I7782059807416369e0e1ba0d4d7c79dcab0fcbc5
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40894
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Duncan Laurie 2020-04-29 16:11:45 -07:00 committed by Duncan Laurie
parent 60894a0711
commit da8f5077ff
2 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mainboard/google/volteer/Kconfig
View File

@ -4,7 +4,10 @@ config BOARD_GOOGLE_BASEBOARD_VOLTEER
select DRIVERS_GENERIC_MAX98357A select DRIVERS_GENERIC_MAX98357A
select DRIVERS_I2C_GENERIC select DRIVERS_I2C_GENERIC
select DRIVERS_I2C_HID select DRIVERS_I2C_HID
select DRIVERS_INTEL_SOUNDWIRE
select DRIVERS_SPI_ACPI select DRIVERS_SPI_ACPI
select DRIVERS_SOUNDWIRE_ALC5682
select DRIVERS_SOUNDWIRE_MAX98373
select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC
select EC_GOOGLE_CHROMEEC_BOARDID select EC_GOOGLE_CHROMEEC_BOARDID
select EC_GOOGLE_CHROMEEC_SKUID select EC_GOOGLE_CHROMEEC_SKUID

21
src/mainboard/google/volteer/variants/volteer/overridetree.cb
View File

@ -1,4 +1,25 @@
chip soc/intel/tigerlake chip soc/intel/tigerlake
device domain 0 on device domain 0 on
device pci 1f.3 on
chip drivers/intel/soundwire
device generic 0 on
chip drivers/soundwire/alc5682
# SoundWire Link 0 ID 1
register "desc" = ""Headset Codec""
device generic 0.1 on end
end
chip drivers/soundwire/max98373
# SoundWire Link 1 ID 3
register "desc" = ""Left Speaker Amp""
device generic 1.3 on end
end
chip drivers/soundwire/max98373
# SoundWire Link 1 ID 7
register "desc" = ""Right Speaker Amp""
device generic 1.7 on end
end
end
end
end
end end
end end