GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/fsp/Makefile: drop strip_quotes call in FSP-M size check 

No need to strip the quotes of the FSP-M file path in the size check and
it's always a good idea to not remove the quotes around file paths that
will get passed as parameters to shell programs so that spaces in the
path can't cause malfunction.

TEST=All cases still behave as expected for Mandolin.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Suggested-by: Nico Huber <nico.h@gmx.de>
Change-Id: Ieeea84b5861f9d15b2472208432169dc8e3f0049
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57218
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Felix Held 2021-08-28 00:01:45 +02:00 committed by Felix Held
parent 73ed5991bc
commit db3337d929
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/amd/common/fsp/Makefile.inc
View File

@ -11,7 +11,7 @@ ifeq ($(CONFIG_FSP_M_FILE),)
$(info There's no FSP-M binary file specified. The resulting image won't boot successfully.) $(info There's no FSP-M binary file specified. The resulting image won't boot successfully.)
else else
ifeq ($(call int-gt,\ ifeq ($(call int-gt,\
$(call file-size,$(call strip_quotes,$(CONFIG_FSP_M_FILE)))\ $(call file-size,$(CONFIG_FSP_M_FILE))\
$(shell printf "%d" $(CONFIG_FSP_M_SIZE))),\ $(shell printf "%d" $(CONFIG_FSP_M_SIZE))),\
1) 1)
$(error FSP-M binary larger than FSP_M_FILE.) $(error FSP-M binary larger than FSP_M_FILE.)