GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/spd_tools: Add Cezanne support to lp4x/gen_spd.go 

To supply memory information for Guybrush, the lpddr4x script for
generating SPDs needs to be updated for Cezanne.

BUG=b:178722935
TEST=Add the part used on Majolica to the global lpddr4x json file
and verify that the output is similar to the actual SPD used for
Majolica.

Signed-off-by: Martin Roth <martin@coreboot.org>
Change-Id: I1f522cb4a92b4fe4c26cad0689437c33ec44befe
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51015
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Martin Roth 2021-02-22 19:17:14 -07:00 committed by Patrick Georgi
parent ff687b1f24
commit db717db5c5
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
util/spd_tools/lp4x/gen_spd.go
View File

@ -29,12 +29,14 @@ const (
PlatformTGLADL = 0 PlatformTGLADL = 0
PlatformJSL = 1 PlatformJSL = 1
PlatformCZN = 2
) )
var platformMap = map[string]int { var platformMap = map[string]int {
"TGL": PlatformTGLADL, "TGL": PlatformTGLADL,
"JSL": PlatformJSL, "JSL": PlatformJSL,
"ADL": PlatformTGLADL, "ADL": PlatformTGLADL,
"CZN": PlatformCZN,
} }
var currPlatform int var currPlatform int
@ -217,7 +219,7 @@ func getMRCDensity(memAttribs *memAttributes) int {
* SPDIndexDensityBanks. Logical channel on TGL is an x16 channel. * SPDIndexDensityBanks. Logical channel on TGL is an x16 channel.
*/ */
return memAttribs.DensityPerChannelGb * TGLLogicalChannelWidth / memAttribs.BitWidthPerChannel return memAttribs.DensityPerChannelGb * TGLLogicalChannelWidth / memAttribs.BitWidthPerChannel
} else if currPlatform == PlatformJSL { } else if currPlatform == PlatformJSL || currPlatform == PlatformCZN {
/* /*
* Intel MRC on JSL expects density per die to be encoded in * Intel MRC on JSL expects density per die to be encoded in
* SPDIndexDensityBanks. * SPDIndexDensityBanks.
@ -269,13 +271,16 @@ func encodePackage(dies int) byte {
return temp << 7 return temp << 7
} }
/* Per JESD209-4C Dies = ZQ balls on the package */
/* Note that this can be different than the part's die count */
func encodeDiesPerPackage(memAttribs *memAttributes) byte { func encodeDiesPerPackage(memAttribs *memAttributes) byte {
var dies int = 0 var dies int = 0
if currPlatform == PlatformTGLADL { if currPlatform == PlatformTGLADL {
/* Intel MRC expects logical dies to be encoded for TGL. */ /* Intel MRC expects logical dies to be encoded for TGL. */
dies = memAttribs.ChannelsPerDie * memAttribs.RanksPerChannel * memAttribs.BitWidthPerChannel / 16 dies = memAttribs.ChannelsPerDie * memAttribs.RanksPerChannel * memAttribs.BitWidthPerChannel / 16
} else if currPlatform == PlatformJSL { } else if currPlatform == PlatformJSL || currPlatform == PlatformCZN {
/* Intel MRC expects physical dies to be encoded for JSL. */ /* Intel MRC expects physical dies to be encoded for JSL. */
/* AMD PSP expects physical dies (ZQ balls) */
dies = memAttribs.DiesPerPackage dies = memAttribs.DiesPerPackage
} }
@ -333,7 +338,7 @@ const (
func encodeBusWidth(memAttribs *memAttributes) byte { func encodeBusWidth(memAttribs *memAttributes) byte {
if currPlatform == PlatformTGLADL { if currPlatform == PlatformTGLADL {
return SPDValueBusWidthTGL return SPDValueBusWidthTGL
} else if currPlatform == PlatformJSL { } else if currPlatform == PlatformJSL || currPlatform == PlatformCZN {
return SPDValueBusWidthJSL return SPDValueBusWidthJSL
} }
return 0 return 0
@ -941,7 +946,11 @@ func usage() {
fmt.Printf(" where,\n") fmt.Printf(" where,\n")
fmt.Printf(" spd_dir = Directory path containing SPD files and manifest generated by gen_spd.go\n") fmt.Printf(" spd_dir = Directory path containing SPD files and manifest generated by gen_spd.go\n")
fmt.Printf(" mem_parts_list_json = JSON File containing list of memory parts and attributes\n") fmt.Printf(" mem_parts_list_json = JSON File containing list of memory parts and attributes\n")
fmt.Printf(" platform = SoC Platform for which the SPDs are being generated\n\n\n") fmt.Printf(" platform = SoC Platform for which the SPDs are being generated\n")
fmt.Printf(" supported platforms: ")
keys := reflect.ValueOf(platformMap).MapKeys()
fmt.Println(keys)
fmt.Printf("\n\n\n")
} }
func main() { func main() {