GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/common: Skip sending DISCONNECT IPC command 

The patch skips sending DISCONNECT IPC command to PMC if system resumes
from S3.

coreboot notice DISCONNECT IPC command getting timedout during S3
resume if system has AC connected behind Type-C hub. This impacts
system resume time. Please refer TA# 730910 for more information.

coreboot need not send the DISCONNECT IPC command when system resumes
from S3 state.

TEST=Verified system boots to OS and verfied below tests on Gimble
1. coreboot doesn't send the DISCONNECT during S3 resume
2. After S3 resume, system detects the pen drive with Superspeed
3. After system resumes from S3, hot-plug the pen drive, system detects
   the pen drive
3. System sends IPC commands when system boots from S0 or S5.

Signed-off-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Change-Id: I6ad006ae8677919c7dfeca8eec0af11454a2e89d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63932
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
This commit is contained in:
Sridhar Siricilla 2022-04-29 15:13:38 +05:30 committed by Felix Held
parent 616c07c87f
commit db8a97a0e0
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/soc/intel/common/block/tcss/tcss.c
View File

@ -422,8 +422,10 @@ void tcss_configure(const struct typec_aux_bias_pads aux_bias_pads[MAX_TYPE_C_PO
if (port_map == NULL) if (port_map == NULL)
return; return;
for (i = 0; i < num_ports; i++) if (!platform_is_resuming()) {
tcss_init_mux(i, &port_map[i]); for (i = 0; i < num_ports; i++)
tcss_init_mux(i, &port_map[i]);
}
/* This should be performed before alternate modes are entered */ /* This should be performed before alternate modes are entered */
if (tcss_ops.configure_aux_bias_pads) if (tcss_ops.configure_aux_bias_pads)