GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/stonyridge: Give I2C devices unique _UIDs 

The ACPI unique identifier (_UID) should be unique.

This doesn't actually matter much for Linux, though, since the kernel
can handle it when the BIOS doesn't get this right.

See:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b4b6cae2f36d92b31788f10816709d5290a1119a
 b4b6cae2f36d ACPI / platform: use ACPI device name instead of _HID._UID

Change-Id: I8b1b3143174584a93f3d45bf482b8922b3f0ec12
Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Reviewed-on: https://review.coreboot.org/23233
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Marc Jones <marc@marcjonesconsulting.com>
This commit is contained in:
Daniel Kurtz 2018-01-11 18:13:32 -08:00 committed by Martin Roth
parent a273753c72
commit dc512f893f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/soc/amd/stoneyridge/acpi/sb_fch.asl
View File

@ -111,7 +111,7 @@ Device (I2CB)
Device (I2CC) { Device (I2CC) {
Name (_HID, "AMD0010") Name (_HID, "AMD0010")
Name (_UID, 0x0) Name (_UID, 0x2)
Name (_CRS, ResourceTemplate() Name (_CRS, ResourceTemplate()
{ {
IRQ (Edge, ActiveHigh, Exclusive) { 6 } IRQ (Edge, ActiveHigh, Exclusive) { 6 }
@ -127,7 +127,7 @@ Device (I2CC) {
Device (I2CD) Device (I2CD)
{ {
Name (_HID, "AMD0010") Name (_HID, "AMD0010")
Name (_UID, 0x1) Name (_UID, 0x3)
Name (_CRS, ResourceTemplate() { Name (_CRS, ResourceTemplate() {
IRQ (Edge, ActiveHigh, Exclusive) { 14 } IRQ (Edge, ActiveHigh, Exclusive) { 14 }
Memory32Fixed(ReadWrite, 0xFEDC5000, 0x1000) Memory32Fixed(ReadWrite, 0xFEDC5000, 0x1000)