soc/amd/common: Replace missing AmdReleaseStruct() calls
The AGESA spec states that "Failure to release a structure can cause undesired outcomes." Uncomment the one in AmdInitLate(). The function only dealocates the structure used for the AGESA entry point, and not the internal data used by coreboot. Release the structure in AmdInitEnv(). This appears to have been an omission years ago when duplicating agesawrapper.c for every mainboard was still common. BUG=b:70671742 TEST=Build and boot Kahlee, inspect console log Change-Id: Ib1ff94ec2acdc845c5e4b4ed7088061cfc0c55f3 Signed-off-by: Marshall Dawson <marshalldawson3rd@gmail.com> Reviewed-on: https://review.coreboot.org/22888 Reviewed-by: Martin Roth <martinroth@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
parent
52f5cdce17
commit
dd2c7b12bb
|
@ -243,6 +243,7 @@ AGESA_STATUS agesawrapper_amdinitenv(void)
|
|||
|
||||
if (status != AGESA_SUCCESS)
|
||||
agesawrapper_readeventlog(EnvParams->StdHeader.HeapStatus);
|
||||
AmdReleaseStruct(&AmdParamStruct);
|
||||
|
||||
return status;
|
||||
}
|
||||
|
@ -345,7 +346,7 @@ AGESA_STATUS agesawrapper_amdinitlate(void)
|
|||
AcpiSlit, AcpiWheaMce, AcpiWheaCmc,
|
||||
AcpiAlib, AcpiIvrs, __func__);
|
||||
|
||||
/* AmdReleaseStruct (&AmdParamStruct); */
|
||||
AmdReleaseStruct(&AmdParamStruct);
|
||||
return Status;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue