From dd549e117588472d11b10e0b1287a0e19377b844 Mon Sep 17 00:00:00 2001 From: Raul E Rangel Date: Mon, 25 Jun 2018 14:22:27 -0600 Subject: [PATCH] smm: Clear SMRAM when debugging This makes it easier to spot unused RAM. BUG=b:80539294 TEST=built and tested on grunt. Verified unused memory was set to 0xcdcdcdcd Change-Id: I335eaf642bd8526f31819eaac95ce80c2df3c300 Signed-off-by: Raul E Rangel Reviewed-on: https://review.coreboot.org/27227 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- src/cpu/x86/smm/smm_module_loader.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c index 3d7952ff42..e92fa05e13 100644 --- a/src/cpu/x86/smm/smm_module_loader.c +++ b/src/cpu/x86/smm/smm_module_loader.c @@ -346,6 +346,10 @@ int smm_load_module(void *smram, size_t size, struct smm_loader_params *params) if (rmodule_parse(&_binary_smm_start, &smm_mod)) return -1; + /* Clear SMM region */ + if (IS_ENABLED(CONFIG_DEBUG_SMI)) + memset(smram, 0xcd, size); + total_stack_size = params->per_cpu_stack_size * params->num_concurrent_stacks;