soc/intel/common: Use 'enum cb_err' values

The patch uses cb_err enum values as return values for function
cse_get_boot_performance_data() instead of true/false.

TEST=Build code for Gimble

Signed-off-by: Sridhar Siricilla <sridhar.siricilla@intel.com>
Change-Id: I0153d5496c96fb0c2a576eef1fe2fa7fa0db8415
Reviewed-on: https://review.coreboot.org/c/coreboot/+/71824
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
This commit is contained in:
Sridhar Siricilla 2023-01-10 15:05:07 +05:30 committed by Martin L Roth
parent ad6d3128f8
commit dd7d51d12f
3 changed files with 6 additions and 6 deletions

View File

@ -156,7 +156,7 @@ void cse_log_ro_write_protection_info(bool mfg_mode)
printk(BIOS_ERR, "ME: Write protection for CSE RO is not enabled\n");
}
bool cse_get_boot_performance_data(struct cse_boot_perf_rsp *boot_perf_rsp)
enum cb_err cse_get_boot_performance_data(struct cse_boot_perf_rsp *boot_perf_rsp)
{
struct cse_boot_perf_req {
struct mkhi_hdr hdr;
@ -174,16 +174,16 @@ bool cse_get_boot_performance_data(struct cse_boot_perf_rsp *boot_perf_rsp)
if (heci_send_receive(&req, sizeof(req), boot_perf_rsp, &resp_size,
HECI_MKHI_ADDR)) {
printk(BIOS_ERR, "cse_lite: Could not get boot performance data\n");
return false;
return CB_ERR;
}
if (boot_perf_rsp->hdr.result) {
printk(BIOS_ERR, "cse_lite: Get boot performance data resp failed: %d\n",
boot_perf_rsp->hdr.result);
return false;
return CB_ERR;
}
return true;
return CB_SUCCESS;
}

View File

@ -22,7 +22,7 @@ static void cbmem_inject_telemetry_data(void)
* 4. All other TS values will be relative to the zero point. The API caller should
* normalize the TS values to the zero-point value.
*/
if (!cse_get_boot_performance_data(&cse_perf_data))
if (cse_get_boot_performance_data(&cse_perf_data) != CB_SUCCESS)
return;
current_time = timestamp_get();

View File

@ -524,7 +524,7 @@ bool skip_cse_sub_part_update(void);
* This command retrieves a set of boot performance timestamps CSME collected during
* the last platform boot flow.
*/
bool cse_get_boot_performance_data(struct cse_boot_perf_rsp *boot_perf);
enum cb_err cse_get_boot_performance_data(struct cse_boot_perf_rsp *boot_perf);
/* Function to make cse disable using PMC IPC */
bool cse_disable_mei_devices(void);