src/northbridge: Drop unneeded empty lines

Change-Id: I5f3118f0f855160ed49adc543b6169fccd7520ee
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44593
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Elyes HAOUAS 2020-08-19 21:41:06 +02:00 committed by Michael Niewöhner
parent 7aa3372ce2
commit dddd1cc691
25 changed files with 0 additions and 44 deletions

View File

@ -27,7 +27,6 @@ static struct device *__f2_dev[FX_DEVS];
static struct device *__f4_dev[FX_DEVS]; static struct device *__f4_dev[FX_DEVS];
static unsigned int fx_devs = 0; static unsigned int fx_devs = 0;
struct dram_base_mask_t { struct dram_base_mask_t {
u32 base; //[47:27] at [28:8] u32 base; //[47:27] at [28:8]
u32 mask; //[47:27] at [28:8] and enable at bit 0 u32 mask; //[47:27] at [28:8] and enable at bit 0

View File

@ -543,7 +543,6 @@ static unsigned long agesa_write_acpi_tables(const struct device *device,
return current; return current;
} }
static struct device_operations northbridge_operations = { static struct device_operations northbridge_operations = {
.read_resources = nb_read_resources, .read_resources = nb_read_resources,
.set_resources = nb_set_resources, .set_resources = nb_set_resources,

View File

@ -37,7 +37,6 @@ void platform_AfterInitPost(struct sysinfo *cb, AMD_POST_PARAMS *Post)
backup_top_of_low_cacheable(Post->MemConfig.Sub4GCacheTop); backup_top_of_low_cacheable(Post->MemConfig.Sub4GCacheTop);
} }
void platform_BeforeInitEnv(struct sysinfo *cb, AMD_ENV_PARAMS *Env) void platform_BeforeInitEnv(struct sysinfo *cb, AMD_ENV_PARAMS *Env)
{ {
EmptyHeap(); EmptyHeap();

View File

@ -243,7 +243,6 @@ static void mchtest_control(mchtst_cc cmd)
pci_write_config32(MCHDEV, MCHTST, dword); pci_write_config32(MCHDEV, MCHTST, dword);
} }
/** /**
* *
*/ */

View File

@ -170,7 +170,6 @@ enum {
#define CMOS_WRITE_TRAINING 0x90 /* 16 bytes #define CMOS_WRITE_TRAINING 0x90 /* 16 bytes
(could be reduced to 10 bytes) */ (could be reduced to 10 bytes) */
#ifndef __ACPI__ #ifndef __ACPI__
#define DEFAULT_MCHBAR ((u8 *)0xfed14000) #define DEFAULT_MCHBAR ((u8 *)0xfed14000)
#define DEFAULT_DMIBAR ((u8 *)0xfed18000) #define DEFAULT_DMIBAR ((u8 *)0xfed18000)
@ -181,7 +180,6 @@ enum {
#define DEFAULT_EPBAR 0xfed19000 #define DEFAULT_EPBAR 0xfed19000
#define DEFAULT_HECIBAR ((u8 *)0xfed1a000) #define DEFAULT_HECIBAR ((u8 *)0xfed1a000)
#define IOMMU_BASE1 0xfed90000 #define IOMMU_BASE1 0xfed90000
#define IOMMU_BASE2 0xfed91000 #define IOMMU_BASE2 0xfed91000
#define IOMMU_BASE3 0xfed92000 #define IOMMU_BASE3 0xfed92000
@ -358,7 +356,6 @@ enum {
#define CxDTAEW(x) (0x1280+(x*0x100)) #define CxDTAEW(x) (0x1280+(x*0x100))
#define CxDTC(x) (0x1288+(x*0x100)) #define CxDTC(x) (0x1288+(x*0x100))
/* /*
* DMIBAR * DMIBAR
*/ */
@ -376,7 +373,6 @@ enum {
#define DMILE2D 0x60 #define DMILE2D 0x60
#define DMILE2A 0x68 #define DMILE2A 0x68
/* /*
* EPBAR * EPBAR
*/ */
@ -390,7 +386,6 @@ enum {
#define EPLE1A 0x58 #define EPLE1A 0x58
#define EPLE2D 0x60 #define EPLE2D 0x60
#ifndef __ACPI__ #ifndef __ACPI__
void gm45_early_init(void); void gm45_early_init(void);
void gm45_early_reset(void); void gm45_early_reset(void);

View File

@ -217,7 +217,6 @@ static void setup_aspm(const stepping_t stepping, const int peg_enabled)
pci_update_config32(pciex, 0xb04, ~(0x03 << 29), 0x01 << 29); pci_update_config32(pciex, 0xb04, ~(0x03 << 29), 0x01 << 29);
} }
/*\ Setup ASPM on DMI \*/ /*\ Setup ASPM on DMI \*/
/* Exit latencies should be checked to be supported by /* Exit latencies should be checked to be supported by
@ -232,7 +231,6 @@ static void setup_aspm(const stepping_t stepping, const int peg_enabled)
DMIBAR8(0x208 + 3) = 0; DMIBAR8(0x208 + 3) = 0;
DMIBAR32(0x208) &= ~(3 << 20); DMIBAR32(0x208) &= ~(3 << 20);
/*\ Setup ASPM on PEG \*/ /*\ Setup ASPM on PEG \*/
/* /*
* Maybe we just have to advertise ASPM through LCAP[11:10] * Maybe we just have to advertise ASPM through LCAP[11:10]
@ -258,7 +256,6 @@ static void setup_rcrb(const int peg_enabled)
/* Link2: link_valid. */ /* Link2: link_valid. */
EPBAR8(EPLE2D) |= (1 << 0); /* link valid */ EPBAR8(EPLE2D) |= (1 << 0); /* link valid */
/*\ RCRB setup: DMI Port \*/ /*\ RCRB setup: DMI Port \*/
/* Set component ID of MCH (1). */ /* Set component ID of MCH (1). */

View File

@ -216,7 +216,6 @@ void enter_raminit_or_reset(void)
pci_write_config8(PCI_DEV(0, 0x1f, 0), 0xa2, reg8 | (1 << 7)); pci_write_config8(PCI_DEV(0, 0x1f, 0), 0xa2, reg8 | (1 << 7));
} }
/* For a detected DIMM, test the value of an SPD byte to /* For a detected DIMM, test the value of an SPD byte to
match the expected value after masking some bits. */ match the expected value after masking some bits. */
static int test_dimm(sysinfo_t *const sysinfo, static int test_dimm(sysinfo_t *const sysinfo,
@ -281,7 +280,6 @@ static void verify_ddr3(sysinfo_t *const sysinfo, int mask)
} }
} }
typedef struct { typedef struct {
int dimm_mask; int dimm_mask;
struct { struct {
@ -1710,7 +1708,6 @@ void raminit(sysinfo_t *const sysinfo, const int s3resume)
/* Check for bad warm boot. */ /* Check for bad warm boot. */
reset_on_bad_warmboot(); reset_on_bad_warmboot();
/***** From now on, program according to collected infos: *****/ /***** From now on, program according to collected infos: *****/
/* Program DRAM type. */ /* Program DRAM type. */
@ -1772,10 +1769,8 @@ void raminit(sysinfo_t *const sysinfo, const int s3resume)
pci_and_config8(PCI_DEV(0, 0, 0), 0xf0, ~(1 << 2)); pci_and_config8(PCI_DEV(0, 0, 0), 0xf0, ~(1 << 2));
/* Take a breath (the reader). */ /* Take a breath (the reader). */
/* Perform ZQ calibration for DDR3. */ /* Perform ZQ calibration for DDR3. */
if (sysinfo->spd_type == DDR3) if (sysinfo->spd_type == DDR3)
ddr3_calibrate_zq(); ddr3_calibrate_zq();

View File

@ -20,7 +20,6 @@
#include "registers/host_bridge.h" #include "registers/host_bridge.h"
/* Device 0:2.0 PCI configuration space (Graphics Device) */ /* Device 0:2.0 PCI configuration space (Graphics Device) */
#define MSAC 0x62 /* Multi Size Aperture Control */ #define MSAC 0x62 /* Multi Size Aperture Control */

View File

@ -78,7 +78,6 @@ static void report_pch_info(void)
int i; int i;
u16 dev_id = pci_read_config16(PCH_LPC_DEV, 2); u16 dev_id = pci_read_config16(PCH_LPC_DEV, 2);
const char *pch_type = "Unknown"; const char *pch_type = "Unknown";
for (i = 0; i < ARRAY_SIZE(pch_table); i++) { for (i = 0; i < ARRAY_SIZE(pch_table); i++) {
if (pch_table[i].dev_id == dev_id) { if (pch_table[i].dev_id == dev_id) {

View File

@ -584,7 +584,6 @@ static u32 freq_to_blc_pwm_ctl(struct device *const dev, u16 pwm_freq)
return BLM_LEGACY_MODE | ((blc_mod / 2) << 17) | ((blc_mod / 2) << 1); return BLM_LEGACY_MODE | ((blc_mod / 2) << 17) | ((blc_mod / 2) << 1);
} }
static void panel_setup(u8 *mmiobase, struct device *const dev) static void panel_setup(u8 *mmiobase, struct device *const dev)
{ {
const struct northbridge_intel_i945_config *const conf = dev->chip_info; const struct northbridge_intel_i945_config *const conf = dev->chip_info;
@ -749,7 +748,6 @@ static struct device_operations gma_func0_ops = {
.acpi_name = gma_acpi_name, .acpi_name = gma_acpi_name,
}; };
static struct device_operations gma_func1_ops = { static struct device_operations gma_func1_ops = {
.read_resources = pci_dev_read_resources, .read_resources = pci_dev_read_resources,
.set_resources = pci_dev_set_resources, .set_resources = pci_dev_set_resources,

View File

@ -87,7 +87,6 @@
#define PEGCC 0x208 /* 32bit */ #define PEGCC 0x208 /* 32bit */
#define PEGSTS 0x214 /* 32bit */ #define PEGSTS 0x214 /* 32bit */
/* Device 0:2.0 PCI configuration space (Graphics Device) */ /* Device 0:2.0 PCI configuration space (Graphics Device) */
#define IGD_DEV PCI_DEV(0, 2, 0) #define IGD_DEV PCI_DEV(0, 2, 0)
@ -96,7 +95,6 @@
#define BSM 0x5c #define BSM 0x5c
#define GCFC 0xf0 /* Graphics Clock Frequency & Gating Control */ #define GCFC 0xf0 /* Graphics Clock Frequency & Gating Control */
/* /*
* MCHBAR * MCHBAR
*/ */

View File

@ -99,7 +99,6 @@ static void mch_domain_read_resources(struct device *dev)
printk(BIOS_DEBUG, "Unused RAM between cbmem_top and TOM: 0x%xK\n", delta_cbmem); printk(BIOS_DEBUG, "Unused RAM between cbmem_top and TOM: 0x%xK\n", delta_cbmem);
/* The following needs to be 2 lines, otherwise the second /* The following needs to be 2 lines, otherwise the second
* number is always 0 * number is always 0
*/ */

View File

@ -318,7 +318,6 @@ static void gather_common_timing(struct sys_info *sysinfo, struct timings *saved
printk(BIOS_DEBUG, "only Single Channel Operation.\n"); printk(BIOS_DEBUG, "only Single Channel Operation.\n");
} }
for (i = 0; i < (2 * DIMM_SOCKETS); i++) { for (i = 0; i < (2 * DIMM_SOCKETS); i++) {
int device = get_dimm_spd_address(sysinfo, i), bytes_read; int device = get_dimm_spd_address(sysinfo, i), bytes_read;
struct dimm_attr_ddr2_st dimm_info; struct dimm_attr_ddr2_st dimm_info;
@ -432,7 +431,6 @@ static void gather_common_timing(struct sys_info *sysinfo, struct timings *saved
i, sysinfo->banksize[(i * 2) + 1] * 32); i, sysinfo->banksize[(i * 2) + 1] * 32);
} }
sysinfo->rows[i] = dimm_info.row_bits; sysinfo->rows[i] = dimm_info.row_bits;
sysinfo->cols[i] = dimm_info.col_bits; sysinfo->cols[i] = dimm_info.col_bits;
sysinfo->banks[i] = dimm_info.banks; sysinfo->banks[i] = dimm_info.banks;

View File

@ -5,7 +5,6 @@
#define DEFAULT_HECIBAR ((u8 *)0xfed17000) #define DEFAULT_HECIBAR ((u8 *)0xfed17000)
#define IOMMU_BASE1 0xfed90000 #define IOMMU_BASE1 0xfed90000
#define IOMMU_BASE2 0xfed91000 #define IOMMU_BASE2 0xfed91000
#define IOMMU_BASE3 0xfed92000 #define IOMMU_BASE3 0xfed92000
@ -93,7 +92,6 @@
#define QPI_PHY_EP_SELECT 0xe0 /* QPI Phys. Layer Electrical Parameter Select */ #define QPI_PHY_EP_SELECT 0xe0 /* QPI Phys. Layer Electrical Parameter Select */
#define QPI_PHY_EP_MCTR 0xf4 /* QPI Phys. Layer Electrical Parameter Misc. Control */ #define QPI_PHY_EP_MCTR 0xf4 /* QPI Phys. Layer Electrical Parameter Misc. Control */
/* Device 0:2.0 PCI configuration space (Graphics Device) */ /* Device 0:2.0 PCI configuration space (Graphics Device) */
#define MSAC 0x62 /* Multi Size Aperture Control */ #define MSAC 0x62 /* Multi Size Aperture Control */

View File

@ -106,7 +106,6 @@ static uintptr_t northbridge_get_tseg_base(void)
return pci_read_config32(HOST_BRIDGE, TSEG); return pci_read_config32(HOST_BRIDGE, TSEG);
} }
/* /*
* Depending of UMA and TSEG configuration, TSEG might start at any 1 MiB alignment. * Depending of UMA and TSEG configuration, TSEG might start at any 1 MiB alignment.
* As this may cause very greedy MTRR setup, push CBMEM top downwards to 4 MiB boundary. * As this may cause very greedy MTRR setup, push CBMEM top downwards to 4 MiB boundary.

View File

@ -941,7 +941,6 @@ static void sdram_p_dqs(struct pllparam *pll, u8 f, u8 clk)
MCHBAR8_AND_OR(C0TXDQS0R0DLL + j, ~0x3f, reg8); MCHBAR8_AND_OR(C0TXDQS0R0DLL + j, ~0x3f, reg8);
} }
static void sdram_p_dq(struct pllparam *pll, u8 f, u8 clk) static void sdram_p_dq(struct pllparam *pll, u8 f, u8 clk)
{ {
u8 rank, dq, reg8, j; u8 rank, dq, reg8, j;

View File

@ -23,7 +23,6 @@ void early_init_dmi(void)
DMIBAR32(0x090c + (i << 5)) &= ~0x000e0000; DMIBAR32(0x090c + (i << 5)) &= ~0x000e0000;
} }
for (i = 0; i < 2; i++) { for (i = 0; i < 2; i++) {
DMIBAR32(0x090c + (i << 5)) &= ~0x01e00000; DMIBAR32(0x090c + (i << 5)) &= ~0x01e00000;
} }

View File

@ -300,7 +300,6 @@ static void find_cas_tck(ramctr_timing *ctrl)
ctrl->CAS = val; ctrl->CAS = val;
} }
static void dram_timing(ramctr_timing *ctrl) static void dram_timing(ramctr_timing *ctrl)
{ {
/* /*

View File

@ -23,8 +23,6 @@ extern const u8 frq_aonpd_map[2][8];
extern const u32 frq_comp2_map[2][8]; extern const u32 frq_comp2_map[2][8];
extern const u32 pattern[32][16]; extern const u32 pattern[32][16];
extern const u8 use_base[63][32]; extern const u8 use_base[63][32];

View File

@ -32,18 +32,15 @@ enum platform_type {
PLATFORM_DESKTOP_SERVER, PLATFORM_DESKTOP_SERVER,
}; };
/* Device 0:0.0 PCI configuration space (Host Bridge) */ /* Device 0:0.0 PCI configuration space (Host Bridge) */
#define HOST_BRIDGE PCI_DEV(0, 0, 0) #define HOST_BRIDGE PCI_DEV(0, 0, 0)
#include "registers/host_bridge.h" #include "registers/host_bridge.h"
/* Devices 0:1.0, 0:1.1, 0:1.2, 0:6.0 PCI configuration space (PCI Express Graphics) */ /* Devices 0:1.0, 0:1.1, 0:1.2, 0:6.0 PCI configuration space (PCI Express Graphics) */
#define AFE_PWRON 0xc24 /* PEG Analog Front-End Power-On */ #define AFE_PWRON 0xc24 /* PEG Analog Front-End Power-On */
/* Device 0:2.0 PCI configuration space (Graphics Device) */ /* Device 0:2.0 PCI configuration space (Graphics Device) */
#define MSAC 0x62 /* Multi Size Aperture Control */ #define MSAC 0x62 /* Multi Size Aperture Control */

View File

@ -129,7 +129,6 @@ static int decrement_dq_dqs(const struct sysinfo *s,
return CB_SUCCESS; return CB_SUCCESS;
} }
#define WT_PATTERN_SIZE 80 #define WT_PATTERN_SIZE 80
static const u32 write_training_schedule[WT_PATTERN_SIZE] = { static const u32 write_training_schedule[WT_PATTERN_SIZE] = {

View File

@ -104,7 +104,6 @@ static uintptr_t northbridge_get_tseg_base(void)
return pci_read_config32(HOST_BRIDGE, D0F0_TSEG); return pci_read_config32(HOST_BRIDGE, D0F0_TSEG);
} }
/* Depending of UMA and TSEG configuration, TSEG might start at any /* Depending of UMA and TSEG configuration, TSEG might start at any
* 1 MiB alignment. As this may cause very greedy MTRR setup, push * 1 MiB alignment. As this may cause very greedy MTRR setup, push
* CBMEM top downwards to 4 MiB boundary. * CBMEM top downwards to 4 MiB boundary.

View File

@ -99,7 +99,6 @@ static void select_cas_dramfreq_ddr2(struct sysinfo *s,
try_cas--; try_cas--;
} }
if ((s->selected_timings.CAS < 3) || (s->selected_timings.tclk == 0)) if ((s->selected_timings.CAS < 3) || (s->selected_timings.tclk == 0))
die("Could not find common memory frequency and CAS\n"); die("Could not find common memory frequency and CAS\n");
@ -411,7 +410,6 @@ static int ddr3_save_dimminfo(u8 dimm_idx, u8 *raw_spd,
return CB_SUCCESS; return CB_SUCCESS;
} }
static void select_discrete_timings(struct sysinfo *s, static void select_discrete_timings(struct sysinfo *s,
const struct abs_timings *timings) const struct abs_timings *timings)
{ {

View File

@ -33,7 +33,6 @@ u32 ddr_to_mhz(u32 speed)
return mhz[speed]; return mhz[speed];
} }
static void program_crossclock(struct sysinfo *s) static void program_crossclock(struct sysinfo *s)
{ {
u8 i, j; u8 i, j;
@ -1283,7 +1282,6 @@ u32 test_address(int channel, int rank)
return channel * 512 * MiB + rank * 128 * MiB; return channel * 512 * MiB + rank * 128 * MiB;
} }
/* DDR3 Rank1 Address mirror /* DDR3 Rank1 Address mirror
* swap the following pins: * swap the following pins:
* A3<->A4, A5<->A6, A7<->A8, BA0<->BA1 */ * A3<->A4, A5<->A6, A7<->A8, BA0<->BA1 */

View File

@ -290,7 +290,6 @@ const u8 post_jedec_tab[3][4][2]= /* [FSB][DDR freq][17:13 or 12:8] */
}, },
}; };
const u32 ddr3_c2_tab[2][3][6][2] = { /* [n-mode][ddr3 freq][CAS][reg] */ const u32 ddr3_c2_tab[2][3][6][2] = { /* [n-mode][ddr3 freq][CAS][reg] */
/* 115h[15:0] 117h[23:0] */ /* 115h[15:0] 117h[23:0] */
{ /* 1N mode */ { /* 1N mode */