GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/spd_tools: Change Mendocino to use 0x13 for LP5x memory type 

Mendocino supports LP5x but currently doesn't support SPDs that use the
LP5x memory type, 0x15. This commit updates set 1 SPDs, which are
currently only used for mendocino, to use 0x13 for their memory type.

BUG=b:245509394
TEST=Generated SPDs, verified that only set 1 have changed to 0x13

Change-Id: I46606cb5ff871296d0214e1f781c3b22e93d24ea
Signed-off-by: Robert Zieba <robertzieba@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/67747
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Reviewed-by: Matt DeVillier <matt.devillier@amd.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
This commit is contained in:
Robert Zieba 2022-09-20 12:36:12 -06:00 committed by Karthik Ramasubramanian
parent 45aae7f10f
commit de6ecd0101
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spd/lp5/set-1/spd-7.hex
View File

@ -1,4 +1,4 @@
23 11 15 0E 86 21 95 18 00 40 00 00 02 02 00 00
23 11 13 0E 86 21 95 18 00 40 00 00 02 02 00 00
00 00 03 00 00 00 00 00 2B 00 90 A8 90 C0 08 60
04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

2
spd/lp5/set-1/spd-8.hex
View File

@ -1,4 +1,4 @@
23 11 15 0E 86 21 B5 18 00 40 00 00 0A 02 00 00
23 11 13 0E 86 21 B5 18 00 40 00 00 0A 02 00 00
00 00 03 00 00 00 00 00 2B 00 90 A8 90 C0 08 60
04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

4
util/spd_tools/src/spd_gen/lp5.go
View File

@ -466,7 +466,9 @@ func LP5GetBankGroups(memAttribs *LP5MemAttributes) int {
func LP5EncodeMemoryType(memAttribs *LP5MemAttributes) byte {
var b byte
if memAttribs.LP5X {
// Mendocino supports LP5x, but doesn't support 0x15 as a memory type currently.
// Temporary workaround until it's supported with ABL changes
if memAttribs.LP5X && LP5CurrSet != 1 {
b = LP5XSPDValueMemoryType
} else {
b = LP5SPDValueMemoryType