GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/block/gpio_banks: clear pull-up/down bits in gpio_input 

If the pin was configured as pull-up/down before this wouldn't get
cleared when calling gpio_input before.

Change-Id: I17d5eccb7492138e64abaecbd7cb853adb8c4d2d
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49117
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
This commit is contained in:
Felix Held 2021-01-05 00:32:25 +01:00
parent ef458dafc0
commit dec00dd010
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/soc/amd/common/block/gpio_banks/gpio.c
View File

@ -157,7 +157,7 @@ void gpio_input_pullup(gpio_t gpio_num)
void gpio_input(gpio_t gpio_num)
{
gpio_and32(gpio_num, ~GPIO_OUTPUT_ENABLE);
gpio_and32(gpio_num, ~(GPIO_PULL_MASK | GPIO_OUTPUT_ENABLE));
}
void gpio_output(gpio_t gpio_num, int value)