GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nb/amd/pi: drop HW_MEM_HOLE_SIZEK Kconfig option 

There's neither need to remove get_hw_mem_hole_info from the code if the
Kconfig option was set to 0 nor the actual value didn't make any
difference in the behavior of the code: When node_id has still its
initial value of -1, domain_read_resources won't use the value of
hole_startk, and when node_id is set to 0, get_hw_mem_hole_info also
sets hole_startk to the actual value that then gets used by
domain_read_resources.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ieffab695a3151ed7f6bf9d6c880bbb43eecf7893
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79609
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Held 2023-12-16 22:42:19 +01:00
parent 7a83ab7612
commit df4955297f
3 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/northbridge/amd/pi/00730F01/Kconfig
View File

@ -10,10 +10,6 @@ config CHIPSET_DEVICETREE
string string
default "northbridge/amd/pi/00730F01/chipset.cb" default "northbridge/amd/pi/00730F01/chipset.cb"
config HW_MEM_HOLE_SIZEK
hex
default 0x100000
config ECAM_MMCONF_BASE_ADDRESS config ECAM_MMCONF_BASE_ADDRESS
default 0xF8000000 default 0xF8000000

7
src/northbridge/amd/pi/00730F01/northbridge.c
View File

@ -555,7 +555,6 @@ static void fam16_finalize(void *chip_info)
} }
} }
#if CONFIG_HW_MEM_HOLE_SIZEK != 0
struct hw_mem_hole_info { struct hw_mem_hole_info {
unsigned int hole_startk; unsigned int hole_startk;
int node_id; int node_id;
@ -563,7 +562,6 @@ struct hw_mem_hole_info {
static struct hw_mem_hole_info get_hw_mem_hole_info(void) static struct hw_mem_hole_info get_hw_mem_hole_info(void)
{ {
struct hw_mem_hole_info mem_hole; struct hw_mem_hole_info mem_hole;
mem_hole.hole_startk = CONFIG_HW_MEM_HOLE_SIZEK;
mem_hole.node_id = -1; mem_hole.node_id = -1;
resource_t basek, limitk; resource_t basek, limitk;
@ -576,15 +574,12 @@ static struct hw_mem_hole_info get_hw_mem_hole_info(void)
} }
return mem_hole; return mem_hole;
} }
#endif
static void domain_read_resources(struct device *dev) static void domain_read_resources(struct device *dev)
{ {
unsigned long mmio_basek; unsigned long mmio_basek;
unsigned long idx = 0; unsigned long idx = 0;
#if CONFIG_HW_MEM_HOLE_SIZEK != 0
struct hw_mem_hole_info mem_hole; struct hw_mem_hole_info mem_hole;
#endif
resource_t basek = 0; resource_t basek = 0;
resource_t limitk = 0; resource_t limitk = 0;
resource_t sizek; resource_t sizek;
@ -594,7 +589,6 @@ static void domain_read_resources(struct device *dev)
/* TOP_MEM MSR is our boundary between DRAM and MMIO under 4G */ /* TOP_MEM MSR is our boundary between DRAM and MMIO under 4G */
mmio_basek = get_top_of_mem_below_4gb() >> 10; mmio_basek = get_top_of_mem_below_4gb() >> 10;
#if CONFIG_HW_MEM_HOLE_SIZEK != 0
/* if the hw mem hole is already set in raminit stage, here we will compare /* if the hw mem hole is already set in raminit stage, here we will compare
* mmio_basek and hole_basek. if mmio_basek is bigger that hole_basek and will * mmio_basek and hole_basek. if mmio_basek is bigger that hole_basek and will
* use hole_basek as mmio_basek and we don't need to reset hole. * use hole_basek as mmio_basek and we don't need to reset hole.
@ -607,7 +601,6 @@ static void domain_read_resources(struct device *dev)
if ((mem_hole.node_id != -1) && (mmio_basek > mem_hole.hole_startk)) { if ((mem_hole.node_id != -1) && (mmio_basek > mem_hole.hole_startk)) {
mmio_basek = mem_hole.hole_startk; mmio_basek = mem_hole.hole_startk;
} }
#endif
get_dram_base_limit(&basek, &limitk); get_dram_base_limit(&basek, &limitk);
sizek = limitk - basek; sizek = limitk - basek;

4
src/northbridge/amd/pi/Kconfig
View File

@ -25,10 +25,6 @@ config S3_VGA_ROM_RUN
source "src/northbridge/amd/pi/00730F01/Kconfig" source "src/northbridge/amd/pi/00730F01/Kconfig"
config HW_MEM_HOLE_SIZEK
hex
default 0x200000
config HEAP_SIZE config HEAP_SIZE
hex hex
default 0xc0000 default 0xc0000