From dfb6a0b1a3f03ca71ba684bc212fc5a8b52962f0 Mon Sep 17 00:00:00 2001 From: Benjamin Doron Date: Wed, 9 Jun 2021 20:19:03 +0000 Subject: [PATCH] util/intelp2m/fsp: Update some deprecated macros Avoid using deprecated macros, where possible. "GpioResetPwrGood" represents multiple valid updated values, depending on the GPIO community and will be more difficult to update. While Kabylake supports both sets of macros, it will cause build errors on Coffeelake. In the GPD group, replace with "GpioDswReset." Replace with "GpioResumeReset" in any GPP group. Change-Id: Iab0bb09adad997bef3a2133c443471d4c634f423 Signed-off-by: Benjamin Doron Reviewed-on: https://review.coreboot.org/c/coreboot/+/54974 Tested-by: build bot (Jenkins) Reviewed-by: Maxim Polyakov --- util/intelp2m/fields/fsp/fsp.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/util/intelp2m/fields/fsp/fsp.go b/util/intelp2m/fields/fsp/fsp.go index be3cde9dab..f7d3f3a007 100644 --- a/util/intelp2m/fields/fsp/fsp.go +++ b/util/intelp2m/fields/fsp/fsp.go @@ -121,10 +121,10 @@ func (FieldMacros) DecodeDW0() { &field { configmap : map[uint8]string { - 0: "GpioResetPwrGood", - 1: "GpioResetDeep", - 2: "GpioResetNormal", - 3: "GpioResetResume", + 0: "GpioResetPwrGood", // TODO: Has multiple values (to GPP and GPD) + 1: "GpioHostDeepReset", + 2: "GpioPlatformReset", + 3: "GpioResumeReset", }, value : dw0.GetResetConfig(), },