From e0b5795b81352aabe72662f48d6b154800021d34 Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Thu, 10 Aug 2017 16:27:48 -0700 Subject: [PATCH] soc/intel/skylake: Configure FSP to skip ME MBP step We do not need or use the Management Engine MBP HOB so that step can be skipped when FSP initializes the ME. BUG=b:64479422 TEST=boot with FSP debug enabled binary and ensure that the output indicates this step is being skipped: Skipping MBP data due to SkipMbpHob set! Change-Id: I5ea22ec4b8b47fa17b1cf2bf562337bfaad5ec0d Signed-off-by: Duncan Laurie Reviewed-on: https://review.coreboot.org/20951 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh Reviewed-by: Subrata Banik --- src/soc/intel/skylake/romstage/romstage_fsp20.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/soc/intel/skylake/romstage/romstage_fsp20.c b/src/soc/intel/skylake/romstage/romstage_fsp20.c index e439d73479..c43bdc300c 100644 --- a/src/soc/intel/skylake/romstage/romstage_fsp20.c +++ b/src/soc/intel/skylake/romstage/romstage_fsp20.c @@ -222,6 +222,9 @@ void platform_fsp_memory_init_params_cb(FSPM_UPD *mupd, uint32_t version) soc_memory_init_params(m_cfg, config); + /* Skip creating Management Engine MBP HOB */ + m_t_cfg->SkipMbpHob = 0x01; + /* Enable DMI Virtual Channel for ME */ m_t_cfg->DmiVcm = 0x01;