GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

exynos5420: re-factor the SDMMC GPIO config routines 

The existing GPIO config routines for SDMMC0-2 are over-generalized
and somewhat confusing as a result. It would work nicely if all SDMMC
ports were configured in the same fashion, but there are a few
exceptions.

For example, the inner function runs differently if we're using 8 bits
of data instead of 4, so a big chunk is skipped for SDMMC2. SDMMC0
requires SD_0_CDn to be an output rather than alternate function and
must have a value set.

This patch trades some verbosity for simplicy. Now the SDMMC GPIO
configuration a straight-forward sequence of GPIO operations
without any exceptions.

Signed-off-by: David Hendricks <dhendrix@chromium.org>

Change-Id: If75075b24c6588c4c1b3be3fb9b1aa95e2fac2d1
Reviewed-on: https://gerrit.chromium.org/gerrit/65248
Reviewed-by: Gabe Black <gabeblack@chromium.org>
Commit-Queue: David Hendricks <dhendrix@chromium.org>
Tested-by: David Hendricks <dhendrix@chromium.org>
Reviewed-on: http://review.coreboot.org/4446
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <patrick@georgi-clan.de>
This commit is contained in:
David Hendricks 2013-08-08 14:09:46 -07:00 committed by Patrick Georgi
parent b9f267ce23
commit e0cfad2b56
1 changed files with 63 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

88
src/cpu/samsung/exynos5420/pinmux.c
View File

@ -19,6 +19,7 @@
#include <console/console.h> #include <console/console.h>
#include <assert.h> #include <assert.h>
#include <stdlib.h>
#include "gpio.h" #include "gpio.h"
#include "cpu.h" #include "cpu.h"
#include "pinmux.h" #include "pinmux.h"
@ -53,52 +54,85 @@ void exynos_pinmux_uart3(void)
exynos_pinmux_uart(GPIO_A14, 2); exynos_pinmux_uart(GPIO_A14, 2);
} }
static void exynos_pinmux_sdmmc(int start, int start_ext) struct gpio {
enum exynos5_gpio_pin pin;
unsigned int func;
unsigned int pull;
unsigned int drv;
};
static void exynos_pinmux_sdmmc(struct gpio *gpios, int num_gpios)
{ {
int i; int i;
if (start_ext) { for (i = 0; i < num_gpios; i++) {
for (i = start_ext; i <= (start_ext + 3); i++) { gpio_set_drv(gpios[i].pin, gpios[i].drv);
gpio_cfg_pin(i, GPIO_FUNC(0x2)); gpio_set_pull(gpios[i].pin, gpios[i].pull);
gpio_set_pull(i, GPIO_PULL_UP); gpio_cfg_pin(gpios[i].pin, GPIO_FUNC(gpios[i].func));
gpio_set_drv(i, GPIO_DRV_4X);
}
}
for (i = 0; i < 3; i++) {
gpio_cfg_pin(start + i, GPIO_FUNC(0x2));
gpio_set_pull(start + i, GPIO_PULL_NONE);
gpio_set_drv(start + i, GPIO_DRV_4X);
}
for (i = 3; i <= 6; i++) {
gpio_cfg_pin(start + i, GPIO_FUNC(0x2));
gpio_set_pull(start + i, GPIO_PULL_UP);
gpio_set_drv(start + i, GPIO_DRV_4X);
} }
} }
void exynos_pinmux_sdmmc0(void) void exynos_pinmux_sdmmc0(void)
{ {
exynos_pinmux_sdmmc(GPIO_C00, GPIO_C30); struct gpio gpios[] = {
{ GPIO_C00, 0x2, GPIO_PULL_NONE, GPIO_DRV_4X }, /* CLK */
{ GPIO_C01, 0x2, GPIO_PULL_NONE, GPIO_DRV_4X }, /* CMD */
/* /*
* MMC0 is intended to be used for eMMC. The card detect pin is used * MMC0 is intended to be used for eMMC. The card detect
* as a VDDEN signal to power on the eMMC. The 5420 iROM makes this * pin is used as a VDDEN signal to power on the eMMC. The
* same assumption. * 5420 iROM makes this same assumption.
*/ */
gpio_set_pull(GPIO_C02, GPIO_PULL_NONE); { GPIO_C02, GPIO_OUTPUT, GPIO_PULL_NONE, GPIO_DRV_4X },
gpio_cfg_pin(GPIO_C02, GPIO_OUTPUT); { GPIO_C03, 0x2, GPIO_PULL_UP, GPIO_DRV_4X }, /* DATA[0] */
{ GPIO_C04, 0x2, GPIO_PULL_UP, GPIO_DRV_4X }, /* DATA[1] */
{ GPIO_C05, 0x2, GPIO_PULL_UP, GPIO_DRV_4X }, /* DATA[2] */
{ GPIO_C06, 0x2, GPIO_PULL_UP, GPIO_DRV_4X }, /* DATA[3] */
{ GPIO_C30, 0x2, GPIO_PULL_UP, GPIO_DRV_4X }, /* DATA[4] */
{ GPIO_C31, 0x2, GPIO_PULL_UP, GPIO_DRV_4X }, /* DATA[5] */
{ GPIO_C32, 0x2, GPIO_PULL_UP, GPIO_DRV_4X }, /* DATA[6] */
{ GPIO_C33, 0x2, GPIO_PULL_UP, GPIO_DRV_4X }, /* DATA[7] */
};
exynos_pinmux_sdmmc(&gpios[0], ARRAY_SIZE(gpios));
/* set VDDEN */
gpio_set_value(GPIO_C02, 1); gpio_set_value(GPIO_C02, 1);
} }
void exynos_pinmux_sdmmc1(void) void exynos_pinmux_sdmmc1(void)
{ {
exynos_pinmux_sdmmc(GPIO_C10, GPIO_D14); struct gpio gpios[] = {
{ GPIO_C10, 0x2, GPIO_PULL_NONE, GPIO_DRV_4X }, /* CLK */
{ GPIO_C11, 0x2, GPIO_PULL_NONE, GPIO_DRV_4X }, /* CMD */
{ GPIO_C12, 0x2, GPIO_PULL_NONE, GPIO_DRV_4X }, /* CDn */
{ GPIO_C13, 0x2, GPIO_PULL_NONE, GPIO_DRV_4X }, /* DATA[0] */
{ GPIO_C14, 0x2, GPIO_PULL_NONE, GPIO_DRV_4X }, /* DATA[1] */
{ GPIO_C15, 0x2, GPIO_PULL_NONE, GPIO_DRV_4X }, /* DATA[2] */
{ GPIO_C16, 0x2, GPIO_PULL_NONE, GPIO_DRV_4X }, /* DATA[3] */
{ GPIO_D14, 0x2, GPIO_PULL_UP, GPIO_DRV_4X }, /* DATA[4] */
{ GPIO_D15, 0x2, GPIO_PULL_UP, GPIO_DRV_4X }, /* DATA[5] */
{ GPIO_D16, 0x2, GPIO_PULL_UP, GPIO_DRV_4X }, /* DATA[6] */
{ GPIO_D17, 0x2, GPIO_PULL_UP, GPIO_DRV_4X }, /* DATA[7] */
};
exynos_pinmux_sdmmc(&gpios[0], ARRAY_SIZE(gpios));
} }
void exynos_pinmux_sdmmc2(void) void exynos_pinmux_sdmmc2(void)
{ {
exynos_pinmux_sdmmc(GPIO_C20, 0); struct gpio gpios[] = {
{ GPIO_C20, 0x2, GPIO_PULL_NONE, GPIO_DRV_4X }, /* CLK */
{ GPIO_C21, 0x2, GPIO_PULL_NONE, GPIO_DRV_4X }, /* CMD */
{ GPIO_C22, 0x2, GPIO_PULL_NONE, GPIO_DRV_4X }, /* CDn */
{ GPIO_C23, 0x2, GPIO_PULL_NONE, GPIO_DRV_4X }, /* DATA[0] */
{ GPIO_C24, 0x2, GPIO_PULL_NONE, GPIO_DRV_4X }, /* DATA[1] */
{ GPIO_C25, 0x2, GPIO_PULL_NONE, GPIO_DRV_4X }, /* DATA[2] */
{ GPIO_C26, 0x2, GPIO_PULL_NONE, GPIO_DRV_4X }, /* DATA[3] */
};
exynos_pinmux_sdmmc(&gpios[0], ARRAY_SIZE(gpios));
} }
static void exynos_pinmux_spi(int start, int cfg) static void exynos_pinmux_spi(int start, int cfg)