GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel/i82801gx 82801ix: Remove OpRegion of SMBus host 

Defining this OpRegion for SMBus controller prevents linux kernel
driver i2c-i801 from registering SMBus under sysfs, with following
error in dmesg:

  ACPI Warning: SystemIO range .. conflicts with OpRegion .. (\_SB.PCI0.SBUS.SMBI)

Solution taken from intel/bd82x6x. Worth noting we do not
define ENABLE_SMBUS_METHODS anywhere currently.

Removed remaining reference to HSTS from GETAC P470.

Change-Id: I7c13d344b0343387681b46019cc5061b1435b46b
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Signed-off-by: Damien Zammit <damien@zamaudio.com>
Reviewed-on: https://review.coreboot.org/16266
Tested-by: build bot (Jenkins)
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Kyösti Mälkki 2016-08-19 23:41:32 +03:00 committed by Nico Huber
parent e8cf4ffbee
commit e0d7e2690f
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/getac/p470/acpi/gpe.asl
View File

@ -56,7 +56,7 @@ Scope (_GPE)
// SMBus (Reserved!) // SMBus (Reserved!)
Method (_L07, 0) Method (_L07, 0)
{ {
Store (0x20, \_SB.PCI0.SBUS.HSTS) // Store (0x20, \_SB.PCI0.SBUS.HSTS)
} }
// COM1/COM2 (RI) // COM1/COM2 (RI)

2
src/southbridge/intel/i82801gx/acpi/smbus.asl
View File

@ -20,6 +20,7 @@ Device (SBUS)
{ {
Name (_ADR, 0x001f0003) Name (_ADR, 0x001f0003)
#ifdef ENABLE_SMBUS_METHODS
OperationRegion (SMBP, PCI_Config, 0x00, 0x100) OperationRegion (SMBP, PCI_Config, 0x00, 0x100)
Field(SMBP, DWordAcc, NoLock, Preserve) Field(SMBP, DWordAcc, NoLock, Preserve)
{ {
@ -53,7 +54,6 @@ Device (SBUS)
NDLH, 8, // Notify Data High Byte NDLH, 8, // Notify Data High Byte
} }
#ifdef ENABLE_SMBUS_METHODS
// Kill all SMBus communication // Kill all SMBus communication
Method (KILL, 0, Serialized) Method (KILL, 0, Serialized)
{ {

2
src/southbridge/intel/i82801ix/acpi/smbus.asl
View File

@ -20,6 +20,7 @@ Device (SBUS)
{ {
Name (_ADR, 0x001f0003) Name (_ADR, 0x001f0003)
#ifdef ENABLE_SMBUS_METHODS
OperationRegion (SMBP, PCI_Config, 0x00, 0x100) OperationRegion (SMBP, PCI_Config, 0x00, 0x100)
Field(SMBP, DWordAcc, NoLock, Preserve) Field(SMBP, DWordAcc, NoLock, Preserve)
{ {
@ -53,7 +54,6 @@ Device (SBUS)
NDLH, 8, // Notify Data High Byte NDLH, 8, // Notify Data High Byte
} }
#ifdef ENABLE_SMBUS_METHODS
// Kill all SMBus communication // Kill all SMBus communication
Method (KILL, 0, Serialized) Method (KILL, 0, Serialized)
{ {