GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/trogdor: Adjust mipi panel backlight gpio 

According hareware design, mipi panel backlight relies on
AP_BKLTEN(GPIO_12) and TP_EN(GPIO_85). Meanwhile, TP_EN(GPIO_85)
needs pull up to enable PP3300_DISP_ON before AP_BKLTEN(GPIO_12) up.

BUG=b:197709288,b:199081803,b:205166230
BRANCH=trogdor
TEST=emerge-strongbad coreboot

Change-Id: Ie9920e5366f6b1ea9e0da228bd211317516b390a
Signed-off-by: Zanxi Chen <chenzanxi@huaqin.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/59044
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Julius Werner <jwerner@chromium.org>
This commit is contained in:
Zanxi Chen 2021-11-09 19:49:10 +08:00 committed by Julius Werner
parent 0087de817a
commit e1095496e1
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/google/trogdor/board.h
View File

@ -15,7 +15,7 @@
#define GPIO_AMP_ENABLE GPIO(23)
/* Display specific GPIOS */
#define GPIO_BACKLIGHT_ENABLE ((CONFIG(TROGDOR_HAS_MIPI_PANEL)) ? GPIO(85) : GPIO(12))
#define GPIO_BACKLIGHT_ENABLE GPIO(12)
/* MIPI panel specific GPIOs. Only for mipi_panel-enabled devices (e.g. Mrbland). */
#if CONFIG(TROGDOR_HAS_MIPI_PANEL)
@ -23,6 +23,7 @@
#define GPIO_AVDD_LCD_ENABLE GPIO(88)
#define GPIO_AVEE_LCD_ENABLE GPIO(21)
#define GPIO_VDD_RESET_1V8 GPIO(87)
#define GPIO_TP_EN GPIO(85)
#define GPIO_EDP_BRIDGE_ENABLE dead_code_t(gpio_t)
#define GPIO_EN_PP3300_DX_EDP dead_code_t(gpio_t)
#define GPIO_PS8640_EDP_BRIDGE_PD_L dead_code_t(gpio_t)
@ -33,6 +34,7 @@
#define GPIO_AVDD_LCD_ENABLE dead_code_t(gpio_t)
#define GPIO_AVEE_LCD_ENABLE dead_code_t(gpio_t)
#define GPIO_VDD_RESET_1V8 dead_code_t(gpio_t)
#define GPIO_TP_EN dead_code_t(gpio_t)
#define GPIO_EDP_BRIDGE_ENABLE (CONFIG(TROGDOR_REV0) ? GPIO(14) : GPIO(104))
#define GPIO_EN_PP3300_DX_EDP (CONFIG(TROGDOR_REV0) ? GPIO(106) : \
(CONFIG(BOARD_GOOGLE_TROGDOR) && board_id() == 1 ? GPIO(30) : \

6
src/mainboard/google/trogdor/mainboard.c
View File

@ -145,6 +145,12 @@ static void configure_mipi_panel(void)
mdelay(5);
gpio_output(GPIO_VDD_RESET_1V8, 1);
}
/*
* In mipi panel, TP_EN(GPIO 85) need pull up before
* GPIO_BACKLIGHT_ENABLE(GPIO12) up.
*/
if (CONFIG(TROGDOR_HAS_MIPI_PANEL))
gpio_output(GPIO_TP_EN, 1);
}
static struct panel_serializable_data *get_mipi_panel(enum lb_fb_orientation *orientation)