GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

util/supermicro: Always include commonlib/bsd/compiler.h 

We rely on `compiler.h` for definitions like `__packed`. Without it,
`smcbiosinfo.c` simply declared a global struct with that name, but
nothing was packed.

Found-by: reproducibility test

Change-Id: Ide055317115fc374a63812bcd3791445ca4f2dcc
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41784
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Nico Huber 2020-05-27 18:08:56 +02:00 committed by Patrick Georgi
parent 5c80519466
commit e16971ac64
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
util/supermicro/Makefile.inc
View File

@ -1,9 +1,11 @@
TOOLCPPFLAGS += -include $(top)/src/commonlib/bsd/include/commonlib/bsd/compiler.h
SMCBIOSINFOTOOL:= $(objutil)/supermicro/smcbiosinfo SMCBIOSINFOTOOL:= $(objutil)/supermicro/smcbiosinfo
$(SMCBIOSINFOTOOL): $(dir)/smcbiosinfo/smcbiosinfo.c $(SMCBIOSINFOTOOL): $(dir)/smcbiosinfo/smcbiosinfo.c
printf " HOSTCC Creating SMCBIOSINFO tool\n" printf " HOSTCC Creating SMCBIOSINFO tool\n"
mkdir -p $(objutil)/supermicro mkdir -p $(objutil)/supermicro
$(HOSTCC) $< -o $@ $(HOSTCC) $(TOOLCPPFLAGS) $< -o $@
ifeq ($(CONFIG_VENDOR_SUPERMICRO),y) ifeq ($(CONFIG_VENDOR_SUPERMICRO),y)
ifneq ($(call strip_quotes, $(CONFIG_SUPERMICRO_BOARDID)),) ifneq ($(call strip_quotes, $(CONFIG_SUPERMICRO_BOARDID)),)